Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3614047pxj; Mon, 21 Jun 2021 02:45:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOgk1H53YFxvYABQ6QzXufoIiATu+o1VlqlCl5kLYm1WS+fWIJEtqruAC04kGq+1vNgHGr X-Received: by 2002:a02:ca4a:: with SMTP id i10mr10958550jal.141.1624268730844; Mon, 21 Jun 2021 02:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624268730; cv=none; d=google.com; s=arc-20160816; b=0mCen1SI6BFZZwnQmNMc+RYWVXK2xPmmlRzVe+L5aYZDs+fhkTmND63lVO5uFxlDzz dmVXqUr1I/pzgupGQbAEuqj1qIEUuQzY6bGjUu3QTabi+1LLozCeyEC2u0gOOQpOWFYG DCvIPpdM+XI8DCfZ2LCzk4sUy9bWVua3nfILQDbRn+pSGXjUj4YSlXjO5eRiE9n/374R T56fc34X2JdoKx+8uqRzlZqX737nR3BhNwyfsQeBcpMVIXfXp58oC5vJUAm+FcuUFEv3 iQ0vKelqyR+/EqQdYpUqpK734kRk8KLDmjxUhQF3lkIycXsW2N37UXr5DEM9tE8YmQGD 5qGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B1TJ7i7KgvD4fdVHGJRMyrwZBOAJHAbvbRMumj5+UHU=; b=kFQRchi2zR+h+xeWoriYWiNB2lAfFXdob9FnIh1v6t3X+cbjIQdqlP86EX+KHpDc7N t/4sLzhwIhb5tzNFT+RDbBX4ZANwYNUc3DLYA882S5m+ex8m8gyw3WYpCGjvqj/Br3u7 L3NiHhDV50LoVTxwhEudr7n6QGPSfZjBYBWH35cMY0wh/Qmvp/h+1TshVMs+q7Mme7lH PlpgvdhJ7SunOepRAn3mgUR6dlnS9lkZbh4Nqz7oVGI64yJGPK/EgwPYUtYbakDahMGO TiS7pR+nQdohxud0kpmPefk7VnFhR7gpGOwYOf9pk5GzbeOdkuOz2Fa/xzHkCiY5LcuM Ri7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=oEH8oXFU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f39si14031623jav.78.2021.06.21.02.45.17; Mon, 21 Jun 2021 02:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=oEH8oXFU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbhFUJrF (ORCPT + 99 others); Mon, 21 Jun 2021 05:47:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFUJrE (ORCPT ); Mon, 21 Jun 2021 05:47:04 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83517C061756 for ; Mon, 21 Jun 2021 02:44:50 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id p66so14970491iod.8 for ; Mon, 21 Jun 2021 02:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B1TJ7i7KgvD4fdVHGJRMyrwZBOAJHAbvbRMumj5+UHU=; b=oEH8oXFU370Br9g3znCrw/jxIio1QtFBa5A6CP3kUeuS19QSTY3vKt9nrCSZuKBVTi 5brliEyrr6r8ljXgjJMpyq43ews7qe56KFUuDJxzbJcL9WSPWymyu7oXKRvhk4GiAZ+3 bLG9WD/aVpzce5J7dH9/+j18PKYirkUpWvUcEIhoSXGcnRXKncDUz+2KoxSQHajjMtrh Lj2MfwxZGzKGt4KClbBqfBPz1ThE/6Od+9F61Wqk66CGQnRf+k+tV6cvO/iQ8cWlxUWf 12ef7wufrr92vtA4YaUgHSigOr78dB94tlRU6ur0x/lc4ColXAz8QnaAIRXtcVd4jLQd Knbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B1TJ7i7KgvD4fdVHGJRMyrwZBOAJHAbvbRMumj5+UHU=; b=PVYLXur0Jf2boR+oD39DLv36nfvpbmNyuTvrN44NHQSfCX261ZFR56JnkA0xxpGFei 5EZiSIyh0C6aBqJ0vUXbY9nVLy54tTnMJWmlUF7WaF7l6BExQDC4cWokYOnK7aIKs2A2 hG8tGZpF1Bvohd1XZUhWUPQBA59ocLFaWISQGpSrlltNNqGlsl/mxVA4pW8zSIuUMxul keH9o8PGMiobvTsu+MNLDMcPUkYFf3RSI5z0pRLKPNqwakxJ7fqtBw/KTKHNEp0b7m/z OCdpjGiRkAupi8kWKaKK+fj0s22Lh1JT6r6itaxRpCmnFIppDZSXRiJ3JeteVPsFux49 LtXw== X-Gm-Message-State: AOAM533MzyPLyOna3zRQRACsFtomaWiPDS6Z10OYGgoouxq7tCoTCXGT 68tRyrX6VI3lTatf1FjjeZLK1ML4X2tXYbxYAmM49Q== X-Received: by 2002:a6b:5908:: with SMTP id n8mr1139742iob.185.1624268689710; Mon, 21 Jun 2021 02:44:49 -0700 (PDT) MIME-Version: 1.0 References: <1624266114-21539-1-git-send-email-kewei.xu@mediatek.com> <1624266114-21539-4-git-send-email-kewei.xu@mediatek.com> In-Reply-To: <1624266114-21539-4-git-send-email-kewei.xu@mediatek.com> From: Tzung-Bi Shih Date: Mon, 21 Jun 2021 17:44:38 +0800 Message-ID: Subject: Re: [PATCH V2 3/3] i2c: mediatek: Isolate speed setting via dts for special devices To: kewei.xu@mediatek.com Cc: bbrezillon@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, leilk.liu@mediatek.com, qii.wang@mediatek.com, liguo.zhang@mediatek.com, xinping.qian@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 5:03 PM wrote: > @@ -1293,8 +1355,8 @@ static int mtk_i2c_parse_dt(struct device_node *np, struct mtk_i2c *i2c) > i2c->have_pmic = of_property_read_bool(np, "mediatek,have-pmic"); > i2c->use_push_pull = > of_property_read_bool(np, "mediatek,use-push-pull"); > - > - i2c_parse_fw_timings(i2c->dev, &i2c->timing_info, true); Looks like the patch removes the line accidentally.