Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945929AbWKJByv (ORCPT ); Thu, 9 Nov 2006 20:54:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1945915AbWKJByv (ORCPT ); Thu, 9 Nov 2006 20:54:51 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:55994 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1945929AbWKJByu (ORCPT ); Thu, 9 Nov 2006 20:54:50 -0500 Message-ID: <4553DBE4.2060004@us.ibm.com> Date: Thu, 09 Nov 2006 17:54:44 -0800 From: Badari Pulavarty User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Badari Pulavarty CC: =?ISO-8859-15?Q?S=E9bastien_Dugu=E9?= , "linux-kernel@vger.kernel.org" , Suparna Bhattacharya , Ulrich Drepper , Zach Brown , Dave Jones , Jean Pierre Dion , "linux-aio@kvack.org" Subject: Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification References: <1163087717.3879.34.camel@frecb000686> <1163087946.3879.43.camel@frecb000686> <4553DB5C.8030405@us.ibm.com> In-Reply-To: <4553DB5C.8030405@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 784 Lines: 27 Badari Pulavarty wrote: > S?bastien Dugu? wrote: >> AIO completion signal notification >> >> >> + >> + /* Release task ref */ >> + if (req->ki_notify.notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID)) >> + put_task_struct(req->ki_notify.target); >> + > Huh ?? I thought user can set SIGEV_SIGNAL or SIGEV_THREAD_ID. > Not both. Isn't it ? Shouldn't this be ? > > if ((req->ki_notify.notify == SIGEV_SIGNAL) || > (req->ki_notify.notify == SIGEV_THREAD_ID)) > ... > Never mind.. got it. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/