Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 21 Jun 2021 12:56:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ojaswin Mujoo <ojaswin98@gmail.com>
Cc:     nsaenz@kernel.org, gregkh@linuxfoundation.org,
        stefan.wahren@i2se.com, arnd@arndb.de, phil@raspberrypi.com,
        bcm-kernel-feedback-list@broadcom.com,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] staging: vchiq: Move vchiq char driver to its own
 file
Message-ID: <20210621095631.GF1901@kadam>
References: <cover.1624185152.git.ojaswin98@gmail.com>
 <8cd9b5899f82eaf2efdc9caa8d07f719a592a94d.1624185152.git.ojaswin98@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8cd9b5899f82eaf2efdc9caa8d07f719a592a94d.1624185152.git.ojaswin98@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Jun 20, 2021 at 06:26:34PM +0530, Ojaswin Mujoo wrote:
> +/* read a user pointer value from an array pointers in user space */
> +static inline int vchiq_get_user_ptr(void __user **buf, void __user *ubuf, int index)
> +{
> +	int ret;
> +
> +	if (in_compat_syscall()) {
> +		compat_uptr_t ptr32;
> +
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
When I'm reviewing these sorts of patches then what I'm trying to verify
is that you are not a UMN "researcher" trying to change the code without
anyone noticing.  In the orignal code, there was no blank line here

> +		compat_uptr_t __user *uptr = ubuf;

but there was a blank line here.

> +		ret = get_user(ptr32, uptr + index);
> +		*buf = compat_ptr(ptr32);
> +	} else {

These sorts of minor white space changes make it hard to verify the code
in an automated way.

> +		uintptr_t ptr, __user *uptr = ubuf;
> +
> +		ret = get_user(ptr, uptr + index);
> +		*buf = (void __user *)ptr;
> +	}
> +
> +	return ret;
> +}
> +

regards,
dan carpenter