Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V4 06/12] trace: Add a generic function to read/write u64
 values from tracefs
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Phil Auld <pauld@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Kate Carcia <kcarcia@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Clark Willaims <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1623746916.git.bristot@redhat.com>
 <681a2fb508b3dad2979ac705c3df633f14abb9b2.1623746916.git.bristot@redhat.com>
 <20210618125651.7de04840@oasis.local.home>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
Message-ID: <1a8ccc87-6f04-7918-65ad-76c0cf13af07@redhat.com>
Date:   Mon, 21 Jun 2021 13:50:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210618125651.7de04840@oasis.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/18/21 6:56 PM, Steven Rostedt wrote:
>> +        return simple_read_from_buffer(ubuf, cnt, ppos, buf, len);
> Egad, this entire patch is filled with whitespace issues!
> 
> Please check your other patches too.

<talking to myself>
daniel daniel daniel.... after all these years...
</talking to myself>

Sorry... it was only in this patch.

>> +}
>> +
> 
>> +
>> +#define ULL_STR_SIZE		22	/* 20 digits max */
> Nit. I'd make this 24, just to be integer aligned. I mean, it's used as:
> 
> 
> trace_min_max_read(struct file *filp, char __user *ubuf, size_t cnt,
> 		      loff_t *ppos)
> {
> 	struct trace_min_max_param *param = filp->private_data;
> 	char buf[ULL_STR_SIZE];
> 	u64 val;
> 	int len;
> 
> Probably should reverse the above as well, that way if you do have
> ULL_STR_SIZE as 24, then the int len, will fit right in before the u64
> val. Although, I think compilers are free to optimize that too :-/

I will do that!

-- Daniel

> -- Steve
>