Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org,
 zou_wei@huawei.com
Subject: Re: [PATCH 5/6] firmware: xilinx: instantiate xilinx event manager
 driver
To:     Michal Simek <michal.simek@xilinx.com>,
        Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
CC:     <rajan.vaja@xilinx.com>, <manish.narani@xilinx.com>,
        <zou_wei@huawei.com>, <amit.sunil.dhamne@xilinx.com>,
        <lakshmi.sai.krishna.potthuri@xilinx.com>,
        <wendy.liang@xilinx.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <1622217566-1856-1-git-send-email-abhyuday.godhasara@xilinx.com>
 <1622217566-1856-6-git-send-email-abhyuday.godhasara@xilinx.com>
 <1155e79d-7c66-d772-d5ce-7d346ee8d8a0@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <4e43bd3f-26ae-e85d-7d32-2bebe5c09a5c@xilinx.com>
Date:   Mon, 21 Jun 2021 13:58:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1155e79d-7c66-d772-d5ce-7d346ee8d8a0@xilinx.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2021 11:58:13.8878
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e2359749-514d-41fe-b293-08d934abd951
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0005.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB3175
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/21/21 1:48 PM, Michal Simek wrote:
> 
> 
> On 5/28/21 5:59 PM, Abhyuday Godhasara wrote:
>> Register simple platform device to instantiate Xilinx event
>> manager driver.
>>
>> Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
>> Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
>> ---
>>  drivers/firmware/xilinx/zynqmp.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>> index ce16a72..31f7857 100644
>> --- a/drivers/firmware/xilinx/zynqmp.c
>> +++ b/drivers/firmware/xilinx/zynqmp.c
>> @@ -23,6 +23,7 @@
>>  #include <linux/hashtable.h>
>>  
>>  #include <linux/firmware/xlnx-zynqmp.h>
>> +#include <linux/firmware/xlnx-event-manager.h>
>>  #include "zynqmp-debug.h"
>>  
>>  /* Max HashMap Order for PM API feature check (1<<7 = 128) */
>> @@ -31,6 +32,8 @@
>>  static bool feature_check_enabled;
>>  static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>  
>> +static struct platform_device *em_dev;
>> +
>>  /**
>>   * struct pm_api_feature_data - PM API Feature data
>>   * @pm_api_id:		PM API Id, used as key to index into hashmap
>> @@ -1412,6 +1415,15 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
>>  
>>  	zynqmp_pm_api_debugfs_init();
>>  
>> +	np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
>> +	if (np) {
>> +		em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager",
>> +						       -1, NULL, 0);
>> +		if (IS_ERR(em_dev))
>> +			dev_err_probe(&pdev->dev, PTR_ERR(pdev), "EM register fail with error\n");

Above you have IS_ERR(em_dev) and here PTR_ERR(pdev) this should be
PTR_ERR(em_dev).


>> +	}
>> +	of_node_put(np);
>> +
>>  	return of_platform_populate(dev->of_node, NULL, NULL, dev);
>>  }
>>  
>> @@ -1429,6 +1441,8 @@ static int zynqmp_firmware_remove(struct platform_device *pdev)
>>  		kfree(feature_data);
>>  	}
>>  
>> +	platform_device_unregister(em_dev);
>> +
>>  	return 0;
>>  }
>>  
>>
> 
> Acked-by: Michal Simek <michal.simek@xilinx.com>

With above fixed please add this line.

Thanks,
Michal