Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V4 10/12] trace: Add osnoise tracer
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Phil Auld <pauld@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Kate Carcia <kcarcia@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Clark Willaims <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1623746916.git.bristot@redhat.com>
 <c555b92d6cfef5b3d05c426696d98553c1a46c8d.1623746916.git.bristot@redhat.com>
 <20210618135511.7c06a635@oasis.local.home>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
Message-ID: <1b7876e9-909e-8f69-986e-11110890afbc@redhat.com>
Date:   Mon, 21 Jun 2021 14:09:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210618135511.7c06a635@oasis.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/18/21 7:55 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:49 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> 
>> diff --git a/arch/x86/kernel/trace.c b/arch/x86/kernel/trace.c
>> new file mode 100644
>> index 000000000000..e67d63657628
>> --- /dev/null
>> +++ b/arch/x86/kernel/trace.c
>> @@ -0,0 +1,238 @@
>> +#include <asm/trace/irq_vectors.h>
>> +
>> +#ifdef CONFIG_OSNOISE_TRACER
>> +extern void osnoise_trace_irq_entry(int id);
>> +extern void osnoise_trace_irq_exit(int id, const char *desc);
> Any reason to have the above outside the LOCAL_APIC def?

no...

It's not used.
> In fact, this could just be turned into:
> 
> #if defined(CONFIG_OSNOISE_TRAECR) && defined(CONFIG_X86_LOCAL_APIC)

I will do that!

-- Daniel

> -- Steve
> 
> 
>> +
>> +#ifdef CONFIG_X86_LOCAL_APIC
> [..]
>