Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V4 12/12] trace/osnoise: Support hotplug operations
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Phil Auld <pauld@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Kate Carcia <kcarcia@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Clark Willaims <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1623746916.git.bristot@redhat.com>
 <ee28d6e8b028a66a1d624895cf0aa04ddd17cb37.1623746916.git.bristot@redhat.com>
 <20210618150443.44a49826@oasis.local.home>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
Message-ID: <10eca4c6-999f-5d48-3fb3-4f8ab7d8b8b3@redhat.com>
Date:   Mon, 21 Jun 2021 14:18:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210618150443.44a49826@oasis.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/18/21 9:04 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:51 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> 
>> @@ -1566,7 +1627,14 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
>>  		osnoise_tracer_stop(tr);
>>  
>>  	mutex_lock(&interface_lock);
>> +	/*
>> +	 * osnoise_cpumask is ready by CPU hotplug operations.
> 
> I don't understand the usage of "ready" above. Lost in translation?
> 
> 	 * osnoise_cpumask is updated by CPU hotplug operations.

I think I meant "read"... I will use your comment.

Thanks

-- Daniel
> ?
> 
> -- Steve
> 
> 
>> +	 */
>> +	get_online_cpus();
>> +
>>  	cpumask_copy(&osnoise_cpumask, osnoise_cpumask_new);
>> +
>> +	put_online_cpus();
>>  	mutex_unlock(&interface_lock);
>>  
>