Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fuse: Send FUSE_WRITE_KILL_SUIDGID for killpriv v1
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210423151919.195033-1-ckuehl@redhat.com>
 <CAJfpegsXXGcZDbbtDoXG8sQqHrAS1fs-TsRz5ndQ62sse1Av_w@mail.gmail.com>
From:   Connor Kuehl <ckuehl@redhat.com>
Message-ID: <74f1eff1-570d-03b1-7a27-1ec343c5c3ab@redhat.com>
Date:   Mon, 21 Jun 2021 08:54:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <CAJfpegsXXGcZDbbtDoXG8sQqHrAS1fs-TsRz5ndQ62sse1Av_w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/21/21 3:26 AM, Miklos Szeredi wrote:
> On Fri, 23 Apr 2021 at 17:19, Connor Kuehl <ckuehl@redhat.com> wrote:
>>
>> FUSE doesn't seem to be adding the FUSE_WRITE_KILL_SUIDGID flag on write
>> requests for FUSE connections that support FUSE_HANDLE_KILLPRIV but not
>> FUSE_HANDLE_KILLPRIV_V2.
>>
>> However, the FUSE userspace header states:
>>
>>         FUSE_HANDLE_KILLPRIV: fs handles killing suid/sgid/cap on
>>         write/chown/trunc
>>         ^^^^^
>>
>> To improve backwards compatibility with file servers that don't support
>> FUSE_HANDLE_KILLPRIV_V2, add the FUSE_WRITE_KILL_SUIDGID flag to write
>> requests if FUSE_HANDLE_KILLPRIV has been negotiated -OR- if the
>> conditions for FUSE_HANDLE_KILLPRIV_V2 support are met.
> 
> 
> If server does not support FUSE_HANDLE_KILLPRIV_V2, then it does not
> support FUSE_WRITE_KILL_SUIDGID either.  The two were introduced
> together and the latter is only meaningful if the
> FUSE_HANDLE_KILLPRIV_V2 feature was negotiated.
> 
> What am I missing?

You're not missing anything, this patch is wrong. Let's nack this.

Thanks!

Connor