Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3844745pxj; Mon, 21 Jun 2021 07:51:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiIpPbud/YGRnIuh05nOAZbH1+VBuQqbaY095/Xlcrffe0eQHizne71eELJfO35QIY7gvA X-Received: by 2002:a17:906:2bdb:: with SMTP id n27mr10882656ejg.312.1624287080040; Mon, 21 Jun 2021 07:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624287080; cv=none; d=google.com; s=arc-20160816; b=q22I59Ie+waiqzjqlXj6HvXQgS9+SDRcmf4LLYrHSOk4fM+vL1PQ3Iuz7rttRe8d09 jexPFo0SnB1W+UesHFe6TIMknOjqkaQAUnFUeD8TZa4ntnYVFW5+huzMPBKvscPQkQ1I +cpLAtYZLxbPhxnulrB+8XZLKxAJ3Y5cK2bbFbyRapc86D9ww4Cgkq5e0GbW0UbnhFYO 8ZlBhJ5hRMZ1PNP/TmvNuTrk/2dFE7fYJL234NdizKCsf668U7iInoKcNpX23RW9x37w X1QIfv6hhu+XNNFZvfw5r8GHrO5zHeSBlF1mvCKUb3BMf624Qum8ebXNT7816ZiBaTU2 34YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=7EhCVDJi9/mtNith6sHIuVtzdsDVwMIUM7u21aSrhMw=; b=vYpWkFdohOuc8GbjCQctYocupJA0Ql9wcR7AVodNxU/tIZcJY8TIoB421k/ehSkBRA w7rnZkBwcg07zL8SjcRWWmjxXDVrKcIUOooLnenCzoqD3Wbtn1QGSBqygh1NeYMd4Oh3 poS6BwkA9cE/B0CQfwFAD+S9xDPDFSYwuYJiLiRXUAE6rpzUx7+4hGM+WYE/wHqNio11 Y7wsNL1L2x97jXx4GNm5DBHZU59ziUYUyhbBvtcEsRhUNE9XZnpczL3RdnFBTOBaQM+1 8PEa6aY/4gL9zRorgO89/tqEnWEUwAZ/id8JqNRehOhaKQHSJf6U45rV5m481R0d2Zlv l13Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=pMj9icez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z11si13411111edr.406.2021.06.21.07.50.57; Mon, 21 Jun 2021 07:51:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=pMj9icez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbhFUOwI (ORCPT + 99 others); Mon, 21 Jun 2021 10:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbhFUOwG (ORCPT ); Mon, 21 Jun 2021 10:52:06 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEFEAC061574 for ; Mon, 21 Jun 2021 07:49:50 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id o19so13566306qtp.5 for ; Mon, 21 Jun 2021 07:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7EhCVDJi9/mtNith6sHIuVtzdsDVwMIUM7u21aSrhMw=; b=pMj9icezCyVPhAoUcyIC4hXg8iF9vNR6ki/LwTLTUx9T50dBy/aY+JIQc2BM9Hz1/z JkL9Jm7F3sTwTj1cBu4VqQ0lfWp+QeZb+UHm3PoPx1trXAkMT1LHeTAZ6a272Hh7Cypf IolYhYiuvw6yY/3OnYlCLxHAyGeUoFVQKeTwptIxn6w6eA5jjABocMAs4na9+zV2VW5T rz9L38LXMzbPG5+9/L86DpSMJOUqS31ppQLS8vlTPUn6gfpb9oKUdfcwayMnbRDQquI9 O2qE291+F/7jfBsLM1X67J41Z4Pn6F3VqTRzoFIhrsTP3dOflNs6XlBQ7VQiN7wGxWNO b1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7EhCVDJi9/mtNith6sHIuVtzdsDVwMIUM7u21aSrhMw=; b=NPXEglX4DQLolwBxGZ8oq/qfPd9dTcOnLUzy+WdT12nQCaqEcAyFiPF1JFyEjTv1uP AbyEn+yChqXT/wJ9D/XRxBCIFSVn/Ga8Qo5aw9Q/PVofppttVR86w/5ymfirf/wk6TzO Cf3wlhIzZ4+kedVgtk/gx9txPG54NKfukUhf+0ePhDviTRMUd8A3Ce3V6ffTMCYkVlLd V8cK8qWJu+OgcAi2ikuGNzV3sKx5cnkOmze0lug+NmsKt956ngJtPV9jx9Fsngq/h6Hg VheFp1yUSeNqG1KS/Yu9LuNyHNzZXsbJV6f6Q9s8Ewp2JtN9zol7XP//hIdmnqTKgSgR GRTw== X-Gm-Message-State: AOAM533p2qGYYRVGC516grOvf2V1VdpFDWEWi8W4fXDSmwPvEouVff0e 2QUK+zAHk5Bap9RJojq6Xwkk3Q== X-Received: by 2002:ac8:4d84:: with SMTP id a4mr24377635qtw.319.1624286989919; Mon, 21 Jun 2021 07:49:49 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-113-94.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.113.94]) by smtp.gmail.com with ESMTPSA id 186sm4426217qkf.29.2021.06.21.07.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:49:49 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lvLFE-009XIx-Pt; Mon, 21 Jun 2021 11:49:48 -0300 Date: Mon, 21 Jun 2021 11:49:48 -0300 From: Jason Gunthorpe To: Greg KH , Oded Gabbay , linux-rdma , "open list:DMA BUFFER SHARING FRAMEWORK" , Doug Ledford , "airlied@gmail.com" , Linux Kernel Mailing List , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Gal Pressman , sleybo@amazon.com, dri-devel , Tomer Tayar , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , Leon Romanovsky , Christoph Hellwig Subject: Re: [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF Message-ID: <20210621144948.GG1096940@ziepe.ca> References: <20210618123615.11456-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 04:20:35PM +0200, Daniel Vetter wrote: > Also unless we're actually doing this properly there's zero incentive for > me to review the kernel code and check whether it follows the rules > correctly, so you have excellent chances that you just break the rules. > And dma_buf/fence are tricky enough that you pretty much guaranteed to > break the rules if you're not involved in the discussions. Just now we > have a big one where everyone involved (who's been doing this for 10+ > years all at least) realizes we've fucked up big time. This is where I come from on dmabuf, it is fiendishly complicated. Don't use it unless you absoultely have to, are in DRM, and have people like Daniel helping to make sure you use it right. It's whole premise and design is compromised by specialty historical implementation choices on the GPU side. Jason