Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3866612pxj; Mon, 21 Jun 2021 08:16:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxs8Sv1jKeemtXHrIgUIOzMPtWwA4pzwiWp1no1Lsww3fBPFZ0TqulPNSQgDOkdFOX5gwJB X-Received: by 2002:aa7:d34f:: with SMTP id m15mr1556059edr.311.1624288604030; Mon, 21 Jun 2021 08:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624288604; cv=none; d=google.com; s=arc-20160816; b=WWJv1K5aDgGGbXRAN236OMqCaCXnz2E8nW6TJiGKo65Ygg8cMOQqH1egjGDA9F3FjQ uNIPhKFbgvyQ+oltWDh8tYR6EzZn8rc7DYkGZ+Ln8y/exRwo0Jetn9vxYG+KPtjMQJ7D AAB4KlnOmoGXoJhye/RZ/4+EZ9xZQRAWYKXhmqKI/drWlYjmxU4QhnOfnSWjwvb2W2qm ttnY2vY5xxksa0SELIoGWJ0qI8ebIYXECurxnmdHUstDJsMoMBn/B1jZucMdJyE/cUoV WghnLR4dTQbhQBjaXaPm0fpvDFH9gXP/FiYvGrkBQW1BdveVA73eWDWqfhEieBUed87U mVIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=/UbDJlyhu5TBfBSOuF9PQMD15Y6wwVQRXBbIt94SiGE=; b=qrW2aCnM1bX5Vh+apcg3cTcXk61tYkJpbbNiU9MJvmGg7kUg0A1jYhCU4OZTrc1Tjf ilRYaEecbdvpV+/bedlKWhETRiln6b1w1CXZlArHBwBIsPsE5xMPA2+9qJk0vTrb3ctw CGZ+QCkU/MlCw2uN4yFZ98hNU02F3O4GdYNl3cB/xFdrpSBHZhH1jtCRTOEDetmH7JXN oM1HjYAkhwYxXHBEtNxdql9rjdzPU1xzYfyDqUfZ0GmT+a1luLPU6zTP6GbIAO/mXVWq joR1rNwcvCAGl8dsQgLQtxM2+usWbxzaO+kHkVccqDV7Kxfh9KpW0rszEPZI3HA2UV27 qIHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si17052158edr.98.2021.06.21.08.16.21; Mon, 21 Jun 2021 08:16:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbhFUPPf (ORCPT + 99 others); Mon, 21 Jun 2021 11:15:35 -0400 Received: from mga04.intel.com ([192.55.52.120]:18874 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230170AbhFUPPa (ORCPT ); Mon, 21 Jun 2021 11:15:30 -0400 IronPort-SDR: 4xJI4jh8Isr0TEm1gz0vA/gSEquHrDcc71WK/jkpQ/1gN61JtwJbN+TnyQfkk2FSXExi2EAa9g HQduvBx/bGqA== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="205039509" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="205039509" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 08:13:16 -0700 IronPort-SDR: SQIkoy09putV/Ql2txh0hqWJIwp+1TxlKkvEzpitMzhIu6Usem4c4XT9jPENZKpMziE49fhv3o SOYKeFOngyVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="486522877" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 21 Jun 2021 08:13:14 -0700 From: Alexander Shishkin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Alexander Shishkin , Andy Shevchenko Subject: [PATCH 2/4] intel_th: Remove an unused exit point from intel_th_remove() Date: Mon, 21 Jun 2021 18:12:44 +0300 Message-Id: <20210621151246.31891-3-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210621151246.31891-1-alexander.shishkin@linux.intel.com> References: <20210621151246.31891-1-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König As described in the added comment device_for_each_child() never returns a non-zero value. So remove the corresponding error check. This simplifies the quest to make struct bus_type::remove() return void. Signed-off-by: Uwe Kleine-König Signed-off-by: Alexander Shishkin Reviewed-by: Andy Shevchenko --- drivers/hwtracing/intel_th/core.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c index 24d0c974bfd5..4bf025ef2031 100644 --- a/drivers/hwtracing/intel_th/core.c +++ b/drivers/hwtracing/intel_th/core.c @@ -100,16 +100,18 @@ static int intel_th_remove(struct device *dev) struct intel_th_driver *thdrv = to_intel_th_driver(dev->driver); struct intel_th_device *thdev = to_intel_th_device(dev); struct intel_th_device *hub = to_intel_th_hub(thdev); - int err; if (thdev->type == INTEL_TH_SWITCH) { struct intel_th *th = to_intel_th(hub); int i, lowest; - /* disconnect outputs */ - err = device_for_each_child(dev, thdev, intel_th_child_remove); - if (err) - return err; + /* + * disconnect outputs + * + * intel_th_child_remove returns 0 unconditionally, so there is + * no need to check the return value of device_for_each_child. + */ + device_for_each_child(dev, thdev, intel_th_child_remove); /* * Remove outputs, that is, hub's children: they are created -- 2.30.2