Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3920107pxj; Mon, 21 Jun 2021 09:23:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1Qmt7JyJlSpo7piNZW948Rbkd2jZCLjQAgHui+xsDA3nN/XgV00TqQAPKOXXEZPawi5Vd X-Received: by 2002:a05:6402:50ce:: with SMTP id h14mr22797284edb.219.1624292592091; Mon, 21 Jun 2021 09:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624292592; cv=none; d=google.com; s=arc-20160816; b=Qg55bxlJSQA9G8qID6evtdujGn8XNwziVfANU1jBBk4ABqI/SYhqFWGy/UsYPUV5BN NhkyBUibhoymAJhrnyIsRw4b2ZYRC+W1FwHIN0mLBy94CfgoSwv0jN49/AmQsxKwMAoA zkCvRsc2h8i69CJbNEeUYkeJB1pSAMN24zD9W3Gbl9Q7yobJWiQl3sraCkC/endiTXES NrG000dbjmOAABF75uJwpUBv9dKzqoYxY+o11/pXhz/bGrmtO8jSf/MdaS7JzJeRMo7z mud/kTTbRkSYNJzXdVZHwKkgSiA6h5Ut2wqWgLhCerVmI2OtiWKjCV0+PFKeeo7LAYns 7tfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EJJLg4FNUxW0yS8ZaS00DAo8WyyC1uJLJHUkdGqFO6w=; b=d3LZAtm9qfFUt+lacgpRZU6DNR+0UAtvBq5jr24viT6LDMmX3RM5ohv3/REf3QOogc uAMGic1INOfsglYs9iLHM9InlLJXxp5jLhoA+K3q6CfeNK2/zDnGSGfm9kEol1c+4zkr NA56gKsTiDK48jTQV2Di2EyijcN9lph4PSSLORIawvwlJyG8ex9yMyzUG2YiijxcokpU uZPsCk0jCZphW2R56TgGykULJ99ViHSsq/Ri2qbU1umUqetDM2BIxpCNRbKSX90Mwivy nwdN1fJjmTf1YOJozzC0H+aDoXbYkxTd9zRfkqdQNjnzAwX/TXuqm0ohTQaR91JluczO qtLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GMTJi2LJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id el8si4884808ejc.231.2021.06.21.09.22.50; Mon, 21 Jun 2021 09:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GMTJi2LJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231434AbhFUQV2 (ORCPT + 99 others); Mon, 21 Jun 2021 12:21:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:41402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbhFUQUl (ORCPT ); Mon, 21 Jun 2021 12:20:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2ACD6128E; Mon, 21 Jun 2021 16:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624292307; bh=WtJHnF2V6zCmCHiykf8xJP7/ATTD1KMcOXK0zplLPa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GMTJi2LJrjExt7o7RyT2QfniulhdiReJJCtqMh69BNCyQqPrj2B+xXICk4VmAc6oP sLDruD01w7PjRo7+OlXrg1r5DXTzfnLtMWs9Mi4Aq6oHhO3YcQ8tUH7gcoF8FeDx9Z RXYzNhsZkyJUoxl8NCBXoZWpV86Dd2S1BNzdwR5Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Somnath Kotur , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 35/90] be2net: Fix an error handling path in be_probe() Date: Mon, 21 Jun 2021 18:15:10 +0200 Message-Id: <20210621154905.310036169@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210621154904.159672728@linuxfoundation.org> References: <20210621154904.159672728@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit c19c8c0e666f9259e2fc4d2fa4b9ff8e3b40ee5d ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: d6b6d9877878 ("be2net: use PCIe AER capability") Signed-off-by: Christophe JAILLET Acked-by: Somnath Kotur Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/emulex/benet/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 39eb7d525043..9aebb121365f 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -6030,6 +6030,7 @@ drv_cleanup: unmap_bars: be_unmap_pci_bars(adapter); free_netdev: + pci_disable_pcie_error_reporting(pdev); free_netdev(netdev); rel_reg: pci_release_regions(pdev); -- 2.30.2