Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424382AbWKJIqR (ORCPT ); Fri, 10 Nov 2006 03:46:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1424383AbWKJIqR (ORCPT ); Fri, 10 Nov 2006 03:46:17 -0500 Received: from ozlabs.org ([203.10.76.45]:45742 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1424382AbWKJIqR (ORCPT ); Fri, 10 Nov 2006 03:46:17 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17748.15442.906060.210242@cargo.ozlabs.ibm.com> Date: Fri, 10 Nov 2006 19:46:10 +1100 From: Paul Mackerras To: Christoph Raisch Cc: "Roland Dreier" , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, openib-general@openib.org, openib-general-bounces@openib.org Subject: Re: [openib-general] [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode In-Reply-To: References: X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 24 Christoph Raisch writes: > The patch is needed. We've seen it on the real system. We did fix it on the > real system. I disagree that the ioremap change is needed. > ...and it conforms to theory... although theory is a bit confusing here. > > let me try to summarize: > ioremap checks for 64k boundary (actually page boundary) Actually, ioremap itself already does the calculations that your patch adds - that is, it generates the offset within the page and the physical address of the start of the page, does the mapping using the latter, then adds on the offset to the virtual address of the page and returns that. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/