Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3924253pxj; Mon, 21 Jun 2021 09:28:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYUMHxqAR5HQsyHdMtwI7sg75CnfnwSKVT5Vx6NMle8FfptNjZxQEaU9Rit/9ivCfIxGjh X-Received: by 2002:a5e:890d:: with SMTP id k13mr15768492ioj.71.1624292937701; Mon, 21 Jun 2021 09:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624292937; cv=none; d=google.com; s=arc-20160816; b=yNYnCS7fxh1J4d4tT82uk1HAq3T7eu8+KOKsWHlfYveUHPHszoV+fplgrX0W5lqwel PKMDbFahthV4Zxc5KPLmqb55bHfS9PtgW2OTVS7TNV+vc9YvMyUQqrL2bzi+zYJ7rjZM vzGWXVH/VzdS7hlqcBw2rWpS/lvbDFjrEAkyrwVJRopzn+218WMaTV+r0YLMuHtuHajd qJl9d0SEHYVa43HWcE0to00RcnGsYnVI+X8aiHqGx8h2MCeTlsbcKndT9cKjU8bFwURM BXmIiNpXxDAErDrCA3mx/yKsAgfmTDPKHAjwyBYbkg2AMDP6s9PjCE+4Tir7d4NTS/C8 RPHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y2VdIArr62eoOrNd4abLLbvWXMwMilymzJrWO+Vf7pI=; b=uJh2lm8uY6CR31eTkFPbS3S4Ade5v0JBpViyNsWwIn/dnlZS/pFSdZb3yiiCD26/+L /7/L9CfKOoNxp02kIozuFM4WDEZtsl4BVNY7Y0GuP3prdfohUf9MDsW8VzPpcXsR0Ua7 /O7YXsooyJec2+nqQq7MNCfJ+subX3kbgoE8wSc5uGpSEk3L6V/mJvojhzqQzQf6m0Ir F9KP8xeze2lzZSiHZBVUAmHxqSbCAP/pDGfvfpc3sXTSyvtl4pvTPkvnOas/xfsRfJFu LJWj1SFG/4ZWWgoVa8+N8aZpjhcKtg6tlnhjx9RHHQJje50cxAWz0p1XbT/C6gNa8e4L nr4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ArIDKyeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si2995245ilh.7.2021.06.21.09.28.43; Mon, 21 Jun 2021 09:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ArIDKyeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232206AbhFUQaZ (ORCPT + 99 others); Mon, 21 Jun 2021 12:30:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231834AbhFUQ21 (ORCPT ); Mon, 21 Jun 2021 12:28:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8B1466124B; Mon, 21 Jun 2021 16:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624292617; bh=HiWDZk8JWbXgEJ50GfjOPgTixTNa0s8CQla2GOA85es=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ArIDKyeUGpUyCtOe10YHVyERe6cEZfSbzuPGYfop0WY5aeYAUvGmv0ZV5TpxZ/5B9 YlZsCRQXvZPdfk62NQ5JJcvJyhVJzqrBmo5Ix1pvX23bti/1aA8VFUwSW/oJhbmM57 ucGA7uoh+vrpFRkIzXfUnAtXQNPrQ9mdj1PHilFk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Skripkin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 066/146] net: hamradio: fix memory leak in mkiss_close Date: Mon, 21 Jun 2021 18:14:56 +0200 Message-Id: <20210621154914.942883804@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210621154911.244649123@linuxfoundation.org> References: <20210621154911.244649123@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin [ Upstream commit 7edcc682301492380fbdd604b4516af5ae667a13 ] My local syzbot instance hit memory leak in mkiss_open()[1]. The problem was in missing free_netdev() in mkiss_close(). In mkiss_open() netdevice is allocated and then registered, but in mkiss_close() netdevice was only unregistered, but not freed. Fail log: BUG: memory leak unreferenced object 0xffff8880281ba000 (size 4096): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 61 78 30 00 00 00 00 00 00 00 00 00 00 00 00 00 ax0............. 00 27 fa 2a 80 88 ff ff 00 00 00 00 00 00 00 00 .'.*............ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x98/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff8880141a9a00 (size 96): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): e8 a2 1b 28 80 88 ff ff e8 a2 1b 28 80 88 ff ff ...(.......(.... 98 92 9c aa b0 40 02 00 00 00 00 00 00 00 00 00 .....@.......... backtrace: [] __hw_addr_create_ex+0x5b/0x310 [] __hw_addr_add_ex+0x1f8/0x2b0 [] dev_addr_init+0x10b/0x1f0 [] alloc_netdev_mqs+0x13b/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff8880219bfc00 (size 512): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 00 a0 1b 28 80 88 ff ff 80 8f b1 8d ff ff ff ff ...(............ 80 8f b1 8d ff ff ff ff 00 00 00 00 00 00 00 00 ................ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x777/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff888029b2b200 (size 256): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x912/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae Fixes: 815f62bf7427 ("[PATCH] SMP rewrite of mkiss") Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hamradio/mkiss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 17be2bb2985c..920e9f888cc3 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -799,6 +799,7 @@ static void mkiss_close(struct tty_struct *tty) ax->tty = NULL; unregister_netdev(ax->dev); + free_netdev(ax->dev); } /* Perform I/O control on an active ax25 channel. */ -- 2.30.2