Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3926302pxj; Mon, 21 Jun 2021 09:31:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbA/kBa7qAyItBhGeJCi9vPyzU7Df21oNQ0KPFoaDpDmRc44P811eKRz+atSQWp4KZ69AO X-Received: by 2002:a05:6e02:784:: with SMTP id q4mr18533242ils.82.1624293088014; Mon, 21 Jun 2021 09:31:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624293088; cv=none; d=google.com; s=arc-20160816; b=RDrerKn1tKNSy92C8gelTkdvDsnx2Sjuv4R2JSsZgpY+k59MOQyEXMhVow/gw9KzVJ WAVZ4+x2TdNF6uLlYgwvqQkIGUHhEGlPsVglJs5A3VZpLjnRNJJbn14xm6kFQ7n/2wwu 5Fjfh3Z2YXk2RYoMS2dJQORrAR0HARzUqNdtyPixw8+JOMNbpDtO8DbSP3yoTciTatpL JjjRdzfj9+v+V/H6VNx0w74euc2bY9Aa01hcW1neRNrchPtPQrZKy33Mvmj68NudqIG6 77nLpTC1KBTkTt22qGiwZqp3eJ2NspQMro1XaiyWMTSOC6c4e7zk1szox087nwsOK2qI OX+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W+YcAgXpMbUGSw5oT0xYdLFmh4Tu/zjc9M4nM074Mh0=; b=TN9V1p7JfXdKSFMOVF5N4WsgNSLEkYNjXeHO6kCVTE+ZkvV4SDC8he9Ita92RA5N+Z 3uUxC9rlqdO18z0rM09bL8FX7ldxvws40PEIRmbmx0NXjSTzgyI4R4P0IdIfS1PEGLtj ukgPNPlnUh5Umm0itJfakjObO6qC1WI3llYmjIsBk9g3Beh1GeHH0Dh8TLGcif/6Crti TsFIAUiFYv4YyEWoNsMowhjZ4kCefrQ8RxkxO7f8vFY41LgqMAlF712x5tIQhdNg7ngY seEJevOqDRdM/yCK4LetB5Q41ApZxNDBBRaeyZncxsy5Gt+WpKFPpDZEA36RfzP5fV8O h2zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fCNAj60x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si15224266ilm.45.2021.06.21.09.30.52; Mon, 21 Jun 2021 09:31:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fCNAj60x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232134AbhFUQbv (ORCPT + 99 others); Mon, 21 Jun 2021 12:31:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:49176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbhFUQ3d (ORCPT ); Mon, 21 Jun 2021 12:29:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E4CBA613F8; Mon, 21 Jun 2021 16:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624292658; bh=HgAeyTIKN6/HSdq0bHXaUPfbBBKqat1+BFLZu8Q0FPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fCNAj60xt8ric2hZkP2Xv2LtyWz06uQ00e86Geo9oKxHWeMJsS0axnAroSkTibe5g sZ5nEm+Ljk8Iuq6veDowq5z2gL8tzk5o4nJVNyQeIWHbPzSrwlEO2NpQr33l/9+hVg gqLxx/XjqdlMU/sOaQGLiDzTFxoi2NDbkzZnAswo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 049/146] qlcnic: Fix an error handling path in qlcnic_probe() Date: Mon, 21 Jun 2021 18:14:39 +0200 Message-Id: <20210621154912.974483181@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210621154911.244649123@linuxfoundation.org> References: <20210621154911.244649123@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit cb3376604a676e0302258b01893911bdd7aa5278 ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 451724c821c1 ("qlcnic: aer support") Signed-off-by: Christophe JAILLET Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index c2faf96fcade..27c07b2412f4 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -2692,6 +2692,7 @@ err_out_free_hw_res: kfree(ahw); err_out_free_res: + pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: -- 2.30.2