Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3936278pxj; Mon, 21 Jun 2021 09:44:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBI4Ai2iQSXdoamoX7hYwXNB0zB9ySY9OQ+ENlxkA6U7SOb98EHBmfEQkTV9IGwoW1oPuZ X-Received: by 2002:a05:6402:350a:: with SMTP id b10mr23380240edd.238.1624293851353; Mon, 21 Jun 2021 09:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624293851; cv=none; d=google.com; s=arc-20160816; b=P022vMj09+287Ok0bKirBX3oT/7GMTZ4KJ3UhjuohZZto69uxfV50Kq9tiZy0yU2/F PjSmdsZQ9zHlVKQa81ejNQ/SdRozRR2P96tVLDiX8uI+FIBk+AuX4aJOkoekuPk0bas5 /9duWi6BJYceMj7gP++JYou5vXUKWkQquHQUfPFJ+1JyvH3yhfdnUP51GX4PjLM51zYc DkOAz7v8SzV5kKcaxFmP/hjQ1R4SHuA15LvosPlYWd8F8yRHpOq0K331cU7qhk7nwKUr NMrjyXtoXicNp9V2YWJ+mp0yM3P7kF7SR1xj3Qrd7LMpI5th4at/M4csF+rNpOlUst64 EXsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dOiaR8Z0DKeqWLuj7SvX1kn5r/auDDe9CN9zZBTUxCM=; b=VPsDpebhv84kmtix1OjflddBSM318TGOgxlsKevcGC0A1WQ6m+ReyDrmfJybG/I4/P UDEn0rfdIe2j2JrGaEA6hEKUUjq5kX1+GFbV2rpyR8UomfZJadVbifuVEpywyOYrfr+G c/f9xH2Fd0o8HFt7tbemkmIlKPqxrehWtnCYiaEQICffBLddQBi3Vwebnzz94UMcI6Lh PGC9J5Ce5T20xhwVCNEwImiTM6FUcA8diJw5mdUDHy3R+Rlz/1aMvjAYp8r3bRa1KpER 0ieA/IB6q1asor+bHgnL4ZLUIHSJ7r71ebtk4BpZdtUagn8cW6u2gFKpMgqpU0ig/boO ivkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="BSH/Etrd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 14si11084239eji.468.2021.06.21.09.43.48; Mon, 21 Jun 2021 09:44:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="BSH/Etrd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232755AbhFUQnX (ORCPT + 99 others); Mon, 21 Jun 2021 12:43:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:33938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbhFUQjq (ORCPT ); Mon, 21 Jun 2021 12:39:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D9F5A613AD; Mon, 21 Jun 2021 16:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624293008; bh=DB1QRlgxAo7pE+yNMcQCaPDnt6QGC68QpekruMInYM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BSH/EtrdyWg/TQNpAcqbL7ZT7NOPwGCsSOMrH7bvziT2WNdAc5JsoXAa/xNNEP3fl oHNKKs/c4qGpaDao0Ji6qkAgvTpoK1ceEVVDLiaAseVuD7F57R1c4gMdmpVGHackkU PfceiWSd5tqxkxurmjsZoBfZV48GlWdUTcc6TLXU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "David S. Miller" , Sasha Levin Subject: [PATCH 5.12 057/178] qlcnic: Fix an error handling path in qlcnic_probe() Date: Mon, 21 Jun 2021 18:14:31 +0200 Message-Id: <20210621154924.379810082@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210621154921.212599475@linuxfoundation.org> References: <20210621154921.212599475@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit cb3376604a676e0302258b01893911bdd7aa5278 ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 451724c821c1 ("qlcnic: aer support") Signed-off-by: Christophe JAILLET Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 96b947fde646..3beafc60747e 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -2690,6 +2690,7 @@ err_out_free_hw_res: kfree(ahw); err_out_free_res: + pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: -- 2.30.2