Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3952079pxj; Mon, 21 Jun 2021 10:05:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+j8MXq26iIK15h3z2BAvAPVtSA5dghSPXiNsHD+0m51Br/WcVF9+gtIqwQWvQSSWKzavV X-Received: by 2002:a17:906:9d12:: with SMTP id fn18mr25717562ejc.3.1624295122608; Mon, 21 Jun 2021 10:05:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624295122; cv=none; d=google.com; s=arc-20160816; b=e28Z4uRkq8uIPrZzLVmPPodp1TD81TC1Ub7n+xlfJ6Amgbor5bV48tFaVsH2I0ZisH YdKjCzbjIbwYEyyGyzZIoKlE7MkEXik9kSCF0U8ShLEbQbkgpYZ5zW2XcQqHzFpeCSYc eTUH6VVb3AhQxvHuttguHMV33r/lPav3AXVE/urmJI1C/zhPHoMHDcmGqWoDnnRk0sxx S9/l8+g9mHa8IU8/R7zsXptZ73dU2DbLq2CxvsBXxQnZJK9kENiRj9OS/ObEqEh++3/e 5QWmKSOJV7hcQJ4VdT0wGUrw6SKm7hOdVIm92Dq5B5kDLC5FMsoenzVH7ETUWu1mLvXn 2htg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=h1idqoQuvymBsBQAvv2q4seH7J1czRDhztw/KvBhqig=; b=Vywhqi99kayWOvmIiVbEv7WxdeCWk6BQDJ4IBxh3+07by2+9DPWlqsje8nbTKe/SNy ovjOzKKNUJXwiSWJRqugxkhBgEf1OBE1oMbhIJj2D6GHmDojKPKMN6TE6+Lsf1sEikw+ dDmTCEqOeOTdSxkTgtYa/Pu6HABYvoZwD7RN5CntOrb9xi9nElWsRMdopdv+Y7ll89QF 7jflrP3gHJc0PaTbCgr3aAxY2H6JrNhDjLZO0Dzbl2mnNhamovByYSSm0Z+VwfS2Ihtd E/3dYj7CZ1lYb5BZo/oqwutrTkzRogZTW8zHJZziU1zvGYskHU/ANUquT7bls4/ncVkg B+vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@uged.al header.s=google header.b=hfhbQW9o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si9467798eds.419.2021.06.21.10.04.59; Mon, 21 Jun 2021 10:05:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@uged.al header.s=google header.b=hfhbQW9o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbhFURGW (ORCPT + 99 others); Mon, 21 Jun 2021 13:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230452AbhFURGR (ORCPT ); Mon, 21 Jun 2021 13:06:17 -0400 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CE9C08ED6D for ; Mon, 21 Jun 2021 09:45:55 -0700 (PDT) Received: by mail-qt1-x82b.google.com with SMTP id x21so4729300qtq.9 for ; Mon, 21 Jun 2021 09:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uged.al; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h1idqoQuvymBsBQAvv2q4seH7J1czRDhztw/KvBhqig=; b=hfhbQW9odLh/zR2d8D9OJm5iCfviL/O71DddJSwyHN/G/uo2GDxuQ/WxmL1vZGWsAq 1eW2B4e+R4yz89hU1c943ySI2tA5hkP3CWZ8Vn5GIgJd2MrGjnIyKCE0JGprpu9xzJEI /Qdt9eEia57hC7zqtA/W4jTETaf4NWPZi4QnFe+XJlH/q69j4P+8amSg+DkZ7NI02B2G 2GhFa/+jrji66IZcOdThxHZIjiHuJcN0q2KxFx4PuXqa/Ie9VVaiQlAm+McpcVFpOAPl zEWgltEPaCWjWuLFd0DJGRMwquvO70oNxLDTa38wr394ttQ25Uw+LEm3fovb40wbveru DVmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h1idqoQuvymBsBQAvv2q4seH7J1czRDhztw/KvBhqig=; b=Wr7mEhxdOO08HKx6t86/kwt3r2JDaCmVyGG3RPzdyJCWZX33vjuATufEJTHHU71cfi 46t9qoYz5TBvBKgQO4d1p9EV2a3qn4Zt1Lw9ivVQfkqRNuQzTYK1YlTET9EXyq+IB815 r8byh9DFS0yZIGS9XybrA/7ccd45sZM1hDw75+LO5vRNmfeEmvI0HCvI1wnViyUegLHd sQWIC122cmuiUK74svxywUALbh8aiPMpmgxI6DhRQORblREexuwNzvTTx57zxHzZt01Y pLSXSD160qdv5IEVz98p9+/EwyvGRyH8yfXYeKNEaBuGonHiXJQhe42v8BSk+20l7HnP u6KA== X-Gm-Message-State: AOAM530eNQLl3rc80VvlVDVCjdwzKDzt6Lsjf4T9nSTqdPov4Hzw3JRI rGaAgVblPU1nEfVpC2g3FrBf9ETg79hIV0cUYv76nw== X-Received: by 2002:ac8:7412:: with SMTP id p18mr292907qtq.49.1624293954415; Mon, 21 Jun 2021 09:45:54 -0700 (PDT) MIME-Version: 1.0 References: <9D4A658A-5F77-4C33-904A-126E6052B205@linux.vnet.ibm.com> <6D1F875D-58E9-4A55-B0C3-21D5F31EDB76@linux.vnet.ibm.com> <20210621162243.GA29874@vingu-book> In-Reply-To: <20210621162243.GA29874@vingu-book> From: Odin Ugedal Date: Mon, 21 Jun 2021 18:45:15 +0200 Message-ID: Subject: Re: [powerpc][5.13.0-rc7] Kernel warning (kernel/sched/fair.c:401) while running LTP tests To: Vincent Guittot Cc: Odin Ugedal , Sachin Sant , open list , linuxppc-dev@lists.ozlabs.org, Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org man. 21. jun. 2021 kl. 18:22 skrev Vincent Guittot : > I would prefer that we use the reason of adding the cfs in the list instead. > > Something like the below should also fixed the problem. It is based on a > proposal I made to Rik sometimes ago when he tried to flatten the rq: > https://lore.kernel.org/lkml/20190906191237.27006-6-riel@surriel.com/ > > This will ensure that a cfs is added in the list whenever one of its child > is still in the list. Oh, yeah, that is a much more elegant solution! It fixes the issue as well! Feel free to add this when/if you submit it as a patch: Acked-by: Odin Ugedal Odin