Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbWKJJxr (ORCPT ); Fri, 10 Nov 2006 04:53:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932826AbWKJJxq (ORCPT ); Fri, 10 Nov 2006 04:53:46 -0500 Received: from ozlabs.org ([203.10.76.45]:49597 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S932822AbWKJJxq (ORCPT ); Fri, 10 Nov 2006 04:53:46 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17748.19234.278295.476881@cargo.ozlabs.ibm.com> Date: Fri, 10 Nov 2006 20:49:22 +1100 From: Paul Mackerras To: Benjamin Herrenschmidt Cc: Andy Whitcroft , Andrew Morton , Nicolas DET , Steve Fox , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure In-Reply-To: <1163112227.4982.44.camel@localhost.localdomain> References: <20061108015452.a2bb40d2.akpm@osdl.org> <4553436D.30601@shadowen.org> <1163112227.4982.44.camel@localhost.localdomain> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 25 Benjamin Herrenschmidt writes: > > Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by > > default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which > > occured by default on my config then we end up with two module_init() > > calls, which is illegal. > > > > powerpc-add-of_platform-support-for-ohci-bigendian-hc > > > > I am guessing that we are only meant to be able to have one of these > > defined at a time? I changed the default to n for this and I could at > > least compile the kernel, but I am sure thats not the right fix. > > Paul, which patch did you merge ? I rejected the initial one that was > doing 2 drivers/probe routines and Nicolas did a new one.. You may have > taken the wrong one. I didn't merge either of them. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/