Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4027993pxj; Mon, 21 Jun 2021 11:47:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRUup5crGPjkMqojoHiFmx6xm75zYTQWsKXoumECr+Cy0mf/nXVzk9jDJQz6gcWyy0Wp1K X-Received: by 2002:a17:906:1318:: with SMTP id w24mr4347365ejb.222.1624301273921; Mon, 21 Jun 2021 11:47:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624301273; cv=none; d=google.com; s=arc-20160816; b=XmbpLv/fJsvPicHACCuBqi/ebeiJFoQIGn28BwPAwwQIkFJRJuxHMLQYlRWxaqRuFg Plws5RH3KFr0trQkMk0uSvM/fTdK3yMA9ueRPEs5JxT6nWrgNXq65dE55hqFk+q5iA7D s5x5zDhFW5qYkt7pEUssy13kW7qF0h4Hsu0F97BUzS/GZ5eIJJNkMezWg11/W1pEgeix MYLn+6dqDBosw3Sbk19VRq76xafwc99e6Di93cZp021gqqhqP+h2g6L3fy6/4f7Ez0HO jpfIRm72nIO1VtQVEkFDFobFzFOOji230s+dDprmX2Yu19mk9J19jq018caSSTE8SYb4 4pJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yRk/TJKzDD1x4mBkXbsX8dYgyRs0RbQ9q9tyvj4gD6U=; b=I2HeY/HNEd3aZvOVoNGLJReHzIp4w8Pr7AVrlcGWweBa1D7MKaUdDQgG5WdTITvdEP wRIaKW6jPi/8M6XSf9WUbsNl/o17dZkQWPpy16PDrcqH1OMBUKQ70eH9/mlPXzSd9Yjd OlhJ8zYc6K6tDcvkqjla8wTh3CmzxXPn94JsJJaxSDwSi5QXbQtd8OrsmkEWC4TcpZ6l eDowFIDVqx9siu7QrXuF+B7Of4ne3VVELKAR9Ta8HqX5zXx2EC8eSwGGevlFsTLbunRd hw0BGm04L0mubn/PvicdnuvIkyLkydhB2ZLahun+T1btFKRWY0fvWY9TvGr3/ITZjwFX Ls3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QjJHQU6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si13596268edn.529.2021.06.21.11.47.31; Mon, 21 Jun 2021 11:47:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QjJHQU6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhFUSsp (ORCPT + 99 others); Mon, 21 Jun 2021 14:48:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:39836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbhFUSsp (ORCPT ); Mon, 21 Jun 2021 14:48:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E44BE61107; Mon, 21 Jun 2021 18:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624301190; bh=Z71y+SBq3KMuZ39iEoJG5bILoscerM41HzpRFtX8OTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QjJHQU6j1u/LdayzRIMOu0sHi0PjFxq5KH6jRz9DeipD/Le/idkeNXGQqShj3tyMG Dn7Wg5PDZnkCg9ICE2qMFarhaO4PW1gm12tyVDJAW1eKNeziEM0uYeYptJDXgvhTuu pg9gRmaLjwxcBZ1zwLBx0YjFliO4cyZFNUoLdjum4rDUGvJBPrJSqElZr8X8YP+C3B EYOh1KyDj/0vpzmyG5s1Z1qplleNOPKPvt6lR2P8JmcoR8TApEpJAaXNhOdrqpw4/Z /JYZzdVSWzhaJ4ZFxls3vv48inrmTl6iAOJGZ+xuX8FvtbGec5ibnRIqJcDzSkYmr+ yo19XlLZJicBA== From: Mark Brown To: Axel Lin Cc: Mark Brown , Liam Girdwood , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: hi6421v600: Fix setting idle mode Date: Mon, 21 Jun 2021 19:45:49 +0100 Message-Id: <162430087047.9551.3163979267051992655.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210619123423.4091429-1-axel.lin@ingics.com> References: <20210619123423.4091429-1-axel.lin@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Jun 2021 20:34:23 +0800, Axel Lin wrote: > commit db27f8294cd7 changed eco_mode << (ffs(sreg->eco_mode_mask) - 1) > to sreg->eco_mode_mask << (ffs(sreg->eco_mode_mask) - 1) which is wrong. > Fix it by simply set val = sreg->eco_mode_mask. > > In additional, sreg->eco_mode_mask can be 0 (LDO3, LDO33, LDO34). > Return -EINVAL if idle mode is not supported when sreg->eco_mode_mask is 0. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: hi6421v600: Fix setting idle mode commit: 57c045bc727001c43b6a65adb0418aa7b3e6dbd0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark