Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4081512pxj; Mon, 21 Jun 2021 13:07:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBDjdtn9tlWA7/yI/HOmUclTKlGyOOhzUG6ReuZl1jY0kzWtJ813TYPKIMhlM+HZlF9Orp X-Received: by 2002:a17:906:254d:: with SMTP id j13mr23162962ejb.27.1624306025625; Mon, 21 Jun 2021 13:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624306025; cv=none; d=google.com; s=arc-20160816; b=LUPLFxkHSwtYQjJ6SCC1QPpVJEThT8eAA0U54fZWvM/4u0r3uia90u/SronXfEGIhM X46PIZTQzEi2P+TF/avN7TPqQ/brnCnu1Z8Ngci1mdsMJo8f0IGe03XUy6dOB9l3xZo7 oo3Appb41GiqJURESZIQsNDEx0JnKiad/MreJqTEUAgdvUGneLddqfgchTvEOYp5hq98 uIwQtkPLHYtymcjCmKg61QzfP/PMb5Sz+4sPkn2kTr5MvNbuZoSndyDl174uJUQRDW1X FAWgP6jczaIjwE41im+ZGxWSr1x1FOHzoKWEdpnK068ylsNlC15tYP7Pn6V+YYgEfxfY Qx1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=WAHZ8Vz2CwykfGGX5mNg7moax8bM1FVKxI9y5zaUxRo=; b=c/9GC7WWp+tNbwqIA+5CynHh/3GQ4uNCKLHrQRrkXBIuMV5OAL8rwI9SNZMVvDVfne w6+9GbDBSa71KxnYOFeLCdeXk0Z/LPIOhGncWwHR8k0gYuOujXWx6716ew95Eer+HnBu DAvuHSTAncX9RqzaKjOJIBChv1Y4YeVpaQ1elPFX+aM9vkuc02x8vi/x4/PUdFLNPBAJ cZrV0bg1tychlLpf83wareUDpv2IkOaX4OnKO73f11wCY5OHwa4k0yTAIbYZv2jjE2xo U9IZW5f4+5YdWQ0mb/LrjwDKu8Ps+9g+HMcLpJGawGpqo37I9y23F7Id8PZ4jTe8fg7e 4k1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=fSYB3k2z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yd29si11449699ejb.330.2021.06.21.13.06.42; Mon, 21 Jun 2021 13:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=fSYB3k2z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbhFUUHl (ORCPT + 99 others); Mon, 21 Jun 2021 16:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhFUUHl (ORCPT ); Mon, 21 Jun 2021 16:07:41 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82C1AC061756 for ; Mon, 21 Jun 2021 13:05:26 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id q9so2761153ilj.3 for ; Mon, 21 Jun 2021 13:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WAHZ8Vz2CwykfGGX5mNg7moax8bM1FVKxI9y5zaUxRo=; b=fSYB3k2zxiTixDG0FzieNm8sxSEpgbEwcSqrWdWmeo4e2ZYkP3R12nr4DUd+rYyGLY mr7xDQX5qqemxxLys3J1GD5+k5nLoz9pxQiBT/9IW6BlQ/FGhlbmEzCmK4lAUFr6Haew DWwNr0CgbiBqKVmhqCWxxQe6COqP7+ChDh45GLVmZZeRo0RunBqR9HusT7JgMLj6prJy C55RXku4p35elny+VDSZUelcmNB/roqzqA3LWKP73TnhT2NzQEIL/Vv/0GYslqF8zB6x 9NzMifprzG7RIfsbwDrNUrpusE1GnyfQ8Cm5gWJ+yKPOC2LEU06ufqYChfkupTbM7/CE hyOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WAHZ8Vz2CwykfGGX5mNg7moax8bM1FVKxI9y5zaUxRo=; b=U3X8BK/CK66o0Aqv3D00YKAMwkwLeyibWesk3h08/Euu0/IGQtCAQklrsM+BzfEkxK eQBMfrvykVWDTbr8v2wCq5LomdpXxea/I+vFW8LGe8+wVzRA4zH57esAvFhTH49xcsPF piihxw98M5Jnjt5YvJa/SZ7zRliLvJKLDtR0BM8iJZlq8KLz7OaYW5rwZ3nzIZwSTLx4 UQ0NlGPPMTpj0o5BYG2HZnNEhFS1GoXDTHaBph4b9GM4Hj47OqAOzm8LH5kefOn4ntnQ Bp1nk0M10wWZmZjZzB7TEdJu40Zd4IABB7srVEZkx/khSwFGyPHEMQapsfxLVVRjzQQb QpSQ== X-Gm-Message-State: AOAM5328SL0Clr8REs21PlQx7jOBGR04j89d90b+yS7unizxRK+kvB84 M34YVXrS5DBahebvsmZqQZHxjBL1EdRnmA== X-Received: by 2002:a92:cda2:: with SMTP id g2mr1181691ild.3.1624305925736; Mon, 21 Jun 2021 13:05:25 -0700 (PDT) Received: from [192.168.1.134] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id m13sm6854247ila.80.2021.06.21.13.05.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 13:05:25 -0700 (PDT) Subject: Re: [PATCH v3] io_uring: reduce latency by reissueing the operation To: Olivier Langlois , Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <4deda7761d61c189f4e2581828f852c8a1acb723.1624303174.git.olivier@trillion01.com> From: Jens Axboe Message-ID: <82b94c49-b18d-94b2-cb8d-43cf54e402f3@kernel.dk> Date: Mon, 21 Jun 2021 14:05:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4deda7761d61c189f4e2581828f852c8a1acb723.1624303174.git.olivier@trillion01.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/21/21 1:22 PM, Olivier Langlois wrote: > It is quite frequent that when an operation fails and returns EAGAIN, > the data becomes available between that failure and the call to > vfs_poll() done by io_arm_poll_handler(). > > Detecting the situation and reissuing the operation is much faster > than going ahead and push the operation to the io-wq. This now looks pretty good to me. I know you had some data associated with this, would be great to include it in the commit message. -- Jens Axboe