Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WuhYj42CvR6r6tHcKr6HRF3sFsSALUoS8f8nrZnRxquolAQVHVhX7Uvf/ukjw63NzwhkDVYWE6
 1ojXFWVfL+8A==
IronPort-SDR: gv+kbT/6xrIRu6Aj0NTA+IYfXiwZkvL1IxfnNUMdZmsBNVlBju5yeQfdOUZXXkWL+5eaZp8tYs
 KnFhUKR1xQjg==
Subject: Re: [PATCH] selftests/sgx: remove checks for file execute permissions
To:     Dave Hansen <dave.hansen@linux.intel.com>, linux-mm@kvack.org
Cc:     linux-kernel@vger.kernel.org, tim.gardner@canonical.com,
        jarkko@kernel.org, shuah@kernel.org, linux-sgx@vger.kernel.org,
        linux-kselftest@vger.kernel.org
References: <20210621190556.4B5DCBB1@viggo.jf.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <121f7215-f11d-2533-b736-9f18516c3220@intel.com>
Date:   Mon, 21 Jun 2021 14:08:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210621190556.4B5DCBB1@viggo.jf.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Dave,

On 6/21/2021 12:05 PM, Dave Hansen wrote:
> 
> The SGX selftests can fail for a bunch of non-obvious reasons
> like 'noexec' permissions on /dev (which is the default *EVERYWHERE*
> it seems).
> 
> A new test mistakenly also looked for +x permission on the
> /dev/sgx_enclave.  File execute permissions really only apply to
> the ability of execve() to work on a file, *NOT* on the ability
> for an application to map the file with PROT_EXEC.  SGX needs to
> mmap(PROT_EXEC), but doesn't need to execve() the device file.
> 
> Remove the check.
> 
> Fixes: 4284f7acb78b ("selftests/sgx: Improve error detection and messages")
> Reported-by: Tim Gardner <tim.gardner@canonical.com>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-sgx@vger.kernel.org
> Cc: linux-kselftest@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 

Thank you very much for fixing this. With this applied the SGX tests are 
able to run again on my system.

Tested-by: Reinette Chatre <reinette.chatre@intel.com>

I think it is missing a "Signed-off-by".

Reinette