Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4219970pxj; Mon, 21 Jun 2021 16:54:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeXh5PHMQgSQu1A05SMODOAnCkRa6w2vG1W1KrCQN+2DGJKucv5A6gyEOJj3XLIv3YsUrN X-Received: by 2002:a02:9f8a:: with SMTP id a10mr997335jam.136.1624319685998; Mon, 21 Jun 2021 16:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624319685; cv=none; d=google.com; s=arc-20160816; b=st3jYXnMCaLRMBvphHl7loQz9JJuba+e2KLidc2jYcCHWys4nrvCaAvqKY/3SqP+jU T7dOL+xkhLHhEOvK3FHVn7RC5whxuhosltnWj2dylTJjZzlpJ8/G4jFk06z1g5FfcEYj cfAG31g+gxVIO5D7PkxZr6ehZe3/3Jw+zT51dksxEOzokhKDd04jt8jO7cMVVDBtu22w Xc/J/K40mvntAXuBZyl4o1sqm1muQBMKNjrKAgvHliUJ8dKru8UD1Wb0dV1zqZazU5U6 TOl56OQSbRj17vXbY624WU/mSNBF214l9xQxwruYJn5zhHXIAIQSuSw3E7ZG2/N+Y7Aj wnqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=THKoO1RWudj0KxP+z9XOrOgTVnvtbYYdvVkwmldz9OE=; b=bIqSvIJNE7xDltB5oZvn1E3dNBTBo0Qn0/8lteuAlY/MWwR+euMGhvD/cQzvxCygnS 7yooi21q4t7z7zL2aO7t3oZFPYIn7NmKx16Y6Iwl9E/AGQNZoFjuaYsLraMYAQT852rG aSb9/eewf7ePByLq3vyUxQhu4mDuEIZkfh2Cjq9x+lNawONqRHsspc3Tg5Mj51JzdkOg A3IbUPGVjX5UBxlbHG3X8NDnKw5BR3nQQir/ukFlLBKOCr8vGu7skW/0G2hEjZJEAtN2 EDlFE0BmbQamAx18Uzg5pJInFG3M9HxSnzBqZ+uXWfY1dZtl2plDP6BuMx4/Z1WR+aNH aMYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DSphfoFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si11923032jao.68.2021.06.21.16.54.34; Mon, 21 Jun 2021 16:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DSphfoFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232418AbhFUXzq (ORCPT + 99 others); Mon, 21 Jun 2021 19:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232392AbhFUXze (ORCPT ); Mon, 21 Jun 2021 19:55:34 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996FFC061760 for ; Mon, 21 Jun 2021 16:53:19 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id y4so7928012pfi.9 for ; Mon, 21 Jun 2021 16:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=THKoO1RWudj0KxP+z9XOrOgTVnvtbYYdvVkwmldz9OE=; b=DSphfoFZ7DM95K+RvdByDg8W0x0HzT372m/CTEnE3pqPeq323dI65P/rlVSfLPKJQ1 28O9oN0CLLEtsLKgQ6MlMRXyKqjvpu/VGmk9AAzNr4tU542Ko0Ca8Ro0ReN1BsCsYzhm FrHRvl46FXtYmbbghamYqJa+AdyJraOwaTHvI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=THKoO1RWudj0KxP+z9XOrOgTVnvtbYYdvVkwmldz9OE=; b=Dlem5RpQ7/m0GdylRPYkKisAnm/qVrCfCzG1mPJwDr+QmWWQskJh38A9Z+dVDRbEpr K/MmfoJdJhWPOr3Ozp4+InI/zvtrWDT9WsN/nZtZaQ6o5i4xbT+eCCXIKK0LDhlzh7ac e4As9jVutzKf7zuc6At5+zjZ1vOBMFh6rcc2PeXycZS+JvjpBjjkLH+AOnd5NuxoZ55P LvcDAlYsKJikWxGsNDMLSsbmOXoIcIMe7hmeksN2VhNEqEjxTzup1lsobqzJ7vOsNGS9 K2Rdk14uMWpx9yyB+3zjuHh2AnAKoQ6aWpgwyJkLabu6bcaqDh3Cwha8g8+FNMiIduAc iuuQ== X-Gm-Message-State: AOAM532bAWwW1ERbVarx7/Vyugz/dKG8RxdnBuVudX0ua1qc0sFYC15l Nlp8dvrvsmGQlPpReqo393vxgQ== X-Received: by 2002:a62:1d8c:0:b029:300:73d5:f35f with SMTP id d134-20020a621d8c0000b029030073d5f35fmr723439pfd.36.1624319599173; Mon, 21 Jun 2021 16:53:19 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:bdc1:a4b1:b06e:91d1]) by smtp.gmail.com with ESMTPSA id s27sm4339663pfg.169.2021.06.21.16.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 16:53:18 -0700 (PDT) From: Douglas Anderson To: gregkh@linuxfoundation.org, rafael@kernel.org, rafael.j.wysocki@intel.com, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, bjorn.andersson@linaro.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, bhelgaas@google.com Cc: robdclark@chromium.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, quic_c_gdjako@quicinc.com, iommu@lists.linux-foundation.org, sonnyrao@chromium.org, saiprakash.ranjan@codeaurora.org, linux-mmc@vger.kernel.org, vbadigan@codeaurora.org, rajatja@google.com, saravanak@google.com, joel@joelfernandes.org, Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 5/6] iommu: Stop reaching into PCIe devices to decide strict vs. non-strict Date: Mon, 21 Jun 2021 16:52:47 -0700 Message-Id: <20210621165230.5.I091ed869d3b324a483a355d873ce6bf1dc2da5ba@changeid> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog In-Reply-To: <20210621235248.2521620-1-dianders@chromium.org> References: <20210621235248.2521620-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We now have a way for PCIe devices to force iommu.strict through the "struct device" and that's now hooked up. Let's remove the special case for PCIe devices. NOTE: there are still other places in this file that make decisions based on the PCIe "untrusted" status. This patch only handles removing the one related to iommu.strict. Removing the other cases is left as an exercise to the reader. Signed-off-by: Douglas Anderson --- drivers/iommu/dma-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 7bcdd1205535..e50c06ce1a6b 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -368,7 +368,7 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base, init_iova_domain(iovad, 1UL << order, base_pfn); - if (!cookie->fq_domain && (!dev || !dev_is_untrusted(dev)) && + if (!cookie->fq_domain && domain->ops->flush_iotlb_all && !iommu_get_dma_strict(domain)) { if (init_iova_flush_queue(iovad, iommu_dma_flush_iotlb_all, iommu_dma_entry_dtor)) -- 2.32.0.288.g62a8d224e6-goog