Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] stmmac: pci: Add dwmac support for Loongson
To:     Andrew Lunn <andrew@lunn.ch>
References: <20210618025337.5705-1-zhangqing@loongson.cn>
 <YM//kGGAp3vz8OYb@lunn.ch>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Huacai Chen <chenhc@lemote.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>
From:   zhangqing <zhangqing@loongson.cn>
Message-ID: <d66e6af7-7384-41aa-76a7-7017f27d43cb@loongson.cn>
Date:   Tue, 22 Jun 2021 10:10:26 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <YM//kGGAp3vz8OYb@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 06/21/2021 10:55 AM, Andrew Lunn wrote:
>> +static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> +{
>> +	struct plat_stmmacenet_data *plat;
>> +	struct stmmac_resources res;
>> +	int ret, i, mdio;
>> +	struct device_node *np;
>> +
>> +	np = dev_of_node(&pdev->dev);
>> +
>> +	if (!np) {
>> +		pr_info("dwmac_loongson_pci: No OF node\n");
>> +		return -ENODEV;
>> +	}
>> +
>> +	if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
>> +		pr_info("dwmac_loongson_pci: Incompatible OF node\n");
>> +		return -ENODEV;
>> +	}
>> +
>> +	plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
>> +	if (!plat)
>> +		return -ENOMEM;
>> +
>> +	if (plat->mdio_node) {
>> +		dev_err(&pdev->dev, "Found MDIO subnode\n");
> It is an error is an MDIO node is found?

Hi，Andrew

Thanks for your advice,

Using dev_ DEG () is appropriate,

and other issues I will fix in v2.

Thanks,

-Qing

>
>> +		mdio = true;
>> +	}
>> +
> ...
>
>> +
>> +	plat->phy_interface = device_get_phy_mode(&pdev->dev);
>> +	if (plat->phy_interface < 0)
>> +		dev_err(&pdev->dev, "phy_mode not found\n");
>> +
>> +	plat->interface = PHY_INTERFACE_MODE_GMII;
> Seems odd you call device_get_phy_mode() but then have this hard coded
> PHY_INTERFACE_MODE_GMII?
>
> 	Andrew