Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4465068pxj; Tue, 22 Jun 2021 00:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqEPVcGgN9ySfWbhaD4IiETNtjpevrm3SWYWchg7rPmEWu5PkwRfh923LYg7aGIFjwcP2I X-Received: by 2002:a05:6402:518a:: with SMTP id q10mr3123003edd.198.1624346744755; Tue, 22 Jun 2021 00:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624346744; cv=none; d=google.com; s=arc-20160816; b=nRr3jf2gJNWQn45lj7MjTxB7zKgbECl4xWakexxNwSnP7VR9cc1m2LMVyB2URARQ4j RY2Jv1ac0OhrwgoZ96lT0WRQ5sTiUlxN1lRb+ATT91MloSkVrYMzqkMz42w8kt+yDXyR 2BGi9Efef4gRDVFtO6Ahw8qAx3q3Qnj5oVZ1Vf1afvrwVoV9KhUxjU+r/25mC7JvrbZT eSY2axNzUEQPVKTnQcl3Ovr4hXjdQnru/s5AFfgmiW+htvSRBa2BhLElVbrkFMy0/N0w 8toaimvNB8SRoVMFahyQXn5gESb0cO0NC7cBTXhIwQgz1/w+jQ8Wi2nTwSkZrvsRgpzh lIWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=gLom4lP2hibA/zirOs75HpOQiLkyphvf9WwSZgUj8y4=; b=LY0NuMVux3eZi5uBluHbM1vleNeuL6A85HzNeZ5UZHeJ34qa/qXSGdwozZfw3f+MHL lj7SezWRLY2/nGUqSMMxXbKFiNt+N03ZVGljeA8bR6Goj0OwPxRXwkKnGC4zqUvSGUy1 p6/oKBAZv7OXtgiylzgZZZErxO8q73B+2CQJAlQxlSlDEeXcPQvHyfgPrFFud9/685r2 bUbk3x565z8i/fBSd++RgJ7Uv0rV6zyZMULPSb4FrOt7prRRN+/dryS13hyO2dZ3LH6B bbqA2ySSx2pog/GHqqBVkc1xo9s2XGWeZiSP/ByQRpTydmeyOSzAn6zhhm3KA5LMeJWu D+2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=rZBYgIQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha1si12364974ejb.743.2021.06.22.00.25.22; Tue, 22 Jun 2021 00:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=rZBYgIQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbhFVHYi (ORCPT + 99 others); Tue, 22 Jun 2021 03:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbhFVHYg (ORCPT ); Tue, 22 Jun 2021 03:24:36 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DD83C06175F for ; Tue, 22 Jun 2021 00:22:19 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id nd37so32950455ejc.3 for ; Tue, 22 Jun 2021 00:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gLom4lP2hibA/zirOs75HpOQiLkyphvf9WwSZgUj8y4=; b=rZBYgIQ6eaQoJrR7/aULlx9tHfvP2U7yxchPCrKLCrDU8W2OjwYDQc4dlaDK7rwmEh t/MSfYdryYIRV6GqOkE5Pl+AlwNSIbD534x8uD5inNtL3X0rcDaJskmnwtJ0NM4rfQ/g kEeKUtbSW8CPlC37Wuu1JSc4VcQH3EUhO85OSN7cUEv8GpGpxC82WDFPRp01f9B0DgIJ m3Q621+iidL8cgVBnEkFMWzlSgoT36riwgEyhGZiuyTs+T9rJC3En+Pd1Y8P0IjeObhd M5AeHhKOnPBvgRKWfVMQuiY+90lsjrjyE0fRsZQNapLK/40+W8G/hsPzLaiP42OM41m3 D2aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gLom4lP2hibA/zirOs75HpOQiLkyphvf9WwSZgUj8y4=; b=So55OQPKC77yAaOXRlMXBG3x5BQkt6oc2JmAq2CGxhCwcumEtUgOPelm6Ks1yZSF0q kMlytIWawp28IK97YbzitCaHyqEe3dGQO9mTtl2aq+xj3uS7DHNeMj5hzF3ExCNjIHAk ud287crHZe0NoQFWSs5n5tWKFNCaT8+1pxLbm4HbWRFv1t/8fFyfzUnmsy6OI5sbYqPr Fa48c0cFP//CmED3ZxbNr+qMG3AFD3bw2i9aaVGhDB0uEapr1wIyUSUoEsriYbl4ddJC 6e6xObOcTYQLG5j9LxNZXZ1WbWru32QIxy8YL+hD+uGMJB95Pv1sMgPBnq795EGyghMk K8CQ== X-Gm-Message-State: AOAM530XMmUI6zdEkFeiMDrLBkwb9GPnL1csN/6hJSIm1VaeH/lsYwF1 5nhJbiBWLGOMQcdj4uwD9NtoLzG6GeTNZbgRP8N3 X-Received: by 2002:a17:906:3c4a:: with SMTP id i10mr2432624ejg.372.1624346537905; Tue, 22 Jun 2021 00:22:17 -0700 (PDT) MIME-Version: 1.0 References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-10-xieyongji@bytedance.com> <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> In-Reply-To: <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> From: Yongji Xie Date: Tue, 22 Jun 2021 15:22:06 +0800 Message-ID: Subject: Re: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace To: Jason Wang Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Dan Carpenter , joro@8bytes.org, Greg KH , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org .On Tue, Jun 22, 2021 at 1:07 PM Jason Wang wrote: > > > =E5=9C=A8 2021/6/21 =E4=B8=8B=E5=8D=886:41, Yongji Xie =E5=86=99=E9=81=93= : > > On Mon, Jun 21, 2021 at 5:14 PM Jason Wang wrote: > >> > >> =E5=9C=A8 2021/6/15 =E4=B8=8B=E5=8D=8810:13, Xie Yongji =E5=86=99=E9= =81=93: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> The vDPA device's control path is handled in kernel and the data > >>> path is handled in userspace. > >>> > >>> A message mechnism is used by VDUSE driver to forward some control > >>> messages such as starting/stopping datapath to userspace. Userspace > >>> can use read()/write() to receive/reply those control messages. > >>> > >>> And some ioctls are introduced to help userspace to implement the > >>> data path. VDUSE_IOTLB_GET_FD ioctl can be used to get the file > >>> descriptors referring to vDPA device's iova regions. Then userspace > >>> can use mmap() to access those iova regions. VDUSE_DEV_GET_FEATURES > >>> and VDUSE_VQ_GET_INFO ioctls are used to get the negotiated features > >>> and metadata of virtqueues. VDUSE_INJECT_VQ_IRQ and VDUSE_VQ_SETUP_KI= CKFD > >>> ioctls can be used to inject interrupt and setup the kickfd for > >>> virtqueues. VDUSE_DEV_UPDATE_CONFIG ioctl is used to update the > >>> configuration space and inject a config interrupt. > >>> > >>> Signed-off-by: Xie Yongji > >>> --- > >>> Documentation/userspace-api/ioctl/ioctl-number.rst | 1 + > >>> drivers/vdpa/Kconfig | 10 + > >>> drivers/vdpa/Makefile | 1 + > >>> drivers/vdpa/vdpa_user/Makefile | 5 + > >>> drivers/vdpa/vdpa_user/vduse_dev.c | 1453 ++++++++= ++++++++++++ > >>> include/uapi/linux/vduse.h | 143 ++ > >>> 6 files changed, 1613 insertions(+) > >>> create mode 100644 drivers/vdpa/vdpa_user/Makefile > >>> create mode 100644 drivers/vdpa/vdpa_user/vduse_dev.c > >>> create mode 100644 include/uapi/linux/vduse.h > >>> > >>> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Doc= umentation/userspace-api/ioctl/ioctl-number.rst > >>> index 9bfc2b510c64..acd95e9dcfe7 100644 > >>> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > >>> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst > >>> @@ -300,6 +300,7 @@ Code Seq# Include File = Comments > >>> 'z' 10-4F drivers/s390/crypto/zcrypt_api.h = conflict! > >>> '|' 00-7F linux/media.h > >>> 0x80 00-1F linux/fb.h > >>> +0x81 00-1F linux/vduse.h > >>> 0x89 00-06 arch/x86/include/asm/sockios.h > >>> 0x89 0B-DF linux/sockios.h > >>> 0x89 E0-EF linux/sockios.h = SIOCPROTOPRIVATE range > >>> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig > >>> index a503c1b2bfd9..6e23bce6433a 100644 > >>> --- a/drivers/vdpa/Kconfig > >>> +++ b/drivers/vdpa/Kconfig > >>> @@ -33,6 +33,16 @@ config VDPA_SIM_BLOCK > >>> vDPA block device simulator which terminates IO request in a > >>> memory buffer. > >>> > >>> +config VDPA_USER > >>> + tristate "VDUSE (vDPA Device in Userspace) support" > >>> + depends on EVENTFD && MMU && HAS_DMA > >>> + select DMA_OPS > >>> + select VHOST_IOTLB > >>> + select IOMMU_IOVA > >>> + help > >>> + With VDUSE it is possible to emulate a vDPA Device > >>> + in a userspace program. > >>> + > >>> config IFCVF > >>> tristate "Intel IFC VF vDPA driver" > >>> depends on PCI_MSI > >>> diff --git a/drivers/vdpa/Makefile b/drivers/vdpa/Makefile > >>> index 67fe7f3d6943..f02ebed33f19 100644 > >>> --- a/drivers/vdpa/Makefile > >>> +++ b/drivers/vdpa/Makefile > >>> @@ -1,6 +1,7 @@ > >>> # SPDX-License-Identifier: GPL-2.0 > >>> obj-$(CONFIG_VDPA) +=3D vdpa.o > >>> obj-$(CONFIG_VDPA_SIM) +=3D vdpa_sim/ > >>> +obj-$(CONFIG_VDPA_USER) +=3D vdpa_user/ > >>> obj-$(CONFIG_IFCVF) +=3D ifcvf/ > >>> obj-$(CONFIG_MLX5_VDPA) +=3D mlx5/ > >>> obj-$(CONFIG_VP_VDPA) +=3D virtio_pci/ > >>> diff --git a/drivers/vdpa/vdpa_user/Makefile b/drivers/vdpa/vdpa_user= /Makefile > >>> new file mode 100644 > >>> index 000000000000..260e0b26af99 > >>> --- /dev/null > >>> +++ b/drivers/vdpa/vdpa_user/Makefile > >>> @@ -0,0 +1,5 @@ > >>> +# SPDX-License-Identifier: GPL-2.0 > >>> + > >>> +vduse-y :=3D vduse_dev.o iova_domain.o > >>> + > >>> +obj-$(CONFIG_VDPA_USER) +=3D vduse.o > >>> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_u= ser/vduse_dev.c > >>> new file mode 100644 > >>> index 000000000000..5271cbd15e28 > >>> --- /dev/null > >>> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > >>> @@ -0,0 +1,1453 @@ > >>> +// SPDX-License-Identifier: GPL-2.0-only > >>> +/* > >>> + * VDUSE: vDPA Device in Userspace > >>> + * > >>> + * Copyright (C) 2020-2021 Bytedance Inc. and/or its affiliates. All= rights reserved. > >>> + * > >>> + * Author: Xie Yongji > >>> + * > >>> + */ > >>> + > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> + > >>> +#include "iova_domain.h" > >>> + > >>> +#define DRV_AUTHOR "Yongji Xie " > >>> +#define DRV_DESC "vDPA Device in Userspace" > >>> +#define DRV_LICENSE "GPL v2" > >>> + > >>> +#define VDUSE_DEV_MAX (1U << MINORBITS) > >>> +#define VDUSE_MAX_BOUNCE_SIZE (64 * 1024 * 1024) > >>> +#define VDUSE_IOVA_SIZE (128 * 1024 * 1024) > >>> +#define VDUSE_REQUEST_TIMEOUT 30 > >>> + > >>> +struct vduse_virtqueue { > >>> + u16 index; > >>> + u32 num; > >>> + u32 avail_idx; > >>> + u64 desc_addr; > >>> + u64 driver_addr; > >>> + u64 device_addr; > >>> + bool ready; > >>> + bool kicked; > >>> + spinlock_t kick_lock; > >>> + spinlock_t irq_lock; > >>> + struct eventfd_ctx *kickfd; > >>> + struct vdpa_callback cb; > >>> + struct work_struct inject; > >>> +}; > >>> + > >>> +struct vduse_dev; > >>> + > >>> +struct vduse_vdpa { > >>> + struct vdpa_device vdpa; > >>> + struct vduse_dev *dev; > >>> +}; > >>> + > >>> +struct vduse_dev { > >>> + struct vduse_vdpa *vdev; > >>> + struct device *dev; > >>> + struct vduse_virtqueue *vqs; > >>> + struct vduse_iova_domain *domain; > >>> + char *name; > >>> + struct mutex lock; > >>> + spinlock_t msg_lock; > >>> + u64 msg_unique; > >>> + wait_queue_head_t waitq; > >>> + struct list_head send_list; > >>> + struct list_head recv_list; > >>> + struct vdpa_callback config_cb; > >>> + struct work_struct inject; > >>> + spinlock_t irq_lock; > >>> + int minor; > >>> + bool connected; > >>> + bool started; > >>> + u64 api_version; > >>> + u64 user_features; > >> > >> Let's use device_features. > >> > > OK. > > > >>> + u64 features; > >> > >> And driver features. > >> > > OK. > > > >>> + u32 device_id; > >>> + u32 vendor_id; > >>> + u32 generation; > >>> + u32 config_size; > >>> + void *config; > >>> + u8 status; > >>> + u16 vq_size_max; > >>> + u32 vq_num; > >>> + u32 vq_align; > >>> +}; > >>> + > >>> +struct vduse_dev_msg { > >>> + struct vduse_dev_request req; > >>> + struct vduse_dev_response resp; > >>> + struct list_head list; > >>> + wait_queue_head_t waitq; > >>> + bool completed; > >>> +}; > >>> + > >>> +struct vduse_control { > >>> + u64 api_version; > >>> +}; > >>> + > >>> +static DEFINE_MUTEX(vduse_lock); > >>> +static DEFINE_IDR(vduse_idr); > >>> + > >>> +static dev_t vduse_major; > >>> +static struct class *vduse_class; > >>> +static struct cdev vduse_ctrl_cdev; > >>> +static struct cdev vduse_cdev; > >>> +static struct workqueue_struct *vduse_irq_wq; > >>> + > >>> +static u32 allowed_device_id[] =3D { > >>> + VIRTIO_ID_BLOCK, > >>> +}; > >>> + > >>> +static inline struct vduse_dev *vdpa_to_vduse(struct vdpa_device *vd= pa) > >>> +{ > >>> + struct vduse_vdpa *vdev =3D container_of(vdpa, struct vduse_vdp= a, vdpa); > >>> + > >>> + return vdev->dev; > >>> +} > >>> + > >>> +static inline struct vduse_dev *dev_to_vduse(struct device *dev) > >>> +{ > >>> + struct vdpa_device *vdpa =3D dev_to_vdpa(dev); > >>> + > >>> + return vdpa_to_vduse(vdpa); > >>> +} > >>> + > >>> +static struct vduse_dev_msg *vduse_find_msg(struct list_head *head, > >>> + uint32_t request_id) > >>> +{ > >>> + struct vduse_dev_msg *msg; > >>> + > >>> + list_for_each_entry(msg, head, list) { > >>> + if (msg->req.request_id =3D=3D request_id) { > >>> + list_del(&msg->list); > >>> + return msg; > >>> + } > >>> + } > >>> + > >>> + return NULL; > >>> +} > >>> + > >>> +static struct vduse_dev_msg *vduse_dequeue_msg(struct list_head *hea= d) > >>> +{ > >>> + struct vduse_dev_msg *msg =3D NULL; > >>> + > >>> + if (!list_empty(head)) { > >>> + msg =3D list_first_entry(head, struct vduse_dev_msg, li= st); > >>> + list_del(&msg->list); > >>> + } > >>> + > >>> + return msg; > >>> +} > >>> + > >>> +static void vduse_enqueue_msg(struct list_head *head, > >>> + struct vduse_dev_msg *msg) > >>> +{ > >>> + list_add_tail(&msg->list, head); > >>> +} > >>> + > >>> +static int vduse_dev_msg_send(struct vduse_dev *dev, > >>> + struct vduse_dev_msg *msg, bool no_reply) > >>> +{ > >> > >> It looks to me the only user for no_reply=3Dtrue is the dataplane star= t. I > >> wonder no_reply is really needed consider we have switched to use > >> wait_event_killable_timeout(). > >> > > Do we need to handle the error in this case if we remove the no_reply > > flag. Print a warning message? > > > See below. > > > > > >> In another way, no_reply is false for vq state synchronization and IOT= LB > >> updating. I wonder if we can simply use no_reply =3D true for them. > >> > > Looks like we can't, e.g. we need to get a reply from userspace for vq = state. > > > Right. > > > > > >>> + init_waitqueue_head(&msg->waitq); > >>> + spin_lock(&dev->msg_lock); > >>> + msg->req.request_id =3D dev->msg_unique++; > >>> + vduse_enqueue_msg(&dev->send_list, msg); > >>> + wake_up(&dev->waitq); > >>> + spin_unlock(&dev->msg_lock); > >>> + if (no_reply) > >>> + return 0; > >>> + > >>> + wait_event_killable_timeout(msg->waitq, msg->completed, > >>> + VDUSE_REQUEST_TIMEOUT * HZ); > >>> + spin_lock(&dev->msg_lock); > >>> + if (!msg->completed) { > >>> + list_del(&msg->list); > >>> + msg->resp.result =3D VDUSE_REQ_RESULT_FAILED; > >>> + } > >>> + spin_unlock(&dev->msg_lock); > >>> + > >>> + return (msg->resp.result =3D=3D VDUSE_REQ_RESULT_OK) ? 0 : -EIO= ; > >> > >> Do we need to serialize the check by protecting it with the spinlock a= bove? > >> > > Good point. > > > >>> +} > >>> + > >>> +static void vduse_dev_msg_cleanup(struct vduse_dev *dev) > >>> +{ > >>> + struct vduse_dev_msg *msg; > >>> + > >>> + spin_lock(&dev->msg_lock); > >>> + while ((msg =3D vduse_dequeue_msg(&dev->send_list))) { > >>> + if (msg->req.flags & VDUSE_REQ_FLAGS_NO_REPLY) > >>> + kfree(msg); > >>> + else > >>> + vduse_enqueue_msg(&dev->recv_list, msg); > >>> + } > >>> + while ((msg =3D vduse_dequeue_msg(&dev->recv_list))) { > >>> + msg->resp.result =3D VDUSE_REQ_RESULT_FAILED; > >>> + msg->completed =3D 1; > >>> + wake_up(&msg->waitq); > >>> + } > >>> + spin_unlock(&dev->msg_lock); > >>> +} > >>> + > >>> +static void vduse_dev_start_dataplane(struct vduse_dev *dev) > >>> +{ > >>> + struct vduse_dev_msg *msg =3D kzalloc(sizeof(*msg), > >>> + GFP_KERNEL | __GFP_NOFAIL); > >>> + > >>> + msg->req.type =3D VDUSE_START_DATAPLANE; > >>> + msg->req.flags |=3D VDUSE_REQ_FLAGS_NO_REPLY; > >>> + vduse_dev_msg_send(dev, msg, true); > >>> +} > >>> + > >>> +static void vduse_dev_stop_dataplane(struct vduse_dev *dev) > >>> +{ > >>> + struct vduse_dev_msg *msg =3D kzalloc(sizeof(*msg), > >>> + GFP_KERNEL | __GFP_NOFAIL); > >>> + > >>> + msg->req.type =3D VDUSE_STOP_DATAPLANE; > >>> + msg->req.flags |=3D VDUSE_REQ_FLAGS_NO_REPLY; > >> > >> Can we simply use this flag instead of introducing a new parameter > >> (no_reply) in vduse_dev_msg_send()? > >> > > Looks good to me. > > > >>> + vduse_dev_msg_send(dev, msg, true); > >>> +} > >>> + > >>> +static int vduse_dev_get_vq_state(struct vduse_dev *dev, > >>> + struct vduse_virtqueue *vq, > >>> + struct vdpa_vq_state *state) > >>> +{ > >>> + struct vduse_dev_msg msg =3D { 0 }; > >>> + int ret; > >> > >> Note that I post a series that implement the packed virtqueue support: > >> > >> https://lists.linuxfoundation.org/pipermail/virtualization/2021-June/0= 54501.html > >> > >> So this patch needs to be updated as well. > >> > > Will do it. > > > >>> + > >>> + msg.req.type =3D VDUSE_GET_VQ_STATE; > >>> + msg.req.vq_state.index =3D vq->index; > >>> + > >>> + ret =3D vduse_dev_msg_send(dev, &msg, false); > >>> + if (ret) > >>> + return ret; > >>> + > >>> + state->avail_index =3D msg.resp.vq_state.avail_idx; > >>> + return 0; > >>> +} > >>> + > >>> +static int vduse_dev_update_iotlb(struct vduse_dev *dev, > >>> + u64 start, u64 last) > >>> +{ > >>> + struct vduse_dev_msg msg =3D { 0 }; > >>> + > >>> + if (last < start) > >>> + return -EINVAL; > >>> + > >>> + msg.req.type =3D VDUSE_UPDATE_IOTLB; > >>> + msg.req.iova.start =3D start; > >>> + msg.req.iova.last =3D last; > >>> + > >>> + return vduse_dev_msg_send(dev, &msg, false); > >>> +} > >>> + > >>> +static ssize_t vduse_dev_read_iter(struct kiocb *iocb, struct iov_it= er *to) > >>> +{ > >>> + struct file *file =3D iocb->ki_filp; > >>> + struct vduse_dev *dev =3D file->private_data; > >>> + struct vduse_dev_msg *msg; > >>> + int size =3D sizeof(struct vduse_dev_request); > >>> + ssize_t ret; > >>> + > >>> + if (iov_iter_count(to) < size) > >>> + return -EINVAL; > >>> + > >>> + spin_lock(&dev->msg_lock); > >>> + while (1) { > >>> + msg =3D vduse_dequeue_msg(&dev->send_list); > >>> + if (msg) > >>> + break; > >>> + > >>> + ret =3D -EAGAIN; > >>> + if (file->f_flags & O_NONBLOCK) > >>> + goto unlock; > >>> + > >>> + spin_unlock(&dev->msg_lock); > >>> + ret =3D wait_event_interruptible_exclusive(dev->waitq, > >>> + !list_empty(&dev->send_list)); > >>> + if (ret) > >>> + return ret; > >>> + > >>> + spin_lock(&dev->msg_lock); > >>> + } > >>> + spin_unlock(&dev->msg_lock); > >>> + ret =3D copy_to_iter(&msg->req, size, to); > >>> + spin_lock(&dev->msg_lock); > >>> + if (ret !=3D size) { > >>> + ret =3D -EFAULT; > >>> + vduse_enqueue_msg(&dev->send_list, msg); > >>> + goto unlock; > >>> + } > >>> + if (msg->req.flags & VDUSE_REQ_FLAGS_NO_REPLY) > >>> + kfree(msg); > >>> + else > >>> + vduse_enqueue_msg(&dev->recv_list, msg); > >>> +unlock: > >>> + spin_unlock(&dev->msg_lock); > >>> + > >>> + return ret; > >>> +} > >>> + > >>> +static ssize_t vduse_dev_write_iter(struct kiocb *iocb, struct iov_i= ter *from) > >>> +{ > >>> + struct file *file =3D iocb->ki_filp; > >>> + struct vduse_dev *dev =3D file->private_data; > >>> + struct vduse_dev_response resp; > >>> + struct vduse_dev_msg *msg; > >>> + size_t ret; > >>> + > >>> + ret =3D copy_from_iter(&resp, sizeof(resp), from); > >>> + if (ret !=3D sizeof(resp)) > >>> + return -EINVAL; > >>> + > >>> + spin_lock(&dev->msg_lock); > >>> + msg =3D vduse_find_msg(&dev->recv_list, resp.request_id); > >>> + if (!msg) { > >>> + ret =3D -ENOENT; > >>> + goto unlock; > >>> + } > >>> + > >>> + memcpy(&msg->resp, &resp, sizeof(resp)); > >>> + msg->completed =3D 1; > >>> + wake_up(&msg->waitq); > >>> +unlock: > >>> + spin_unlock(&dev->msg_lock); > >>> + > >>> + return ret; > >>> +} > >>> + > >>> +static __poll_t vduse_dev_poll(struct file *file, poll_table *wait) > >>> +{ > >>> + struct vduse_dev *dev =3D file->private_data; > >>> + __poll_t mask =3D 0; > >>> + > >>> + poll_wait(file, &dev->waitq, wait); > >>> + > >>> + if (!list_empty(&dev->send_list)) > >>> + mask |=3D EPOLLIN | EPOLLRDNORM; > >>> + if (!list_empty(&dev->recv_list)) > >>> + mask |=3D EPOLLOUT | EPOLLWRNORM; > >>> + > >>> + return mask; > >>> +} > >>> + > >>> +static void vduse_dev_reset(struct vduse_dev *dev) > >>> +{ > >>> + int i; > >>> + struct vduse_iova_domain *domain =3D dev->domain; > >>> + > >>> + /* The coherent mappings are handled in vduse_dev_free_coherent= () */ > >>> + if (domain->bounce_map) > >>> + vduse_domain_reset_bounce_map(domain); > >>> + > >>> + dev->features =3D 0; > >>> + dev->generation++; > >>> + spin_lock(&dev->irq_lock); > >>> + dev->config_cb.callback =3D NULL; > >>> + dev->config_cb.private =3D NULL; > >>> + spin_unlock(&dev->irq_lock); > >>> + > >>> + for (i =3D 0; i < dev->vq_num; i++) { > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[i]; > >>> + > >>> + vq->ready =3D false; > >>> + vq->desc_addr =3D 0; > >>> + vq->driver_addr =3D 0; > >>> + vq->device_addr =3D 0; > >>> + vq->avail_idx =3D 0; > >>> + vq->num =3D 0; > >>> + > >>> + spin_lock(&vq->kick_lock); > >>> + vq->kicked =3D false; > >>> + if (vq->kickfd) > >>> + eventfd_ctx_put(vq->kickfd); > >>> + vq->kickfd =3D NULL; > >>> + spin_unlock(&vq->kick_lock); > >>> + > >>> + spin_lock(&vq->irq_lock); > >>> + vq->cb.callback =3D NULL; > >>> + vq->cb.private =3D NULL; > >>> + spin_unlock(&vq->irq_lock); > >>> + } > >>> +} > >>> + > >>> +static int vduse_vdpa_set_vq_address(struct vdpa_device *vdpa, u16 i= dx, > >>> + u64 desc_area, u64 driver_area, > >>> + u64 device_area) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + vq->desc_addr =3D desc_area; > >>> + vq->driver_addr =3D driver_area; > >>> + vq->device_addr =3D device_area; > >>> + > >>> + return 0; > >>> +} > >>> + > >>> +static void vduse_vdpa_kick_vq(struct vdpa_device *vdpa, u16 idx) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + spin_lock(&vq->kick_lock); > >>> + if (!vq->ready) > >>> + goto unlock; > >>> + > >>> + if (vq->kickfd) > >>> + eventfd_signal(vq->kickfd, 1); > >>> + else > >>> + vq->kicked =3D true; > >>> +unlock: > >>> + spin_unlock(&vq->kick_lock); > >>> +} > >>> + > >>> +static void vduse_vdpa_set_vq_cb(struct vdpa_device *vdpa, u16 idx, > >>> + struct vdpa_callback *cb) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + spin_lock(&vq->irq_lock); > >>> + vq->cb.callback =3D cb->callback; > >>> + vq->cb.private =3D cb->private; > >>> + spin_unlock(&vq->irq_lock); > >>> +} > >>> + > >>> +static void vduse_vdpa_set_vq_num(struct vdpa_device *vdpa, u16 idx,= u32 num) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + vq->num =3D num; > >>> +} > >>> + > >>> +static void vduse_vdpa_set_vq_ready(struct vdpa_device *vdpa, > >>> + u16 idx, bool ready) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + vq->ready =3D ready; > >>> +} > >>> + > >>> +static bool vduse_vdpa_get_vq_ready(struct vdpa_device *vdpa, u16 id= x) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + return vq->ready; > >>> +} > >>> + > >>> +static int vduse_vdpa_set_vq_state(struct vdpa_device *vdpa, u16 idx= , > >>> + const struct vdpa_vq_state *state) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + vq->avail_idx =3D state->avail_index; > >>> + return 0; > >>> +} > >>> + > >>> +static int vduse_vdpa_get_vq_state(struct vdpa_device *vdpa, u16 idx= , > >>> + struct vdpa_vq_state *state) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + struct vduse_virtqueue *vq =3D &dev->vqs[idx]; > >>> + > >>> + return vduse_dev_get_vq_state(dev, vq, state); > >>> +} > >>> + > >>> +static u32 vduse_vdpa_get_vq_align(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->vq_align; > >>> +} > >>> + > >>> +static u64 vduse_vdpa_get_features(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->user_features; > >>> +} > >>> + > >>> +static int vduse_vdpa_set_features(struct vdpa_device *vdpa, u64 fea= tures) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + dev->features =3D features; > >>> + return 0; > >>> +} > >>> + > >>> +static void vduse_vdpa_set_config_cb(struct vdpa_device *vdpa, > >>> + struct vdpa_callback *cb) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + spin_lock(&dev->irq_lock); > >>> + dev->config_cb.callback =3D cb->callback; > >>> + dev->config_cb.private =3D cb->private; > >>> + spin_unlock(&dev->irq_lock); > >>> +} > >>> + > >>> +static u16 vduse_vdpa_get_vq_num_max(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->vq_size_max; > >>> +} > >>> + > >>> +static u32 vduse_vdpa_get_device_id(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->device_id; > >>> +} > >>> + > >>> +static u32 vduse_vdpa_get_vendor_id(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->vendor_id; > >>> +} > >>> + > >>> +static u8 vduse_vdpa_get_status(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->status; > >>> +} > >>> + > >>> +static void vduse_vdpa_set_status(struct vdpa_device *vdpa, u8 statu= s) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + bool started =3D !!(status & VIRTIO_CONFIG_S_DRIVER_OK); > >>> + > >>> + dev->status =3D status; > >>> + > >>> + if (dev->started =3D=3D started) > >>> + return; > >> > >> If we check dev->status =3D=3D status, (or only check the DRIVER_OK bi= t) > >> then there's no need to introduce an extra dev->started. > >> > > Will do it. > > > >>> + > >>> + dev->started =3D started; > >>> + if (dev->started) { > >>> + vduse_dev_start_dataplane(dev); > >>> + } else { > >>> + vduse_dev_reset(dev); > >>> + vduse_dev_stop_dataplane(dev); > >> > >> I wonder if no_reply work for the case of vhost-vdpa. For virtio-vDPA, > >> we have bouncing buffers so it's harmless if usersapce dataplane keeps > >> performing read/write. For vhost-vDPA we don't have such stuffs. > >> > > OK. So it still needs to be synchronized here. If so, how to handle > > the error? Looks like printing a warning message should be enough. > > > We need fix a way to propagate the error to the userspace. > > E.g if we want to stop the deivce, we will delay the status reset until > we get respose from the userspace? > I didn't get how to delay the status reset. And should it be a DoS that we want to fix if the userspace doesn't give a response forever? > > > > >>> + } > >>> +} > >>> + > >>> +static size_t vduse_vdpa_get_config_size(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->config_size; > >>> +} > >>> + > >>> +static void vduse_vdpa_get_config(struct vdpa_device *vdpa, unsigned= int offset, > >>> + void *buf, unsigned int len) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + memcpy(buf, dev->config + offset, len); > >>> +} > >>> + > >>> +static void vduse_vdpa_set_config(struct vdpa_device *vdpa, unsigned= int offset, > >>> + const void *buf, unsigned int len) > >>> +{ > >>> + /* Now we only support read-only configuration space */ > >>> +} > >>> + > >>> +static u32 vduse_vdpa_get_generation(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + return dev->generation; > >>> +} > >>> + > >>> +static int vduse_vdpa_set_map(struct vdpa_device *vdpa, > >>> + struct vhost_iotlb *iotlb) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + int ret; > >>> + > >>> + ret =3D vduse_domain_set_map(dev->domain, iotlb); > >>> + if (ret) > >>> + return ret; > >>> + > >>> + ret =3D vduse_dev_update_iotlb(dev, 0ULL, ULLONG_MAX); > >>> + if (ret) { > >>> + vduse_domain_clear_map(dev->domain, iotlb); > >>> + return ret; > >>> + } > >>> + > >>> + return 0; > >>> +} > >>> + > >>> +static void vduse_vdpa_free(struct vdpa_device *vdpa) > >>> +{ > >>> + struct vduse_dev *dev =3D vdpa_to_vduse(vdpa); > >>> + > >>> + dev->vdev =3D NULL; > >>> +} > >>> + > >>> +static const struct vdpa_config_ops vduse_vdpa_config_ops =3D { > >>> + .set_vq_address =3D vduse_vdpa_set_vq_address, > >>> + .kick_vq =3D vduse_vdpa_kick_vq, > >>> + .set_vq_cb =3D vduse_vdpa_set_vq_cb, > >>> + .set_vq_num =3D vduse_vdpa_set_vq_num, > >>> + .set_vq_ready =3D vduse_vdpa_set_vq_ready, > >>> + .get_vq_ready =3D vduse_vdpa_get_vq_ready, > >>> + .set_vq_state =3D vduse_vdpa_set_vq_state, > >>> + .get_vq_state =3D vduse_vdpa_get_vq_state, > >>> + .get_vq_align =3D vduse_vdpa_get_vq_align, > >>> + .get_features =3D vduse_vdpa_get_features, > >>> + .set_features =3D vduse_vdpa_set_features, > >>> + .set_config_cb =3D vduse_vdpa_set_config_cb, > >>> + .get_vq_num_max =3D vduse_vdpa_get_vq_num_max, > >>> + .get_device_id =3D vduse_vdpa_get_device_id, > >>> + .get_vendor_id =3D vduse_vdpa_get_vendor_id, > >>> + .get_status =3D vduse_vdpa_get_status, > >>> + .set_status =3D vduse_vdpa_set_status, > >>> + .get_config_size =3D vduse_vdpa_get_config_size, > >>> + .get_config =3D vduse_vdpa_get_config, > >>> + .set_config =3D vduse_vdpa_set_config, > >>> + .get_generation =3D vduse_vdpa_get_generation, > >>> + .set_map =3D vduse_vdpa_set_map, > >>> + .free =3D vduse_vdpa_free, > >>> +}; > >>> + > >>> +static dma_addr_t vduse_dev_map_page(struct device *dev, struct page= *page, > >>> + unsigned long offset, size_t size, > >>> + enum dma_data_direction dir, > >>> + unsigned long attrs) > >>> +{ > >>> + struct vduse_dev *vdev =3D dev_to_vduse(dev); > >>> + struct vduse_iova_domain *domain =3D vdev->domain; > >>> + > >>> + return vduse_domain_map_page(domain, page, offset, size, dir, a= ttrs); > >>> +} > >>> + > >>> +static void vduse_dev_unmap_page(struct device *dev, dma_addr_t dma_= addr, > >>> + size_t size, enum dma_data_direction di= r, > >>> + unsigned long attrs) > >>> +{ > >>> + struct vduse_dev *vdev =3D dev_to_vduse(dev); > >>> + struct vduse_iova_domain *domain =3D vdev->domain; > >>> + > >>> + return vduse_domain_unmap_page(domain, dma_addr, size, dir, att= rs); > >>> +} > >>> + > >>> +static void *vduse_dev_alloc_coherent(struct device *dev, size_t siz= e, > >>> + dma_addr_t *dma_addr, gfp_t fla= g, > >>> + unsigned long attrs) > >>> +{ > >>> + struct vduse_dev *vdev =3D dev_to_vduse(dev); > >>> + struct vduse_iova_domain *domain =3D vdev->domain; > >>> + unsigned long iova; > >>> + void *addr; > >>> + > >>> + *dma_addr =3D DMA_MAPPING_ERROR; > >>> + addr =3D vduse_domain_alloc_coherent(domain, size, > >>> + (dma_addr_t *)&iova, flag, attrs); > >>> + if (!addr) > >>> + return NULL; > >>> + > >>> + *dma_addr =3D (dma_addr_t)iova; > >>> + > >>> + return addr; > >>> +} > >>> + > >>> +static void vduse_dev_free_coherent(struct device *dev, size_t size, > >>> + void *vaddr, dma_addr_t dma_add= r, > >>> + unsigned long attrs) > >>> +{ > >>> + struct vduse_dev *vdev =3D dev_to_vduse(dev); > >>> + struct vduse_iova_domain *domain =3D vdev->domain; > >>> + > >>> + vduse_domain_free_coherent(domain, size, vaddr, dma_addr, attrs= ); > >>> +} > >>> + > >>> +static size_t vduse_dev_max_mapping_size(struct device *dev) > >>> +{ > >>> + struct vduse_dev *vdev =3D dev_to_vduse(dev); > >>> + struct vduse_iova_domain *domain =3D vdev->domain; > >>> + > >>> + return domain->bounce_size; > >>> +} > >>> + > >>> +static const struct dma_map_ops vduse_dev_dma_ops =3D { > >>> + .map_page =3D vduse_dev_map_page, > >>> + .unmap_page =3D vduse_dev_unmap_page, > >>> + .alloc =3D vduse_dev_alloc_coherent, > >>> + .free =3D vduse_dev_free_coherent, > >>> + .max_mapping_size =3D vduse_dev_max_mapping_size, > >>> +}; > >>> + > >>> +static unsigned int perm_to_file_flags(u8 perm) > >>> +{ > >>> + unsigned int flags =3D 0; > >>> + > >>> + switch (perm) { > >>> + case VDUSE_ACCESS_WO: > >>> + flags |=3D O_WRONLY; > >>> + break; > >>> + case VDUSE_ACCESS_RO: > >>> + flags |=3D O_RDONLY; > >>> + break; > >>> + case VDUSE_ACCESS_RW: > >>> + flags |=3D O_RDWR; > >>> + break; > >>> + default: > >>> + WARN(1, "invalidate vhost IOTLB permission\n"); > >>> + break; > >>> + } > >>> + > >>> + return flags; > >>> +} > >>> + > >>> +static int vduse_kickfd_setup(struct vduse_dev *dev, > >>> + struct vduse_vq_eventfd *eventfd) > >>> +{ > >>> + struct eventfd_ctx *ctx =3D NULL; > >>> + struct vduse_virtqueue *vq; > >>> + u32 index; > >>> + > >>> + if (eventfd->index >=3D dev->vq_num) > >>> + return -EINVAL; > >>> + > >>> + index =3D array_index_nospec(eventfd->index, dev->vq_num); > >>> + vq =3D &dev->vqs[index]; > >>> + if (eventfd->fd >=3D 0) { > >>> + ctx =3D eventfd_ctx_fdget(eventfd->fd); > >>> + if (IS_ERR(ctx)) > >>> + return PTR_ERR(ctx); > >>> + } else if (eventfd->fd !=3D VDUSE_EVENTFD_DEASSIGN) > >>> + return 0; > >>> + > >>> + spin_lock(&vq->kick_lock); > >>> + if (vq->kickfd) > >>> + eventfd_ctx_put(vq->kickfd); > >>> + vq->kickfd =3D ctx; > >>> + if (vq->ready && vq->kicked && vq->kickfd) { > >>> + eventfd_signal(vq->kickfd, 1); > >>> + vq->kicked =3D false; > >>> + } > >>> + spin_unlock(&vq->kick_lock); > >>> + > >>> + return 0; > >>> +} > >>> + > >>> +static void vduse_dev_irq_inject(struct work_struct *work) > >>> +{ > >>> + struct vduse_dev *dev =3D container_of(work, struct vduse_dev, = inject); > >>> + > >>> + spin_lock_irq(&dev->irq_lock); > >>> + if (dev->config_cb.callback) > >>> + dev->config_cb.callback(dev->config_cb.private); > >>> + spin_unlock_irq(&dev->irq_lock); > >>> +} > >>> + > >>> +static void vduse_vq_irq_inject(struct work_struct *work) > >>> +{ > >>> + struct vduse_virtqueue *vq =3D container_of(work, > >>> + struct vduse_virtqueue, inject)= ; > >>> + > >>> + spin_lock_irq(&vq->irq_lock); > >>> + if (vq->ready && vq->cb.callback) > >>> + vq->cb.callback(vq->cb.private); > >>> + spin_unlock_irq(&vq->irq_lock); > >>> +} > >>> + > >>> +static long vduse_dev_ioctl(struct file *file, unsigned int cmd, > >>> + unsigned long arg) > >>> +{ > >>> + struct vduse_dev *dev =3D file->private_data; > >>> + void __user *argp =3D (void __user *)arg; > >>> + int ret; > >>> + > >>> + switch (cmd) { > >>> + case VDUSE_IOTLB_GET_FD: { > >>> + struct vduse_iotlb_entry entry; > >>> + struct vhost_iotlb_map *map; > >>> + struct vdpa_map_file *map_file; > >>> + struct vduse_iova_domain *domain =3D dev->domain; > >>> + struct file *f =3D NULL; > >>> + > >>> + ret =3D -EFAULT; > >>> + if (copy_from_user(&entry, argp, sizeof(entry))) > >>> + break; > >>> + > >>> + ret =3D -EINVAL; > >>> + if (entry.start > entry.last) > >>> + break; > >>> + > >>> + spin_lock(&domain->iotlb_lock); > >>> + map =3D vhost_iotlb_itree_first(domain->iotlb, > >>> + entry.start, entry.last); > >>> + if (map) { > >>> + map_file =3D (struct vdpa_map_file *)map->opaqu= e; > >>> + f =3D get_file(map_file->file); > >>> + entry.offset =3D map_file->offset; > >>> + entry.start =3D map->start; > >>> + entry.last =3D map->last; > >>> + entry.perm =3D map->perm; > >>> + } > >>> + spin_unlock(&domain->iotlb_lock); > >>> + ret =3D -EINVAL; > >>> + if (!f) > >>> + break; > >>> + > >>> + ret =3D -EFAULT; > >>> + if (copy_to_user(argp, &entry, sizeof(entry))) { > >>> + fput(f); > >>> + break; > >>> + } > >>> + ret =3D receive_fd(f, perm_to_file_flags(entry.perm)); > >>> + fput(f); > >>> + break; > >>> + } > >>> + case VDUSE_DEV_GET_FEATURES: > >>> + ret =3D put_user(dev->features, (u64 __user *)argp); > >>> + break; > >>> + case VDUSE_DEV_UPDATE_CONFIG: { > >>> + struct vduse_config_update config; > >>> + unsigned long size =3D offsetof(struct vduse_config_upd= ate, > >>> + buffer); > >>> + > >>> + ret =3D -EFAULT; > >>> + if (copy_from_user(&config, argp, size)) > >>> + break; > >>> + > >>> + ret =3D -EINVAL; > >>> + if (config.length =3D=3D 0 || > >>> + config.length > dev->config_size - config.offset) > >>> + break; > >>> + > >>> + ret =3D -EFAULT; > >>> + if (copy_from_user(dev->config + config.offset, argp + = size, > >>> + config.length)) > >>> + break; > >>> + > >>> + ret =3D 0; > >>> + queue_work(vduse_irq_wq, &dev->inject); > >> > >> I wonder if it's better to separate config interrupt out of config > >> update or we need document this. > >> > > I have documented it in the docs. Looks like a config update should be > > always followed by a config interrupt. I didn't find a case that uses > > them separately. > > > The uAPI doesn't prevent us from the following scenario: > > update_config(mac[0], ..); > update_config(max[1], ..); > > So it looks to me it's better to separate the config interrupt from the > config updating. > Fine. > > > > >>> + break; > >>> + } > >>> + case VDUSE_VQ_GET_INFO: { > >> > >> Do we need to limit this only when DRIVER_OK is set? > >> > > Any reason to add this limitation? > > > Otherwise the vq is not fully initialized, e.g the desc_addr might not > be correct. > The vq_info->ready can be used to tell userspace whether the vq is initialized or not. Thanks, Yongji