Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4465680pxj;
        Tue, 22 Jun 2021 00:27:06 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzevvailmwNEddp6YS6MN4l5rQaddTRI6oqAPAFtct7gChkm/uq5k67ZzE/zJ7Ot0C20be9
X-Received: by 2002:a02:380c:: with SMTP id b12mr2535731jaa.98.1624346826748;
        Tue, 22 Jun 2021 00:27:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1624346826; cv=none;
        d=google.com; s=arc-20160816;
        b=Nm/c1fG4+T90mgpFtz9jd19bkgySZNi6lh3gUV/9HnRffmU/HYpI5KAbOQly4k6fT/
         vDCHBOievIUnxYXVAkbyXS2HmqutBrqymRJf3P1L/rWWuoiRE4azgum/csl1tiIlAggH
         4ItbVNjJkmrSuQYNgND/lutPYYV08G4jMnlMBth61uex2vuIpvROGetfIfvUUsEqJdy/
         ZG8fRZ7whXoxXTabX/LhNYheAOmqdxZBIm60eeTpPB9jWUEqS0YP32VYvOGDUcZkV7El
         c6pkWkx6Ns/xVpp0PJxomDg+CRJgsFN5ywOq7CU+bfWVRYogJSvbEjc+yorAdDiVhWp5
         LmqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:thread-index:thread-topic
         :content-transfer-encoding:mime-version:subject:references
         :in-reply-to:message-id:cc:to:from:date;
        bh=MlI3EiyTH4UpPn4ImlvwKJjb/RVFT4qxCChZpY1c+e4=;
        b=Tj6Kns9y/ipre2SA/CV5ZYokce1gWe+NmgH/exBoXyuYiAMNfJCNuWTvMZpcLZ5xN3
         aP5I+3LLFsnSiaTz79hTTHVYOQ1IA57zQypjFdZwtgZsd5Mij8U47B9/BOx/mmTQqK6P
         HxKGGiShW7d6SilGmzo7133WPZhwqkmo0+mPCNGkLE5u+w7N8rMrpPusvsV6pkNPoOO2
         1Tn7CV3j+Evg3uhrux/Nibnll1j22PghrmoGOYI1cG2CybaVseNIQBbPVreIxMYlbNMD
         q8p9zrmofzwRc7L16x1D5f0eby3Kui6gFbI2V1bSw2IaoyqW4aeAOCmShzbusFN37fnx
         7jbA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id f16si19286612iox.100.2021.06.22.00.26.55;
        Tue, 22 Jun 2021 00:27:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230224AbhFVH2h convert rfc822-to-8bit (ORCPT
        <rfc822;m15259695263@gmail.com> + 99 others);
        Tue, 22 Jun 2021 03:28:37 -0400
Received: from lithops.sigma-star.at ([195.201.40.130]:53330 "EHLO
        lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229628AbhFVH2h (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Jun 2021 03:28:37 -0400
Received: from localhost (localhost [127.0.0.1])
        by lithops.sigma-star.at (Postfix) with ESMTP id 2553860A59CD;
        Tue, 22 Jun 2021 09:26:20 +0200 (CEST)
Received: from lithops.sigma-star.at ([127.0.0.1])
        by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032)
        with ESMTP id gnEp7wI087K7; Tue, 22 Jun 2021 09:26:19 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
        by lithops.sigma-star.at (Postfix) with ESMTP id D845E60A59DE;
        Tue, 22 Jun 2021 09:26:19 +0200 (CEST)
Received: from lithops.sigma-star.at ([127.0.0.1])
        by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026)
        with ESMTP id hJjPVIp0vUEK; Tue, 22 Jun 2021 09:26:19 +0200 (CEST)
Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130])
        by lithops.sigma-star.at (Postfix) with ESMTP id B844D60A59CD;
        Tue, 22 Jun 2021 09:26:19 +0200 (CEST)
Date:   Tue, 22 Jun 2021 09:26:19 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     chengzhihao1 <chengzhihao1@huawei.com>,
        Colin Ian King <colin.king@canonical.com>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <1855987833.142283.1624346779725.JavaMail.zimbra@nod.at>
In-Reply-To: <20210622064419.GJ1901@kadam>
References: <20210621152249.20901-1-colin.king@canonical.com> <f2ea606a-4a05-8d14-4380-d96ca0f981a1@huawei.com> <20210622064419.GJ1901@kadam>
Subject: Re: [PATCH] ubifs: Remove a redundant null check on pointer lp
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
X-Originating-IP: [195.201.40.130]
X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF78 (Linux)/8.8.12_GA_3809)
Thread-Topic: ubifs: Remove a redundant null check on pointer lp
Thread-Index: LtxiwfRXOC2sFlJZKjZSpX+xuqDRmg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

----- Ursprüngliche Mail -----
> Ugh...  I'm so sorry.  My patch was clearly wrong.  I've tried before to

No need to worry. :)

> add a Smatch check which warns about duplicative NULL checks, but I
> think this gives me a new idea to try.  Hopefully, it will prevent this
> in the future.

Sounds great!

Thanks,
//richard