Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4494178pxj; Tue, 22 Jun 2021 01:16:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwje44/BahG1MxiBfbF4pvoKuU163NEoILB3t69Z/NFqq+b19ph6uuoVzM9pSSUzx4AsFnb X-Received: by 2002:a17:906:2bd0:: with SMTP id n16mr2770779ejg.110.1624349790285; Tue, 22 Jun 2021 01:16:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624349790; cv=none; d=google.com; s=arc-20160816; b=O0WgL8fhGvZ3OVizxBZGJYGRC2pJQGWEM2qA29Ncrhy4FUuXr4ttnZO5rPTLEHKyVe JQM6n8WZyGlIpLq5Eac3p2sHptUxSvhT7hR+KYjZdRq32PrkPq9GzYXR7JSM4zOwktGj fPIIh7mtsBLX7XcbVE1cHGrWcSMLuw92V5IKQ6Y67bETJjkEu6781LX/LiBo2rh8TGnD vH/eWQt34Z4fIEOpcVFiEUNBBSa07K3ZGGppPGk2/qFPyR2JE2ZlYEfhimyuVG2Czzcc Q20zew/NQU+16oo/Dy0XBUXvc5bc/+INxtrBlliDg3dPC1UWO9FzLGFz0Kkx7xN0mbPh g+0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=YVCp8xiBvtUwUFNttbUN5nSyQGNG3BOtMHGI4CyjTHQ=; b=LVcpW5FWoaYO/CwYiQoptCibCuruZNm1NDWm9M7DM//g+dIMB7BowN/QJGNdnlz6Oa KDUIq0LVf/v0mFIFwULDXjgUNj0G5szHuwfG/uCO/yCt/XOi0FxtR2uHNNUT8Zr7uyxM NIh3GWit56U/eSh/cbgLANNT297VcdVMdc1XfYnrj/qK2ldA888uaIYVGjiPEsPQii3e 1cPrGMq854PcK/McojHgi+++wC5FEjfuyJAmaUqOLa/0GNKkzdhKB/kPvA3wjvFI63sJ zo2qyNKiuTAIGA37pCQDTbGdp7b0/8zLZwY+nd4L9VyjFYuRsr1xBMcd//zj9wst3noF 6iXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=o28htubt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si11494535edr.513.2021.06.22.01.16.07; Tue, 22 Jun 2021 01:16:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=o28htubt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbhFVIRY (ORCPT + 99 others); Tue, 22 Jun 2021 04:17:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbhFVIRX (ORCPT ); Tue, 22 Jun 2021 04:17:23 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86C75C061760 for ; Tue, 22 Jun 2021 01:15:06 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id my49so33029453ejc.7 for ; Tue, 22 Jun 2021 01:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YVCp8xiBvtUwUFNttbUN5nSyQGNG3BOtMHGI4CyjTHQ=; b=o28htubtbLEiarTQcM4helMW63ggtrRYD6odB80RYrMKlzXBuBNkg6jqk7xSk51aaf O28DIRNwUv88sKL7YBwXuvCLNoIBLB+qyueDzvX1XAPAF+lP7b6r00JG0ydO3mbfBvjj MITBvN5IFEf9VgWqwbQ5cTBOQbN005m0gdSrZ4UFZ5PhJfMcLeyIImvlDYQppBZOLOIs wivfY/Yy9LtygR+8wILj+pUcRikwSCVZB5LjievWPsu4MJMdYRsp3p46J9zcNoF3btSf hqfnJys8BLX9k98ZfHt7+Ao5s4RN54hEJpzwW0KS+1cLQ67k5xAElsfeANuN+ySwxymS gCeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YVCp8xiBvtUwUFNttbUN5nSyQGNG3BOtMHGI4CyjTHQ=; b=jTWjPObcn2WaEa1brEAWorODGpVmBx0QWy5EhJiM69Ko9HSqFR+dj0HeVC5iX7HRwE C/c+FVcUaVTptBUVJcIpXkqUxSeoZtmQ9DHfy8qUE5Iwqjn17Z51QJlZM2UBsVqcj1Lg EivTy2dyOo4nNWHpWBXmq6VVhI0W2e5WDjWFJRSRuV08H58KP/bf/aLQHXFODQAIyv6Q okG+pnheqsKNNWEI4P3mIUsJZWmaGVgcamfTV/KFAp9Vzu/aVCW2FNIAKMtp8bswOjL/ Zgew9OfuPWsGiMv3HyaU7KWHXBHqb5CJzpPYc6z1sAEBoxhnPqaEzAcbYg02PNVwK203 AVyQ== X-Gm-Message-State: AOAM532VD7rKgzioNjKFlZg1/USVGDtQZ/oSde0xWQeBJcAKtIkk1AaJ kBcZtcOvIzCafjGR7mkB6tt4hZyq+eVqK1QwwYY8 X-Received: by 2002:a17:907:1b11:: with SMTP id mp17mr2736493ejc.1.1624349704564; Tue, 22 Jun 2021 01:15:04 -0700 (PDT) MIME-Version: 1.0 References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-10-xieyongji@bytedance.com> <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> <0aeb7cb7-58e5-1a95-d830-68edd7e8ec2e@redhat.com> In-Reply-To: <0aeb7cb7-58e5-1a95-d830-68edd7e8ec2e@redhat.com> From: Yongji Xie Date: Tue, 22 Jun 2021 16:14:53 +0800 Message-ID: Subject: Re: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace To: Jason Wang Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Dan Carpenter , joro@8bytes.org, Greg KH , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 3:50 PM Jason Wang wrote: > > > =E5=9C=A8 2021/6/22 =E4=B8=8B=E5=8D=883:22, Yongji Xie =E5=86=99=E9=81=93= : > >> We need fix a way to propagate the error to the userspace. > >> > >> E.g if we want to stop the deivce, we will delay the status reset unti= l > >> we get respose from the userspace? > >> > > I didn't get how to delay the status reset. And should it be a DoS > > that we want to fix if the userspace doesn't give a response forever? > > > You're right. So let's make set_status() can fail first, then propagate > its failure via VHOST_VDPA_SET_STATUS. > OK. So we only need to propagate the failure in the vhost-vdpa case, right? Thanks, Yongji