Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4653207pxj; Tue, 22 Jun 2021 05:14:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXN2xNu6JLIaZ5QylSPB4cxbEDBz9WQWKgf1MJGUK87z7my+wCTGQw3/HviOd4wG+FKgCy X-Received: by 2002:a05:6e02:20e8:: with SMTP id q8mr2460561ilv.84.1624364092018; Tue, 22 Jun 2021 05:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624364092; cv=none; d=google.com; s=arc-20160816; b=lUwfwJZb1g6y4fH43Gb+ij/D7dCKMAEP+gUTiiNVQTAvpgLh8+kFx+nXOFYcSDCfxr IWmIfER8yrKSpESWzZbMH11DwFBVXIJFKw4ya3G/ub+vvwVLw3ggAZsp+Kr99wwwvOxS q5r64MIbOC9K9PgMAq/3H+jHOkqD+8ceB60CFF4w4PUI4QqdwKq9EVpYpHP7Xfa5My/1 LHxSSupg74GtY/Yb/GFsi8wb3IRfTO1P8WUgROhchPkxsddSIc4OEvCsow0QaKXQ8cwy yM60GYewDcQmmnykMBdL/ZdnV4mH8rhSEyjz6Vxi7kPtPQHnoZuQQ/nqf3N2EbTOBsJi /UNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LT13jFHeh4LTP9zE1+qKjJtIwv0pd0oBJbwT/TZVyeA=; b=Yxf+w7yeMqZCTrxVnwvvr75TpMdLaSRu31akEjgEwWfDcgoQ7ZVFVtqjJbLj4TEkye 2dabbvKuQOjm2mGas7tBIpvDsYfoAdELS4Ry4n5f/3KgpAC518lnkFThLrgBkwQ+W65Y K+hmU0mdYG5sBq93qdHrqoMl9QouT4332/oYRR9jHNqgwut3AnpgKcageyH0evK68Xua G6Ssm1MEQwB5rhbPEft5NRM1rY0T7fQ0k8J+SDeIAL0L7+p2m90/mCjfRqapQueDnGYL 2upF9/umToTZ4E5yIVM1W+es2pwerbcnWNvJJyF/oAFF6tb0j0pTcaD4JBzeuVXknwWK sMlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=DVQUvpSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si16289140ilu.151.2021.06.22.05.14.39; Tue, 22 Jun 2021 05:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=DVQUvpSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhFVMQZ (ORCPT + 99 others); Tue, 22 Jun 2021 08:16:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbhFVMQY (ORCPT ); Tue, 22 Jun 2021 08:16:24 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426BEC061574 for ; Tue, 22 Jun 2021 05:14:08 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id r7so15802043qta.12 for ; Tue, 22 Jun 2021 05:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LT13jFHeh4LTP9zE1+qKjJtIwv0pd0oBJbwT/TZVyeA=; b=DVQUvpScWMPfa8jzOm5GJInZHiXCte3+7wziG++Cbt2SXo6S0kC7qZ5S2R19Ku6N+A +vcesmQHxhqQ+ddNmTWS3xBsTMne9dSIRGwCC3dwN6DCWpPomjcFHHQZYfPfiz/U/fEN BcsFGVCk1nuYt6OvtcPkLFwavtC2bLEKzsVU0amWt0xsa55b68zHXTNFL1KkUDzWmotu KG8+rBgFVndL+pzoViTAulSH2ukV7ozmJvV+rEBk3tEt2BUB0neZ+u78kUkjzPj/SZdO /KrnU8ojE8AnXCeGbewGbvTKu7mNHlbniKbHuoKMydoFIv4PWU5cJ6qKHZhm45zyssZM wL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LT13jFHeh4LTP9zE1+qKjJtIwv0pd0oBJbwT/TZVyeA=; b=rqN9S65p13ixTq1du7OFL8mSIPUCYy242mVdnLCFUj2wypuMikf4XQLz5pC7cwAubK WqDuKyR7te4411cowoERoomq1VTvTF6hXIBVLPHj9h1KFA5X+QnxIqRMbaCVS/QhleX7 ntUklgdaxtI3MVF98/mEgzWwCu6Nf/vsBb9G6X3+TuC3v+lGQ/Nco9TU8sZ3n269Lq5I 5VUtP4P3Rp0rHiPSC8iRXn7XPlfffzrvEpPWXcfNGTPwze+7ZNXFa437ZWOtleqvLr2z DUiDZvvMbbktrLHYfkd+vFhDsLKlTr//61XQhsBTVT4ajo7kf+R0ZuU8l2F4AwnvTZi0 9W3g== X-Gm-Message-State: AOAM5316SAB7D9Wj/IkhSxRS0hZzywr9wovJESGvmiZ08eNzNj9hH7Pn VVMNQalSjgfejUUYMnF3MUmHTg== X-Received: by 2002:ac8:464c:: with SMTP id f12mr3175896qto.303.1624364047367; Tue, 22 Jun 2021 05:14:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-113-94.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.113.94]) by smtp.gmail.com with ESMTPSA id c16sm1395182qtd.46.2021.06.22.05.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 05:14:07 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lvfI6-00A9az-EY; Tue, 22 Jun 2021 09:14:06 -0300 Date: Tue, 22 Jun 2021 09:14:06 -0300 From: Jason Gunthorpe To: ira.weiny@intel.com Cc: Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Faisal Latif , Shiraz Saleem , Bernard Metzler , Kamal Heib , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] RDMA/i40iw: Remove use of kmap() Message-ID: <20210622121406.GM1096940@ziepe.ca> References: <20210622061422.2633501-1-ira.weiny@intel.com> <20210622061422.2633501-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622061422.2633501-3-ira.weiny@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 11:14:20PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and will break uses of device dax after PKS > protection is introduced.[1] > > The kmap() used in the i40iw CM driver is thread local. Therefore > kmap_local_page() sufficient to use and may provide performance benefits > as well. kmap_local_page() will work with device dax and pgmap > protected pages. > > Use kmap_local_page() instead of kmap(). > > [1] https://lore.kernel.org/lkml/20201009195033.3208459-59-ira.weiny@intel.com/ > > Signed-off-by: Ira Weiny > --- > drivers/infiniband/hw/i40iw/i40iw_cm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) This needs to be resent against irdma instead Jason