Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 01/17] staging: rtl8723bs: remove all 5Ghz network
 types
From:   Hans de Goede <hdegoede@redhat.com>
To:     Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc:     Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <cover.1624364582.git.fabioaiuto83@gmail.com>
 <96b241e97e425a3115305b3d6658037e1e4c862c.1624364582.git.fabioaiuto83@gmail.com>
 <56ec67b9-a4a3-48ec-efe0-493ddc30365d@redhat.com>
Message-ID: <5af94a0d-af54-818f-d2ae-62f099db3dea@redhat.com>
Date:   Tue, 22 Jun 2021 14:41:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <56ec67b9-a4a3-48ec-efe0-493ddc30365d@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/22/21 2:41 PM, Hans de Goede wrote:
> Hi,
> 
> On 6/22/21 2:29 PM, Fabio Aiuto wrote:
>> remove all 5Ghz network types. rtl8723bs works on
>> 802.11bgn standards and on 2.4Ghz band.
>>
>> So remove all code related to 802.11a and 802.11ac
>> standards, which the device doesn't support.
>>
>> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
>> ---
>>  drivers/staging/rtl8723bs/core/rtw_ap.c       | 10 +---
>>  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 22 ++------
>>  drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 ----
>>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 55 -------------------
>>  .../staging/rtl8723bs/core/rtw_wlan_util.c    | 14 +----
>>  drivers/staging/rtl8723bs/hal/odm.c           | 30 ----------
>>  drivers/staging/rtl8723bs/hal/odm.h           |  3 -
>>  .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |  4 +-
>>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  5 --
>>  drivers/staging/rtl8723bs/include/hal_phy.h   |  3 -
>>  drivers/staging/rtl8723bs/include/ieee80211.h | 22 +-------
>>  drivers/staging/rtl8723bs/include/wifi.h      |  1 -
>>  drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  2 +-
>>  13 files changed, 14 insertions(+), 167 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> index 23bbdf084631..b0abadd4b4dd 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> @@ -343,10 +343,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
>>  
>>  	if (pcur_network->Configuration.DSConfig > 14) {
>>  		if (tx_ra_bitmap & 0xffff000)
>> -			sta_band |= WIRELESS_11_5N;
>> -
>> -		if (tx_ra_bitmap & 0xff0)
>> -			sta_band |= WIRELESS_11A;
>> +			sta_band |= WIRELESS_INVALID;
> 
> sta_band will now not be touched if tx_ra_bitmap is say 0x20, where as
> before it would be ore-d with WIRELESS_11A. Please make the or-ing with
> WIRELESS_INVALID unconditional (removing both "if (tx_ra_bitmap & 0x...)"
> checks). Also make sure to reduce the indentation level of the
> sta_band |= WIRELESS_INVALID; by 1 tab when dropping the if.

p.s.

The rest of the set looks ok to me.

Regards,

Hans