Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Jun 2021 13:50:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Philipp Zabel <p.zabel@pengutronix.de>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        Support Opensource <support.opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: da9052: Simplify checking DVC controlled
 regulators
Message-ID: <20210622125024.GC4574@sirena.org.uk>
References: <20210618141412.4014912-1-axel.lin@ingics.com>
 <20210618141412.4014912-2-axel.lin@ingics.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="m51xatjYGsM+13rf"
Content-Disposition: inline
In-Reply-To: <20210618141412.4014912-2-axel.lin@ingics.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--m51xatjYGsM+13rf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 18, 2021 at 10:14:12PM +0800, Axel Lin wrote:

> Only DVC controlled regulators have activate_bit set, so just check
> activate_bit we can know if the regulator is DVC controlled.

This feels a bit icky - what if the activate_bit for some variant were
bit 0?  I'm not sure we're likely to see new variants but even so the
fact that 0 is a potentially valid value for the bit feels wrong.

--m51xatjYGsM+13rf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDR3JAACgkQJNaLcl1U
h9B1fAf/ZzA7ucWP1tj3V1aeaRcIuo7Z6/5wu9swp0/58zXaLwywwW5v5y3aBkve
qDliFTfe+vE8G0EJaXMt6u69fFqhhJcCvU/eZciw9f3Tq7adLWH7+3PneLBWcxir
XN0DUE9LIZOCpxBj1ETPDeTBsWF0owekbxiWg138PZGcQ/4DO7dq21BwhzrVHhc+
bRutgvkojpjwp9RGCLo4BvflQQLSm65bpTbPjklohLctqwxpbQavR6PGOlqFXNYB
qS8sak/dKEnsrP4GK3DSnTS4DckAOZFWYoZ90eqR8JbqgxS4lgDt+SGLnJhysp1N
UfS5MB9c+nGqDUfzUNHqpGx8lZXlwA==
=deo4
-----END PGP SIGNATURE-----

--m51xatjYGsM+13rf--