Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4697772pxj; Tue, 22 Jun 2021 06:12:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk8X5qtfG0ORBqwOJp9VxKOMHNje68ORsyQwoLIOU/9sZvdxQczoFkt7Ifw/VAmy/GRGqd X-Received: by 2002:a05:6602:21d2:: with SMTP id c18mr2897519ioc.7.1624367558700; Tue, 22 Jun 2021 06:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624367558; cv=none; d=google.com; s=arc-20160816; b=YMEKzgSHwrbMo3KDAvyV1Cz752ioFn6f7WO6wL6i/RbO1HP9vl+iKPP1nd+DlEj0/T 7MIXG9dzbzRGuxec3m18vCvbbQFkDy9haxwlkAndvabHMKXcNSoFGSMs7w6fclkFJ5fm JbTrLFiUmBucMPgMyBSzK6MzLv3AtIJ83ALZ54sI7ZOqlZSFpYmfIHV+DaRMihR9F2IN 2616fxxLAQqHar+5JBR/Icz64yLtzUZjJbkc9aVeBMFk1HQDzl7Rkw4/zRKC1iaaUDBW uPHwfVqvg4VPRV52Rn4gz0sXIdjvPWFjNw+BwXYmDFnqhyhYoTGjZHtjw6SJoU99Wacu Haag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gNOemOTras9F985BUt7jkfUSz/FQKfSLHckmy+4u2+Q=; b=tmWuJbLEaGv/qjnzEpoTVBS79dELgwQyFKw3P9hQFVXorbPM/MhOdoyvBsCvCm6hBW qbolndMvfKzuU69WxI1xyx46T4tInLTwJfuPfebxeCLPTIuNXkFEHm5nAX9UM8yMaszK OhFtbnqel08rNY/CMA4xPOZa0vjstT/LKIqqwbMg+s4mmojPVot6AW3v0HRnkqcCq+6x Ursu4q4oWY8xFLKzoMEdpNa6EiGR5j2ow1QNubPNnNzdxzqn2ca3Q8q47IMMCX3+VkeG MCCBQY0VnSVO9hygPScjaewidLvUXyLF498VCOmME4K8+2C3kd34s/Ul7cNYBjpgZYJC t0Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r8zjWNsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v41si24456222jal.19.2021.06.22.06.12.22; Tue, 22 Jun 2021 06:12:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r8zjWNsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbhFVNNd (ORCPT + 99 others); Tue, 22 Jun 2021 09:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbhFVNMo (ORCPT ); Tue, 22 Jun 2021 09:12:44 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0008C0613A4 for ; Tue, 22 Jun 2021 06:10:28 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id h21-20020a1ccc150000b02901d4d33c5ca0so2222200wmb.3 for ; Tue, 22 Jun 2021 06:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gNOemOTras9F985BUt7jkfUSz/FQKfSLHckmy+4u2+Q=; b=r8zjWNsHJfYUG4XaG7ALHwWZMS/mKG9J1P3WEpUSGpX5FACY+XGFb3AEYmdK5jgmAD u/NvpBC5WHno0T3q4+LtfD8Qo7NVyS8dzEgtxqOhgOLwetITuqPKS4B+pUv5PRMaPpd3 fPwjXVy0j9weYjUHE2IIkePjkQba2DtbXzWNo/84NDJ2BNqvsGfwGUBsy0eV0613iGKV FT/GfRTxIcaDu6fgOojFdoUMEgPSxVAxpS38PHfRMy4QoUtsoY4ZonIRN+861DdgYRUD kj8UJQoTqlWpDHBd0N6C7//4N08iPRYJCa1Nq+GYKFgY078nqARmdfIhGEoiqZId3Q7S x6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gNOemOTras9F985BUt7jkfUSz/FQKfSLHckmy+4u2+Q=; b=bigJ9VnGQH0SISQsX0SLFkt2Wd7koaMSbQ6PoKqCDlnwkVkUv7Mt80U8k6g+DFeMmo reA2mmVDPSw9ktDrLMwiyaVYdOWDX105kQFQrw1g3MaYLhn0tIg9k1i7cMMA9IzarDxG ebjWqGHdNiib0Mw1Ahlak3gAEwAHxVT8TJTT4GGiYUqQ5S2QiIPiqKBA9Nf90iSu89Qq ll+hfZ+wp3Dz5ArmYTmiwsVUmydv47L9EBaO2P0RxjI82nHz14WT0Qi6er8zk47nNAp6 qQml75mtgE7GNjpzs1TFFnsKE+5TfX/+iOTnSIU2tsSkwWZXm35A+7U5vvr3Yhv0spaV ksig== X-Gm-Message-State: AOAM5334BoJFcRWLSdPv+Kv4xaVYKpoYn6KZIOEbYng13HC+sAXkrB8f rTA/fGcz9dvszalrFtj14Zg7+pCwrjvH5Q== X-Received: by 2002:a05:600c:354d:: with SMTP id i13mr4253325wmq.67.1624367427221; Tue, 22 Jun 2021 06:10:27 -0700 (PDT) Received: from agape ([5.171.73.108]) by smtp.gmail.com with ESMTPSA id e3sm11234726wro.26.2021.06.22.06.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 06:10:27 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 16/17] staging: rtl8723bs: fix check allowing 5Ghz settings Date: Tue, 22 Jun 2021 15:10:00 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix check allowing 5Ghz settings, only disabled and 2.4Ghz enabled states are allowed. Fix comment accordingly. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index afefc2c8a2ac..e73fb13f8968 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2572,10 +2572,9 @@ static int rtw_dbg_port(struct net_device *dev, case 0x12: /* set rx_stbc */ { struct registry_priv *pregpriv = &padapter->registrypriv; - /* 0: disable, bit(0):enable 2.4g, bit(1):enable 5g, 0x3: enable both 2.4g and 5g */ - /* default is set to enable 2.4GHZ for IOT issue with bufflao's AP at 5GHZ */ - if (extra_arg == 0 || extra_arg == 1 || - extra_arg == 2 || extra_arg == 3) + /* 0: disable, bit(0):enable 2.4g */ + /* default is set to enable 2.4GHZ */ + if (extra_arg == 0 || extra_arg == 1) pregpriv->rx_stbc = extra_arg; } break; -- 2.20.1