Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946764AbWKJQVK (ORCPT ); Fri, 10 Nov 2006 11:21:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946761AbWKJQVK (ORCPT ); Fri, 10 Nov 2006 11:21:10 -0500 Received: from brick.kernel.dk ([62.242.22.158]:1806 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S1946755AbWKJQVH (ORCPT ); Fri, 10 Nov 2006 11:21:07 -0500 Date: Fri, 10 Nov 2006 17:23:30 +0100 From: Jens Axboe To: Brice Goglin Cc: Monty Montgomery , Tejun Heo , Gregor Jasny , Linux Kernel , Jeff Garzik , linux-ide@vger.kernel.org, Douglas Gilbert Subject: Re: 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO) Message-ID: <20061110162330.GE15031@kernel.dk> References: <9d2cd630610291120l3f1b8053i5337cf3a97ba6ff0@mail.gmail.com> <20061030114503.GW4563@kernel.dk> <9d2cd630610300517q5187043eieb0880047ddd03eb@mail.gmail.com> <20061030132745.GE4563@kernel.dk> <4552F905.3020109@ens-lyon.org> <45533468.1060400@gmail.com> <806dafc20611091209s5864c9eam77a9290194de343d@mail.gmail.com> <20061110161510.GC15031@kernel.dk> <4554A681.2000502@ens-lyon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4554A681.2000502@ens-lyon.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 35 On Fri, Nov 10 2006, Brice Goglin wrote: > Jens Axboe wrote: > > On Thu, Nov 09 2006, Monty Montgomery wrote: > > > >> On 11/9/06, Tejun Heo wrote: > >> > >> > >>> drivers/scsi/sg.c interprets SG_DXFER_TO_FROM_DEV as read while > >>> block/scsi_ioctl.c interprets it as write. I guess this is historic > >>> thing (scsi/sg.c updated but block/scsi_ioctl.c is forgotten). > >>> > >> Not historic; Jens accidentally implemented it backwards. No one > >> noticed for a long time. I submitted a patch for this a few months > >> ago. > >> > > > > Yeah, I wonder why that did not go in, I remember the full breadth of > > our discussion and you are fully correct. I'll make sure it gets into > > 2.6.19! > > > > Note sure this patch was supposed to fix our freeze, but I just tried on > top of rc5 and it does not seem to fix it. It should fix Alex's issue with wrong data direction being seen, I haven't had time to follow this thread today so cannot say. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/