Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Jun 2021 21:51:19 +0800
From:   =?UTF-8?B?5ZGo55Cw5p2w?= <zhouyanjie@wanyeetech.com>
To:     Paul Cercueil <paul@opendingux.net>
Cc:     tsbogend@alpha.franken.de, robh+dt@kernel.org,
        linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dongsheng.qiu@ingenic.com,
        aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
        sihui.liu@ingenic.com, jun.jiang@ingenic.com,
        sernia.zhou@foxmail.com
Subject: Re: [PATCH 3/4] MIPS: GCW0: Adjust pinctrl related code in device
 tree.
Message-ID: <20210622215119.18a49cf9@zhouyanjie-virtual-machine>
In-Reply-To: <9US3VQ.SK89X0OFZC2Z2@opendingux.net>
References: <1624347445-88070-1-git-send-email-zhouyanjie@wanyeetech.com>
        <1624347445-88070-4-git-send-email-zhouyanjie@wanyeetech.com>
        <9US3VQ.SK89X0OFZC2Z2@opendingux.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Paul,

于 Tue, 22 Jun 2021 13:46:57 +0100
Paul Cercueil <paul@opendingux.net> 写道:

> Hi Zhou,
> 
> Le mar., juin 22 2021 at 15:37:24 +0800, 周琰杰 (Zhou Yanjie) 
> <zhouyanjie@wanyeetech.com> a écrit :
> > Change the "lcd-24bit" in the pinctrl groups to "lcd-8bit",
> > "lcd-16bit", "lcd-18bit", "lcd-24bit", since the pinctrl
> > driver has done the necessary splitting of the lcd group,
> > and it is convenient to further streamline the lcd-24bit
> > group in the subsequent pinctrl driver.
> > 
> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > ---
> >  arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts 
> > b/arch/mips/boot/dts/ingenic/gcw0.dts
> > index f4c04f2..dec3ba6f 100644
> > --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> > +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> > @@ -393,7 +393,7 @@
> >  &pinctrl {
> >  	pins_lcd: lcd {
> >  		function = "lcd";
> > -		groups = "lcd-24bit";
> > +		groups = "lcd-8bit", "lcd-16bit", "lcd-18bit",
> > "lcd-24bit";  
> 
> No, I'm pretty sure this won't work, since "lcd-24bit" contains pins 
> that are also contained by the other groups.
> 

Sure, it seems that we should modify the pinctrl first, then modify the
dts, and then put them in the same series, so as to ensure that they do
not cause damage.

Thanks and best regards!

> -Paul
> 
> >  	};
> > 
> >  	pins_uart2: uart2 {
> > --
> > 2.7.4
> >   
>