Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4800538pxj; Tue, 22 Jun 2021 08:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhyyhepphxEnSNrDH7sxDoCZRwLPvPFq/KPksFCTAs1D7G0AYpDAUgxduyTZOniugOwuzI X-Received: by 2002:a17:906:474e:: with SMTP id j14mr4644777ejs.9.1624375072068; Tue, 22 Jun 2021 08:17:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624375072; cv=none; d=google.com; s=arc-20160816; b=ncAAqdlRFRtlXtu2dawTGkfPEIHTeZKtqMRlrBBL2kQLTY9CyOc3MFBWS1ucGR+OY4 a/YiJGFHfyh4DD7UpYQljUrwJVVguwGNc+hlwG2y/kjxrW0z4r3BZmIatVfgkjv+fVG+ St7vz7yLOLkdPyyQOLJbV55EVkdpB7WXDJpvTmyhfvaXVUVXwK83eYB/2e5zh/Yobpae NYH0mYtOgEh/r9aFs+XiiyAmNASIua9fxp3s5rwt+OeaIGS3BXzImraOjR4GtpmuTj7k 01la6HJOLB/6NRKo3Gqh5lc/ODBZIxD6M8x0aIk2pcwfxas05YTNj+9mg9vY/hvXGzBP RRjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :dkim-signature; bh=2/ON+NfgYqKAIMgYQmTDPsmxKkiGS3qSwNNgrMI4ut0=; b=RwgRBciohHecbcAn/UzETVKhx5Qfx3Xmq870YRk8acYYeXH7xP5v64CVDj1aTJbKO/ yLrVLpK2D+G2sc5+kmSJiyRboJxSDAQA7JHcUTdSr5mbvjkytoIXFXUGVFihqOcYvGiY 026BYzs25EOQ1UCfsh3JLYMfgEyrlz+dn6t0eElgT1m0jxYxGE8QyUo3cRVR9mjIUL8H CKZZRal6idoL11/NdGPepzvZY4MvzyDcYeh0b8l/aIvEfJ33jbFcCeeyRgz67lkeHuv4 2YEfTvUb3HfwOsEApxlW8wrMi+sV9Oh87TNHXiAOC06meg9aN+V/GsK3FPl7GEsf7nyV lXiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MDBvo4yq; dkim=pass header.i=@suse.com header.s=susede1 header.b=MDBvo4yq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id my4si14215733ejc.337.2021.06.22.08.17.27; Tue, 22 Jun 2021 08:17:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MDBvo4yq; dkim=pass header.i=@suse.com header.s=susede1 header.b=MDBvo4yq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232206AbhFVPRN (ORCPT + 99 others); Tue, 22 Jun 2021 11:17:13 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:44340 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232177AbhFVPRH (ORCPT ); Tue, 22 Jun 2021 11:17:07 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F08061FD36; Tue, 22 Jun 2021 15:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624374889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2/ON+NfgYqKAIMgYQmTDPsmxKkiGS3qSwNNgrMI4ut0=; b=MDBvo4yqAImjsv9U+ttGl3hiLmvCTq5/CqD+BWdSSD3GRhIiz6N9m1qrPqAbpTb1fuBXkh x919OSDfn/KtVrJlq5pyejjy7W5wqxVfZwyCpbH/YLVRHX2BxQIsslysf7u3K2lRtg5ska 5OfYY+I9ntovLPpei6nS7vlDCzHBiUg= Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id B4EF9118DD; Tue, 22 Jun 2021 15:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624374889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2/ON+NfgYqKAIMgYQmTDPsmxKkiGS3qSwNNgrMI4ut0=; b=MDBvo4yqAImjsv9U+ttGl3hiLmvCTq5/CqD+BWdSSD3GRhIiz6N9m1qrPqAbpTb1fuBXkh x919OSDfn/KtVrJlq5pyejjy7W5wqxVfZwyCpbH/YLVRHX2BxQIsslysf7u3K2lRtg5ska 5OfYY+I9ntovLPpei6nS7vlDCzHBiUg= Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id dSDtKmn+0WCbdwAALh3uQQ (envelope-from ); Tue, 22 Jun 2021 15:14:49 +0000 Subject: Re: Interrupt for port 19, but apparently not enabled; per-user 000000004af23acc To: Julien Grall Cc: "xen-devel@lists.xenproject.org" , linux-kernel@vger.kernel.org, mheyne@amazon.de References: <6552fc66-ba19-2c77-7928-b0272d3e1622@xen.org> <4d8a7ba7-a9f6-2999-8750-bfe2b85f064e@suse.com> <9a08bbf2-ba6a-6e49-3bcb-bfe2beb32b99@xen.org> From: Juergen Gross Message-ID: <5d88a82e-d237-7803-7b50-897e857f2fbd@suse.com> Date: Tue, 22 Jun 2021 17:14:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <9a08bbf2-ba6a-6e49-3bcb-bfe2beb32b99@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s2NUokYSTqiR8e9giFHRsLXUh4hQPOnGN" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s2NUokYSTqiR8e9giFHRsLXUh4hQPOnGN Content-Type: multipart/mixed; boundary="hDCgbE4sBykbQxxgwMdSjlnRJltYZjgyU"; protected-headers="v1" From: Juergen Gross To: Julien Grall Cc: "xen-devel@lists.xenproject.org" , linux-kernel@vger.kernel.org, mheyne@amazon.de Message-ID: <5d88a82e-d237-7803-7b50-897e857f2fbd@suse.com> Subject: Re: Interrupt for port 19, but apparently not enabled; per-user 000000004af23acc References: <6552fc66-ba19-2c77-7928-b0272d3e1622@xen.org> <4d8a7ba7-a9f6-2999-8750-bfe2b85f064e@suse.com> <9a08bbf2-ba6a-6e49-3bcb-bfe2beb32b99@xen.org> In-Reply-To: <9a08bbf2-ba6a-6e49-3bcb-bfe2beb32b99@xen.org> --hDCgbE4sBykbQxxgwMdSjlnRJltYZjgyU Content-Type: multipart/mixed; boundary="------------BAC75389B48160B12DD27824" Content-Language: en-US This is a multi-part message in MIME format. --------------BAC75389B48160B12DD27824 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 22.06.21 14:21, Julien Grall wrote: > Hi Juergen, >=20 > On 22/06/2021 13:04, Juergen Gross wrote: >> On 22.06.21 12:24, Julien Grall wrote: >>> Hi Juergen, >>> >>> As discussed on IRC yesterday, we noticed a couple of splat in 5.13-r= c6=20 >> >>> (and stable 5.4) in the evtchn driver: >>> >>> [=C2=A0=C2=A0=C2=A0 7.581000] ------------[ cut here ]------------ >>> [=C2=A0=C2=A0=C2=A0 7.581899] Interrupt for port 19, but apparently n= ot=20 >> enabled; >>> per-user 000000004af23acc >>> [=C2=A0=C2=A0=C2=A0 7.583401] WARNING: CPU: 0 PID: 467 at=20 >>> /home/ANT.AMAZON.COM/jgrall/works/oss/linux/drivers/xen/evtchn.c:169 = >>> evtchn_interrupt+0xd5/0x100 >>> [=C2=A0=C2=A0=C2=A0 7.585583] Modules linked in: >>> [=C2=A0=C2=A0=C2=A0 7.586188] CPU: 0 PID: 467 Comm: xenstore-read Not=20 tainted=20 >>> 5.13.0-rc6 #240 >>> [=C2=A0=C2=A0=C2=A0 7.587462] Hardware name: QEMU Standard PC (Q35 + = ICH9, 2009),=20 >>> BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 >>> [=C2=A0=C2=A0=C2=A0 7.589462] RIP: e030:evtchn_interrupt+0xd5/0x100 >>> [=C2=A0=C2=A0=C2=A0 7.590361] Code: 48 8d bb d8 01 00 00 ba 01 00 00 = 00=20 >> be 1d 00 00 00 >>> e8 5f 72 c4 ff eb b2 8b 75 20 48 89 da 48 c7 c7 a8 03 5f 82 e8 6b 2d = 96=20 >> >>> ff <0f> 0b e9 4d ff ff ff 41 0f b6 f4 48 c7 c7 80 da a2 82 e8 f0 >>> [=C2=A0=C2=A0=C2=A0 7.593662] RSP: e02b:ffffc90040003e60 EFLAGS: 0001= 0082 >>> [=C2=A0=C2=A0=C2=A0 7.594636] RAX: 0000000000000000 RBX: ffff88810232= 8c00 RCX:=20 >>> 0000000000000027 >>> [=C2=A0=C2=A0=C2=A0 7.595924] RDX: 0000000000000000 RSI: ffff88817fe1= 8ad0 RDI:=20 >>> ffff88817fe18ad8 >>> [=C2=A0=C2=A0=C2=A0 7.597216] RBP: ffff888108ef8140 R08: 000000000000= 0000 R09:=20 >>> 0000000000000001 >>> [=C2=A0=C2=A0=C2=A0 7.598522] R10: 0000000000000000 R11: 707572726574= 6e49 R12:=20 >>> 0000000000000000 >>> [=C2=A0=C2=A0=C2=A0 7.599810] R13: ffffc90040003ec4 R14: ffff8881001b= 8000 R15:=20 >>> ffff888109b36f80 >>> [=C2=A0=C2=A0=C2=A0 7.601113] FS:=C2=A0 0000000000000000(0000) GS:fff= f88817fe00000(0000)=20 >>> knlGS:0000000000000000 >>> [=C2=A0=C2=A0=C2=A0 7.602570] CS:=C2=A0 10000e030 DS: 0000 ES: 0000 C= R0:0000000080050033 >>> [=C2=A0=C2=A0=C2=A0 7.603700] CR2: 00007f15b390e368 CR3: 000000010bb0= 4000 CR4:=20 >>> 0000000000050660 >>> [=C2=A0=C2=A0=C2=A0 7.604993] Call Trace: >>> [=C2=A0=C2=A0=C2=A0 7.605501]=C2=A0 >>> [=C2=A0=C2=A0=C2=A0 7.605929]=C2=A0 __handle_irq_event_percpu+0x4c/0x= 330 >>> [=C2=A0=C2=A0=C2=A0 7.606817]=C2=A0 handle_irq_event_percpu+0x32/0xa0= >>> [=C2=A0=C2=A0=C2=A0 7.607670]=C2=A0 handle_irq_event+0x3a/0x60 >>> [=C2=A0=C2=A0=C2=A0 7.608416]=C2=A0 handle_edge_irq+0x9b/0x1f0 >>> [=C2=A0=C2=A0=C2=A0 7.609154]=C2=A0 generic_handle_irq+0x4f/0x60 >>> [=C2=A0=C2=A0=C2=A0 7.609918]=C2=A0 __evtchn_fifo_handle_events+0x195= /0x3a0 >>> [=C2=A0=C2=A0=C2=A0 7.610864]=C2=A0 __xen_evtchn_do_upcall+0x66/0xb0 >>> [=C2=A0=C2=A0=C2=A0 7.611693]=C2=A0 __xen_pv_evtchn_do_upcall+0x1d/0x= 30 >>> [=C2=A0=C2=A0=C2=A0 7.612582]=C2=A0 xen_pv_evtchn_do_upcall+0x9d/0xc0= >>> [=C2=A0=C2=A0=C2=A0 7.613439]=C2=A0 >>> [=C2=A0=C2=A0=C2=A0 7.613882]=C2=A0 exc_xen_hypervisor_callback+0x8/0= x10 >>> >>> This is quite similar to the problem I reported a few months ago (see=20 >>> [1]) but this time this is happening with fifo rather than 2L. >>> >>> I haven't been able to reproduced it reliably so far. But looking at = >>> the code, I think I have found another potential race after commit >>> >>> commit b6622798bc50b625a1e62f82c7190df40c1f5b21 >>> Author: Juergen Gross >>> Date:=C2=A0=C2=A0 Sat Mar 6 17:18:33 2021 +0100 >>> =C2=A0=C2=A0=C2=A0 xen/events: avoid handling the same event on two c= pusat the same=20 >>> time >>> =C2=A0=C2=A0=C2=A0 When changing the cpu affinity of an event it can = happen today that >>> =C2=A0=C2=A0=C2=A0 (with some unlucky timing) the same event will be = handled=20 >> on the old >>> =C2=A0=C2=A0=C2=A0 and the new cpu at the same time. >>> =C2=A0=C2=A0=C2=A0 Avoid that by adding an "event active" flag to the=20 per-event data=20 >>> and >>> =C2=A0=C2=A0=C2=A0 call the handler only if this flag isn't set. >>> =C2=A0=C2=A0=C2=A0 Cc: stable@vger.kernel.org >>> =C2=A0=C2=A0=C2=A0 Reported-by: Julien Grall >>> =C2=A0=C2=A0=C2=A0 Signed-off-by: Juergen Gross >>> =C2=A0=C2=A0=C2=A0 Reviewed-by: Julien Grall >>> =C2=A0=C2=A0=C2=A0 Link:=20 >>> https://lore.kernel.org/r/20210306161833.4552-4-jgross@suse.com >>> =C2=A0=C2=A0=C2=A0 Signed-off-by: Boris Ostrovsky >>> >>> The evtchn driver will use the lateeoi handlers. So the code to ack=20 >>> looks like: >>> >>> do_mask(..., EVT_MASK_REASON_EOI_PENDING) >>> smp_store_release(&info->is_active, 0); >>> clear_evtchn(info->evtchn); >>> >>> The code to handle an interrupts look like: >>> >>> clear_link(...) >>> if ( evtchn_fifo_is_pending(port) && !evtchn_fifo_is_mask()) { >>> =C2=A0=C2=A0 if (xchg_acquire(&info->is_active, 1) >>> =C2=A0=C2=A0=C2=A0=C2=A0 return; >>> =C2=A0=C2=A0 generic_handle_irq(); >>> } >>> >>> After changing the affinity, an interrupt may be received once on the=20 >>> previous vCPU. So, I think the following can happen: >>> >>> vCPU0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | vCPU1 >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0Receive event=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | change affinity to vCPU1 >>> =C2=A0=C2=A0clear_link()=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 /* The interrupt is re-raised */ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | receive event >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | /* The interrupt is not masked = */ >>> =C2=A0=C2=A0info->is_active =3D 1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0do_mask(...)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0info->is_active =3D 0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | info->is_active =3D 1 >>> =C2=A0=C2=A0clear_evtchn(...)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | do_mask(...) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | info->is_active = =3D 0 >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | clear_evtchn(...) >>> >>> Does this look plausible to you? >> >> Yes, it does. >> >> Thanks for the analysis. >> >> So I guess for lateeoi events we need to clear is_active only in >> xen_irq_lateeoi()? At a first glance this should fix the issue. >=20 > It should work and would be quite neat. But, I believe clear_evtchn()=20 > would have to stick in the ack helper to avoid losing interrupts. >=20 Could you try the attached patch, please? Only compile tested. Juergen --------------BAC75389B48160B12DD27824 Content-Type: text/x-patch; charset=UTF-8; name="0001-xen-events-reset-active-flag-for-lateeoi-events-late.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-xen-events-reset-active-flag-for-lateeoi-events-late.pa"; filename*1="tch" =46rom 593e81cfb5d4a15e5e420111565e7f6019da9b72 Mon Sep 17 00:00:00 2001 From: Juergen Gross To: linux-kernel@vger.kernel.org Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org Date: Tue, 22 Jun 2021 17:05:03 +0200 Subject: [PATCH] xen/events: reset active flag for lateeoi events later In order to avoid a race condition for user events when changing cpu affinity reset the active flag only when EOI-ing the event. This is working fine as all user events are lateeoi events. Reported-by: Julien Grall Fixes: b6622798bc50b62 ("xen/events: avoid handling the same event on two=20 cpus at the same time") Signed-off-by: Juergen Gross --- drivers/xen/events/events_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events= _base.c index 7bbfd58958bc..26836546e1cd 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -642,6 +642,7 @@ static void xen_irq_lateeoi_locked(struct irq_info *i= nfo, bool spurious) } =20 info->eoi_time =3D 0; + smp_store_release(&info->is_active, 0); do_unmask(info, EVT_MASK_REASON_EOI_PENDING); } =20 @@ -1883,7 +1884,7 @@ static void lateeoi_ack_dynirq(struct irq_data *dat= a) =20 if (VALID_EVTCHN(evtchn)) { do_mask(info, EVT_MASK_REASON_EOI_PENDING); - event_handler_exit(info); + clear_evtchn(evtchn); } } =20 --=20 2.26.2 --------------BAC75389B48160B12DD27824 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BAC75389B48160B12DD27824-- --hDCgbE4sBykbQxxgwMdSjlnRJltYZjgyU-- --s2NUokYSTqiR8e9giFHRsLXUh4hQPOnGN Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDR/mkFAwAAAAAACgkQsN6d1ii/Ey9h Mwf/dzQN4+BLw8AyejZW0UdiO/zHkz6xRDrTbZc9bHb9aRkP6JUoFdA3rbQpGFiBaIHDu+aHwzpt X8xdBz5YIRZ/+XySJSpOrCvir88EJJ/aydzYHFYzxvx7cMki0pVH+5H66J0WuOaMoucMn8IcWPvT S+xnoCvZQX9+xQc4FlVEQGM/iV4yKR8oKtaXjrKUaLd5zfcMrhaX6wdkQW6wBeRegHo+Q+TCazVc nzFzTY24VGBoSFJN3cKfg+3znN6zBrFzsTSKi4XeQn00B7QckEi4vscgYvRquSUXWgkwGEEemk63 /scvx4awB+n3mWkoF9ke+VeDRYJ9EqOEbsFHYSZGgw== =vvOW -----END PGP SIGNATURE----- --s2NUokYSTqiR8e9giFHRsLXUh4hQPOnGN--