Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4807105pxj; Tue, 22 Jun 2021 08:25:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoHMk5AznjXAlavmH2o1G+hPDI4TF8582qmfvudWTSq19ut74Gnmp5vwHPBwAGPiAMHSIj X-Received: by 2002:a92:2c02:: with SMTP id t2mr2939187ile.233.1624375552359; Tue, 22 Jun 2021 08:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624375552; cv=none; d=google.com; s=arc-20160816; b=0IB8Qc/TCbPVIxYTz6p27GhQlCplmIaiARZPBtaLi9a1JNeh9HYwLAkIsnUciGEkl9 u6etuJT98gckoux5YbLlOZi53BRk+0tc6VEfKzi9gWr97yyFZ1C8s6ftXzZcv3bXjS8B 01TA7+2Vl33+U7z+UZPvqIFFeNFGl55Q1EBdDkumBrKk3Bq8Mh66RVAtmKiP1dhN5xly /qEEGgW0PJaPOSZGae1ON3Yoo0HVpvU0V7mNDgiWymsYGObhQ1nfYepnYmf+evJAcv6U 2Q78a8biA0Qwn4BtJQPtD9OpnfQOamk1I+GikWLFrotZ8AKJ15/pKu3QliSxNhe9wVFr PNPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=QBiR2dvj4W5lDYRv8mZ1n6ge+cEkkiiBArMH1RJ+mC4=; b=XWxD8g54ORSWvogBvRm9nOVOnoA4pH04/lOe42CpPk768Yc4lvmG10LBw/PNSAPikZ IWdCl9PYvDZzkALB0Wei57092zd7393Gw700tklO206GqNttFvaK9vstSS3UBVnf4ixB oq8aqY+vA4dDxwxgdIH6habpH1ZEyMzOIkJYU1cGJKD92YjfGvKwokN3Dkd9uyStL2ZQ AkqW1Bn/JbnhSagWv/Qmepof5uONmfg+B7Eidx0WOCE3FJ+J5iKInUPjh16LRBNkK3yS DINN2DymlaOIO4YiM6Jusl5/LLQjhAoSzbnbhdm9aDqh5Nr0E5IOzpcdIOHdvtaGevu3 iKpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="xT/M6ILk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n17si24301355iod.6.2021.06.22.08.25.40; Tue, 22 Jun 2021 08:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="xT/M6ILk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232289AbhFVP1C (ORCPT + 99 others); Tue, 22 Jun 2021 11:27:02 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:13435 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbhFVP0y (ORCPT ); Tue, 22 Jun 2021 11:26:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624375479; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=QBiR2dvj4W5lDYRv8mZ1n6ge+cEkkiiBArMH1RJ+mC4=; b=xT/M6ILkLzT9O3SEkb/PUDAFabI2sqcUBDJ0C5LFz94qxRxEW8ADl6eBIzSSeb68y17+yvNh Ozt2jH/lmS0cpZBSttgXm16Z7h2HjAghF+TS2I3n/aGwGlbl7eZHVu47zFvbmeHSmk3zmkcz Z3cYsDGRQlyu2cyxC3ln7tNmdwg= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 60d2009b32b73d6b28258ae6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 22 Jun 2021 15:24:11 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 74439C43460; Tue, 22 Jun 2021 15:24:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 46588C43460; Tue, 22 Jun 2021 15:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 46588C43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] mwl8k: Avoid memcpy() over-reading of mcs.rx_mask From: Kalle Valo In-Reply-To: <20210617041431.2168953-1-keescook@chromium.org> References: <20210617041431.2168953-1-keescook@chromium.org> To: Kees Cook Cc: Andrew Lunn , Kees Cook , Lennert Buytenhek , "David S. Miller" , Jakub Kicinski , Romain Perier , Allen Pais , "Gustavo A. R. Silva" , Arnd Bergmann , wengjianfeng , Christophe JAILLET , Lv Yunlong , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210622152410.74439C43460@smtp.codeaurora.org> Date: Tue, 22 Jun 2021 15:24:10 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally reading across neighboring array fields. Use the > sub-structure address directly. > > Signed-off-by: Kees Cook Patch applied to wireless-drivers-next.git, thanks. 3f26f7665c5d mwl8k: Avoid memcpy() over-reading of mcs.rx_mask -- https://patchwork.kernel.org/project/linux-wireless/patch/20210617041431.2168953-1-keescook@chromium.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches