Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4849113pxj; Tue, 22 Jun 2021 09:19:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6hs++7l0pZixSR/Hh1KzVjgvhBVBnxWnxTDp0dvbTSw9pKpiN0GVO9NrKiqTg0rGgGtf0 X-Received: by 2002:a5d:8a07:: with SMTP id w7mr744934iod.154.1624378744506; Tue, 22 Jun 2021 09:19:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624378744; cv=none; d=google.com; s=arc-20160816; b=otphmql9aTKRxH3g9t3rWRs+PW3lNmTXlJpP+G7Fpb1GwZf5/t5jTUrAvRsyXWQb0e igLpP6It5O/5RtB1YKGQwg1G9XBkt+3oRb1UndtZWIZWOjIjQVTjbMp1+/j42SYLqY+4 vtORYsSHD67u32wnOyxy4sJvt4y6B2lst4ulK+J3OVOxjlz8Qd0+joiBmJPOVy5gJ0w/ JTLwnJIi4yfNylRyZMhCj7ernJu0FhVdq4rv95t6VDNyznbDtRX+u0k7dJfaM3ktUGFf zZVxMBdJ4dHNNbfHkLetgdt6/ROLijH7OJ4f8uspcb5/XlgdBKzZ7luAINE3dhjGN/p6 F1FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nMry3DVGmoR3cjUM7VvQ7ELEefC9hqcFQUgHEvMNKnI=; b=G0OqUZN2N+7gVC0sG+4KjIxA7z7rZKll9H8taKOhxbm8ulocYm7Ro1QRYnKQfQBnA+ YUFg5u8PR04MqM3/PkxR/9Ox6MGOO1devcbLdcCsiHJgnGo3rXb7wZ8uHYpTt6SZf+hH E8CphHqyQDP3Jb9YY/cHWU86Z/FDDumLWUhGQclWOQN/RKjnFVt7dSg60bjBzUAl+QWf 3+1LdBsSby0q4laKQFu3tBox5DiEP5Ve4b5qHEc3ahKZbWHanI3WtTP+FW+Su6CXBMYT jvoLOu7oKxa9PhVfeqDtXfS8gTZ65+FXXU9tEasC9AN/Ce9AToxBgviVGJIvEiNmL4bm hezA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si22363770iot.94.2021.06.22.09.18.50; Tue, 22 Jun 2021 09:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbhFVQUB (ORCPT + 99 others); Tue, 22 Jun 2021 12:20:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59249 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbhFVQUA (ORCPT ); Tue, 22 Jun 2021 12:20:00 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lvj5q-0006Bm-RA; Tue, 22 Jun 2021 16:17:42 +0000 From: Colin King To: Jens Axboe , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] block/mq-deadline: remove redundant assignment of variable ret Date: Tue, 22 Jun 2021 17:17:42 +0100 Message-Id: <20210622161742.25194-1-colin.king@canonical.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variable ret is being assigned a value at the end of the function and the value is never read. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- block/mq-deadline-main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mq-deadline-main.c b/block/mq-deadline-main.c index 4815e536091f..e3091d922ba2 100644 --- a/block/mq-deadline-main.c +++ b/block/mq-deadline-main.c @@ -639,7 +639,6 @@ static int dd_init_sched(struct request_queue *q, struct elevator_type *e) if (ret) goto free_stats; - ret = 0; q->elevator = eq; return 0; -- 2.31.1