Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4926824pxj; Tue, 22 Jun 2021 11:00:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgqa1ZwPt9w9JEq0a0F4tWUTdwgj3KPH7rNIhuz8m0S3LMLsXKPaenSqot8zqvOr3lAPWS X-Received: by 2002:a6b:7d05:: with SMTP id c5mr3816208ioq.148.1624384847005; Tue, 22 Jun 2021 11:00:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624384846; cv=none; d=google.com; s=arc-20160816; b=GUvm3/mJbQ0amNDep8tjOqffwhqNl6kYuNmPxIifcEk6taBxdSPX59x2cKCAbbVTfX 3S5mWu/wVRu75SJqcRUz+s6dHXRhOdxE+MZ4sYArv4hh8EZmgwzd1Ja4ZLrVgh3ugr/l U/vj9w4PposvM3EZobUT/5fc66wCHvDGRo3bLEbpdHJYN/rRJJQGvXQvWV86UpPQ49lh JbOhtKRjwd4w5sWy21fBddeUIHypBPFpn9D/d6ip6bgGVNoD1o2WK+hvs8cim7kewdun bn3e2KTtbhWJr9RKk89Uc9h7ZMd3UYIW36GR335XWDWqyVI5V+b7qiK57XojEcCcQWbE oE+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:dkim-signature; bh=1cuJlej5QtQVUgXaKXLCLupE2h8bZDvIvc+XU0Qy11c=; b=ibQonxIGAdn+JDQuqKf1ZRjRJtmqchMgJCy9EYuJfoy9EE7ZTCzj8Qhsr9XmEASa0c INUxnWpiYw1M1vDQk5qOxCB6iTYfjFFkox585CVnfO8llE/Sa8ptzZExRS2+06jiqinT bu8oVijFPct4wX04WXUE9YqyJfuPZhHqm5OVYKZe8Woi9fuPFI3CnUpazQmyi5atbLgw GemqInXtyU7ox7T/V+xTfhalTwv8fv0SSYmOln14emqfyntNWq4KjqPAGMUkCEQyB9f5 aUUVxGIaUL4xYcjial8OK412Iw+yZef2CjkaBYfNSnfdsn5s510V76lnkjPSErYRqiTX duMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="FO/N2ZK8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si23522611ion.58.2021.06.22.11.00.34; Tue, 22 Jun 2021 11:00:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="FO/N2ZK8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232539AbhFVSAj (ORCPT + 99 others); Tue, 22 Jun 2021 14:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232597AbhFVSAc (ORCPT ); Tue, 22 Jun 2021 14:00:32 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6107C0617AE for ; Tue, 22 Jun 2021 10:58:14 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id q10-20020a056214018ab029027751ec9742so4199871qvr.7 for ; Tue, 22 Jun 2021 10:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=1cuJlej5QtQVUgXaKXLCLupE2h8bZDvIvc+XU0Qy11c=; b=FO/N2ZK8XxpG8TPbM5BAoGiA8fcp0UzdbCojc3o0jFF0opgx7osqSDUuL8TqSRyToR 8Ii6cA+AWkjOR2SaGHv6qtWsiMp+4ypf0+uLoCdajMO7S+hnWs73H9+Kq7VLUOLue2OW cfDYenHu2qGY/Y5HsqFET/TTfrZHvTdsdBR5+ImhvxxEbzPEuXfeVY+agKdsxXyhrjCz 1Rb8dfXUM6auBfI/s/0BDyVaxlcgZr2AurtTVN3YehlxkF4rKBp5GjIhRseu9PMQf5DS 0NSVDRYKCYYwXqhh6DiA4kwHhxa13AvIp3xd/atAfqBRNMcWUhwuoVnLFEfoygkhJ3p5 FZ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=1cuJlej5QtQVUgXaKXLCLupE2h8bZDvIvc+XU0Qy11c=; b=M+Fsfh9VdtLBpjXHJp7tGgXoEfiixIyRbFSDuxFkUAhVHaFuHpl8evW/yzcGi4GMyu nrHlmWvlzvo5nV9+B+eooDo/uXuHQMP/HdIBrNtTo4aktNWQwOS3kTek74sqDhem9Ykq 1TuPybCUhaxf+9QL2FKS04PPeaHKJIYEzr7bbLkODxJDUF78mWBtXemkaoqn8VyLu/JC cJxJaXTKYotZDQKHV5QRYWeQPpEu+aKVB9PteDU5zUjdtqoIa2xqo7NcySGWeTcdsXDP 5LZKGYNizkk5XBxk4rF4iyRZfLWKkMupLShpFhra+XnN23dA+/5b4WYyoEBWMoeYX/e9 0dBg== X-Gm-Message-State: AOAM530AaGe6sYUW1DgnSzpXJGOT8Tem+L5Ff6B9GZn08yZMhUONltP/ xWDPSI+EVEt73GxXgT62txyxdZK3M/w= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:5722:92ce:361f:3832]) (user=seanjc job=sendgmr) by 2002:a05:6214:10e9:: with SMTP id q9mr27020191qvt.45.1624384693773; Tue, 22 Jun 2021 10:58:13 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 22 Jun 2021 10:56:53 -0700 In-Reply-To: <20210622175739.3610207-1-seanjc@google.com> Message-Id: <20210622175739.3610207-9-seanjc@google.com> Mime-Version: 1.0 References: <20210622175739.3610207-1-seanjc@google.com> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog Subject: [PATCH 08/54] Revert "KVM: MMU: record maximum physical address width in kvm_mmu_extended_role" From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop MAXPHYADDR from mmu_role now that all MMUs have their role invalidated after a CPUID update. Invalidating the role forces all MMUs to re-evaluate the guest's MAXPHYADDR, and the guest's MAXPHYADDR can only be changed only through a CPUID update. This reverts commit de3ccd26fafc707b09792d9b633c8b5b48865315. Cc: Yu Zhang Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/mmu/mmu.c | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 19c88b445ee0..cdaff399ed94 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -321,7 +321,6 @@ union kvm_mmu_extended_role { unsigned int cr4_smap:1; unsigned int cr4_smep:1; unsigned int cr4_la57:1; - unsigned int maxphyaddr:6; }; }; diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 8d97d21d5241..04cab330c445 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -4538,7 +4538,6 @@ static union kvm_mmu_extended_role kvm_calc_mmu_role_ext(struct kvm_vcpu *vcpu) ext.cr4_pse = !!is_pse(vcpu); ext.cr4_pke = !!kvm_read_cr4_bits(vcpu, X86_CR4_PKE); ext.cr4_la57 = !!kvm_read_cr4_bits(vcpu, X86_CR4_LA57); - ext.maxphyaddr = cpuid_maxphyaddr(vcpu); ext.valid = 1; -- 2.32.0.288.g62a8d224e6-goog