Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4929656pxj; Tue, 22 Jun 2021 11:03:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoY6IMAL872D6JJftIRi9BBG5hoPPy/008G9pgFxaXtFv8Yi1DH+AyyVQldz1FUfWgTuzb X-Received: by 2002:a02:cc89:: with SMTP id s9mr5077274jap.43.1624385021892; Tue, 22 Jun 2021 11:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624385021; cv=none; d=google.com; s=arc-20160816; b=O1ksu2k4N7+g3wvxUdV3bfXtCudDqX0vKN1QJ3SzLpLGjbsr08XhIRMkASenexEn77 +s/VCkCHzdjjUysKFcmeQYhlaPQu8zXFKVOUI4TCcdsPna09zIFxl3OLJb7jyPLxSUiN MV53SPT96Ee7cq6rbXpVgwsCGFeov2XsT9MHcktBAqLfBfm4J9DDYVAJNkie/IkFyL77 UJAE8I6NaHSvuxzUrdme56lo4Q28O05VydkUuInXcYJxs7VJhFfbuiU0G+0aMih1ae7y SbLbOoaeAaYmOraVZwyAEDhdYNEDw8KRiOkqG60BUvXUf0G6jC1CJs+4aOUlBH8GPsH/ PZBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:dkim-signature; bh=SUdiAi8V1y7Z3MBnbTcTkMuuwqyidzgCcsX7sikEJEQ=; b=IR38nR5rQxw/ngBp2i2G90EVY4Qt4v1PvS+zCH+cZvnqyfshhF7qyN+WTtkBrtRrfM 9sCM+DUl9taDC1BVV+eh+QN90G1RDH6OXuo0gsTMoymVeuBXPoP2afaOtUhBFiZ3TwPF /0RyV+8ZFTYmY6HKjuMzHro8UqClmBhJTowRHYE9S/lw5WeXy69m7tuDoV1w3ztnjN2P PB/Csu/D0Um+wfhSM4hkCsiYSwwMxjZ4OvTz8ciNJ6Xb9GKlopex713tpaOutIU2adzK DT0ebf3E+Qr/w6R7ACUiZzywFRd5P0b9t5K3XrjC0H39bd/AYg1HYIld6hrGs5oLel1W 2jvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=J1cfKg6x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si16295780iln.153.2021.06.22.11.03.28; Tue, 22 Jun 2021 11:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=J1cfKg6x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232766AbhFVSFK (ORCPT + 99 others); Tue, 22 Jun 2021 14:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232633AbhFVSEm (ORCPT ); Tue, 22 Jun 2021 14:04:42 -0400 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FDBC061147 for ; Tue, 22 Jun 2021 10:59:26 -0700 (PDT) Received: by mail-qt1-x849.google.com with SMTP id u11-20020a05622a010bb029024ec154fa8bso38991qtw.20 for ; Tue, 22 Jun 2021 10:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=SUdiAi8V1y7Z3MBnbTcTkMuuwqyidzgCcsX7sikEJEQ=; b=J1cfKg6xHabJrWb5g4kR0m+FmJsMCgYM/sH2Vkm0Hume9zJNWLXNMMNex29SDqNSup Ck1Hb7C8NT3hu22sk6V03qdNP9N5XUDZIYzxxu3ocjy1KkQ3O1kkKu9jIvzBXl9E0uvo jadWdl8W6QX0BsoeyZOEc7zCLQPfSfd6sxlzz77qU11Tu0EEAn/qkdTi/Kj42hwsf93b J71Cwi6DSSfGK/P91N8SQzHa5bC48CS5vj/EgdvVOdFoHvWoCpJY5ZvNU7a9PGx7UMpA Byuacb32QnUz0MuQpSzvfkRn5Pm/v/0Bj6onuXBv4kxUxsdZDfx/jXiZNo4UWQ8mTvtC Up4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=SUdiAi8V1y7Z3MBnbTcTkMuuwqyidzgCcsX7sikEJEQ=; b=QDh0K4TzpLN/IDeP6AWLB629opv+OatjglmWe8C+/xgOpqvASmzjtvzALh1LfZo9RJ 1cUrdOWfPOzlXRX2K3In5MaSbHHOGxylmuCbTEaJzb6aV52uA9rOzNACFamC+2AlgLb+ jRrGNRRF/ycxY+rWP0d56CXEK/3EkTmww9ggCRkuS6wj1TlCk2e5OzpdyjzJos+1TYaQ fOhOQdCep+i2Knn1DyGWcFVoOyih+TUbzm/Kh9ODEIj/TTDgRmANoF5sghp8m44DAdrz pDSBZ3e1uzOg6D3J9u4KAv0HSdl8wFKC8UW21aDkO6wQ3iNl8pMMCpoaW8RNAXsbwHlt 0SxA== X-Gm-Message-State: AOAM5329aPdQn7vMpNg+Y6629Cgjr6p/8czeXSFireBsoaER2PSb2baV tHszsBEVKqFb0zGk9e1aJvWdCLlOzKU= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:5722:92ce:361f:3832]) (user=seanjc job=sendgmr) by 2002:a25:c9c7:: with SMTP id z190mr6597910ybf.21.1624384765584; Tue, 22 Jun 2021 10:59:25 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 22 Jun 2021 10:57:24 -0700 In-Reply-To: <20210622175739.3610207-1-seanjc@google.com> Message-Id: <20210622175739.3610207-40-seanjc@google.com> Mime-Version: 1.0 References: <20210622175739.3610207-1-seanjc@google.com> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog Subject: [PATCH 39/54] KVM: x86/mmu: Get nested MMU's root level from the MMU's role From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Initialize the MMU's (guest) root_level using its mmu_role instead of redoing the calculations. The role_regs used to calculate the mmu_role are initialized from the vCPU, i.e. this should be a complete nop. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 6c4655c356b7..6418b50d33ca 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -4874,6 +4874,7 @@ static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu) g_context->get_guest_pgd = get_cr3; g_context->get_pdptr = kvm_pdptr_read; g_context->inject_page_fault = kvm_inject_page_fault; + g_context->root_level = new_role.base.level; /* * L2 page tables are never shadowed, so there is no need to sync @@ -4890,19 +4891,14 @@ static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu) * the gva_to_gpa functions between mmu and nested_mmu are swapped. */ if (!is_paging(vcpu)) { - g_context->root_level = 0; g_context->gva_to_gpa = nonpaging_gva_to_gpa_nested; } else if (is_long_mode(vcpu)) { - g_context->root_level = is_la57_mode(vcpu) ? - PT64_ROOT_5LEVEL : PT64_ROOT_4LEVEL; reset_rsvds_bits_mask(vcpu, g_context); g_context->gva_to_gpa = paging64_gva_to_gpa_nested; } else if (is_pae(vcpu)) { - g_context->root_level = PT32E_ROOT_LEVEL; reset_rsvds_bits_mask(vcpu, g_context); g_context->gva_to_gpa = paging64_gva_to_gpa_nested; } else { - g_context->root_level = PT32_ROOT_LEVEL; reset_rsvds_bits_mask(vcpu, g_context); g_context->gva_to_gpa = paging32_gva_to_gpa_nested; } -- 2.32.0.288.g62a8d224e6-goog