Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4964667pxj; Tue, 22 Jun 2021 11:54:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVMbpzLxKtJiedzv1gSetAMf548sDh/L64BsvjoVaks9Lqy4BkeXbkDh+IMHYJcVu/nVf7 X-Received: by 2002:a17:906:2892:: with SMTP id o18mr5460821ejd.370.1624388085730; Tue, 22 Jun 2021 11:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624388085; cv=none; d=google.com; s=arc-20160816; b=eSexkm46ObI7q5kXsz8jzA70jXy3mQ759wprTpmBHgZJvJaKP+V6sq+jDaDFrU97i3 PBjSCybdHsrYBcRJpj/0Ej62IGfd8D8Rn7wREZR63qMudEyBiAPuCPp+HMHHAXC0nyGw LfuJF6JXFqRsY1zBlduIU4Q42NDBGLgESkuXaV7uMUheF0ti/8ylA0O8oH+POp5WWF0Z 7DqIRlZvsRwcX1UDyMkPZSHHfxs5LgPNaoPzIakT03ac/4vauZ90t3yFW4y4e23mRJNa zNmbKGildFdfaL+gK+UUxEu5prgfPNqxzGMAbWmbKUcu27g8jbCc9qDuToLY0wWQWf6H 14Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:to:from:subject :message-id; bh=TbPADmoZkDzWURfgpLtzxu40fgO6x/Vbl98bC/1t9P4=; b=qq036onEBESV+490xJjZPr3Itmd1N0bOYg3/fTHzCmlzYI5Ma63FIiJPQivwink9yU /si9REUEfucjC3wh9omdDHAaiICSat5BmhnCzk9tGqSfKJDjAYG1fpOIZtmtNgwgE9gP yeGJJNiFjI397teBRS+M/dM/RK/UkyYz+tPNHMR2U+2e1KMN/OK67fDBghZB6jwfh95T up1iB2hcgg6Q0T5/mBUaZtj9NwFARe+Xj1NMTywSho1HqeJKOWJuGS7UAIF2F1I6rexO /SP1hLiN6DjsmBUY4x3XWayXzlPQf2XslGHY4k7aWEHnQXQQCBYdFcV08/Iv0TLhryDh efYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec18si9310354edb.387.2021.06.22.11.54.23; Tue, 22 Jun 2021 11:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232624AbhFVSzp (ORCPT + 99 others); Tue, 22 Jun 2021 14:55:45 -0400 Received: from cloud48395.mywhc.ca ([173.209.37.211]:35734 "EHLO cloud48395.mywhc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhFVSzo (ORCPT ); Tue, 22 Jun 2021 14:55:44 -0400 Received: from modemcable064.203-130-66.mc.videotron.ca ([66.130.203.64]:33440 helo=[192.168.1.179]) by cloud48395.mywhc.ca with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvlWZ-0002m9-QI; Tue, 22 Jun 2021 14:53:27 -0400 Message-ID: Subject: Re: [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep From: Olivier Langlois To: Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Jun 2021 14:53:27 -0400 In-Reply-To: <67c806d0bcf2e096c1b0c7e87bd5926c37231b87.1624387080.git.olivier@trillion01.com> References: <67c806d0bcf2e096c1b0c7e87bd5926c37231b87.1624387080.git.olivier@trillion01.com> Organization: Trillion01 Inc Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud48395.mywhc.ca X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - trillion01.com X-Get-Message-Sender-Via: cloud48395.mywhc.ca: authenticated_id: olivier@trillion01.com X-Authenticated-Sender: cloud48395.mywhc.ca: olivier@trillion01.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-06-22 at 11:45 -0700, Olivier Langlois wrote: > If an asynchronous completion happens before the task is preparing > itself to wait and set its state to TASK_INTERRUPTABLE, the > completion > will not wake up the sqp thread. > I have just noticed that I made a typo in the description. I will send a v2 of that patch. Sorry about that. I was too excited to share my discovery...