Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Jun 2021 22:51:34 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@oss.nxp.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>, netdev@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Mark Einon <mark.einon@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] ARM: dts: imx28: Add description for L2 switch on XEA
 board
Message-ID: <20210622225134.4811b88f@ktm>
In-Reply-To: <YNH3mb9fyBjLf0fj@lunn.ch>
References: <20210622144111.19647-1-lukma@denx.de>
        <20210622144111.19647-2-lukma@denx.de>
        <YNH3mb9fyBjLf0fj@lunn.ch>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/0ciD4Jn3iAhV8jMTp1q0XYL"; protocol="application/pgp-signature"
Precedence: bulk

--Sig_/0ciD4Jn3iAhV8jMTp1q0XYL
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Andrew,

> On Tue, Jun 22, 2021 at 04:41:09PM +0200, Lukasz Majewski wrote:
> > The 'eth_switch' node is now extendfed to enable support for L2
> > switch.
> >=20
> > Moreover, the mac[01] nodes are defined as well and linked to the
> > former with 'phy-handle' property. =20
>=20
> A phy-handle points to a phy, not a MAC! Don't abuse a well known DT
> property like this.

Ach.... You are right. I will change it.

Probably 'ethernet' property or 'link' will fit better?


>=20
>   Andrew
>=20


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/0ciD4Jn3iAhV8jMTp1q0XYL
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmDSTVYACgkQAR8vZIA0
zr3wEwf+OHIgqiJP60VV3awR0B5lu4awGcOFGqK5MEB+Zhddu4xs1J7Hp6FcYMxa
m6hLxvWMgQW2c07AOFabjSwyAy6YsrZeWp4EejnlnyGAS79QQUYglCtmfq+Mkgwm
4pXZIYQlSz2mxGlauZeD8TFEAQUNkqtyaEL2umFcxhOj31IRTaM3WMfo0w5p1zoJ
c4ndU0zn3zJgQo5ohk3y3R/l5MfHu0SrexUSLfy0tGlv3ED4ZjsMn2zgBMuBe1Qh
rXjQO84IW1XYLWZme+XCd9B0n9lPlw/uz48v4vVFHDgwAH5Z65qONfQ+LxQOBy/9
KIjP6WqdJaV3eEQJhCq7B5IbJiSGeQ==
=T/Td
-----END PGP SIGNATURE-----

--Sig_/0ciD4Jn3iAhV8jMTp1q0XYL--