Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <be4b635675df2111cb7c095013323b3ba1ac246e.camel@ndufresne.ca>
Subject: Re: [PATCH v3 4/8] media: Add P010 video format
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Ezequiel Garcia <ezequiel@collabora.com>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        hverkuil@xs4all.nl, p.zabel@pengutronix.de, mchehab@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
        gregkh@linuxfoundation.org, mripard@kernel.org,
        paul.kocialkowski@bootlin.com, wens@csie.org,
        jernej.skrabec@siol.net, emil.l.velikov@gmail.com,
        andrzej.p@collabora.com, jc@kynesim.co.uk, jernej.skrabec@gmail.com
Cc:     kernel@pengutronix.de, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 22 Jun 2021 17:24:34 -0400
In-Reply-To: <fbf31c292fde2f7dafb1441fc85a1ead34fdf96d.camel@collabora.com>
References: <20210618131526.566762-1-benjamin.gaignard@collabora.com>
         <20210618131526.566762-5-benjamin.gaignard@collabora.com>
         <fbf31c292fde2f7dafb1441fc85a1ead34fdf96d.camel@collabora.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le vendredi 18 juin 2021 à 16:38 -0300, Ezequiel Garcia a écrit :
> Hi Benjamin,
> 
> On Fri, 2021-06-18 at 15:15 +0200, Benjamin Gaignard wrote:
> > P010 is a YUV format with 10-bits per pixel with interleaved UV.
> > 
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> > ---
> > version 2:
> >  - Add documentation about P010 padding
> >  - Fix the number of bits per component (16)
> > 
> >  .../media/v4l/pixfmt-yuv-planar.rst           | 78 ++++++++++++++++++-
> >  drivers/media/v4l2-core/v4l2-common.c         |  1 +
> >  drivers/media/v4l2-core/v4l2-ioctl.c          |  1 +
> >  include/uapi/linux/videodev2.h                |  1 +
> >  4 files changed, 79 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > index 090c091affd2..af400d37c8fd 100644
> > --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > @@ -100,8 +100,13 @@ All components are stored with the same number of bits per component.
> >        - Cb, Cr
> >        - No
> >        - 64x32 macroblocks
> > -
> > -        Horizontal Z order
> > +    * - V4L2_PIX_FMT_P010
> 
> Do we have support in GStreamer (or elsewhere) for this?

I believe you wanted to ask for patched framework to exercise this ? Since both
FFMPEG and GSTreamer have had that format for ages. For GStreamer:

https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/blob/master/gst-libs/gst/video/video-format.h#L102

No V4L2 mapping upstream, but this is a bit normal, can't upstream a mapping for
something that does not exist yet.

> 
> Thanks,
> Ezequiel
>