Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5212949pxj; Tue, 22 Jun 2021 18:20:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw30++3HKpsHaL2hQLzhMb7B80OG47+mCbHkTwsu/ooN8gJPcgKTSTfyqu9FRoSoGuG7sFN X-Received: by 2002:aa7:d893:: with SMTP id u19mr8962827edq.304.1624411246077; Tue, 22 Jun 2021 18:20:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1624411246; cv=pass; d=google.com; s=arc-20160816; b=k2q33HqvdRC9Q+A6U0ggrxGcEzsNC0QDyHg5gZDYwwFd2gJxGnXUe+UDflgJRd/DPd y+23oh53lBPhtVCw50IJkRjq9ComHqXJ0uXM3cETWfv9cYRKbMJc8o1kTjpSvgPElgxJ SvKSXROh4RAky6SF4q/ZF2z2AQsm0Nu9OePWJvDW6VFULR+n7gwsWYuz98UrZelWm1QN pvaiW6/uCG5gPql/PqiXUREOjDMDfTjjZYnezC2c7IGYbuCVUbUL1aQNrNJrEqTLfpWO KE5mFnMGgzuSUeaWwY2GNwVxfZVmd7cNq+sXQysimkQzHOkqGhQHk9l36yrq8qRV9Xkc A3jQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature :dkim-signature; bh=GvV9lmAIy36rYy+R5rAmGbC1kZlFF6ooGsin9vXZqbU=; b=od5B3OH+jR5oSm2gO0D+aYjI4nJSy3tzpAM8emmipnntRjVAAXnJf+Nu2NrpSjGZ6g NBBrrGsjTsaBIqOhgO6OfoAmBhfOhFg13jcM9qElqx9OES3YAr581PUfFxtt/Et3MBpE 1AxOnyOWm+17keabxBtObt+zte8NKZmwUMUSMeld1zRS0ClKKCD7bPyIHNezaRphnnvR fv5iIdS6aXfLgILB6FpIBJXoBiaCgcLwxtPCR/Gm6AT6zGx1pFio79EBDU7iIaQsqz9D JzZRC1qJbBTfGx31Im9kV4GC4o/MiKHKTvpMKC6voSMuDls55xSwy8E+8HexkcPMi89G uvlg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KnnNZC3B; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TwY4T1VF; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si13017203ejl.563.2021.06.22.18.20.22; Tue, 22 Jun 2021 18:20:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KnnNZC3B; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TwY4T1VF; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbhFWBTe (ORCPT + 99 others); Tue, 22 Jun 2021 21:19:34 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:45366 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhFWBTd (ORCPT ); Tue, 22 Jun 2021 21:19:33 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15N1GGZl017647; Wed, 23 Jun 2021 01:17:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : content-type : mime-version; s=corp-2020-01-29; bh=GvV9lmAIy36rYy+R5rAmGbC1kZlFF6ooGsin9vXZqbU=; b=KnnNZC3B6Lqqv5IfE7KL0J5lK4sq1doXokiCCLZqgnU3VWGESh5Ex/YDcD212x8c0jbF AL6p3xFk49hN42R1Wh7h9yFUyr9MEJqA3yIEGIxqb5zNabOBBkDeDCr/wNerOMSjTCVP ohse/HjTpCuGVuWTx4xnSwir2KjZxEHnozDKnTxivls/vphXsKSMpCDVIHaQLjd0dUJd JPagu7DBUWdVNtcnXXV2sOxyIvjM5/W3DMc/lXy7tRj+NGG6wKI1j6nC/lfEpLXLw/DR 4HNnCqXAmTPGXcYFMPFHu+JQmdtboOnK2gvbzdlarlyOZxi78KnlJslckqvl+iqyh/PG 4w== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39b98vagf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jun 2021 01:17:11 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15N1FdZp137234; Wed, 23 Jun 2021 01:17:10 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by aserp3030.oracle.com with ESMTP id 3996mec0sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jun 2021 01:17:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDQo1bjlvSsltHEoscD60oOtAfndUauZTtABJEHNIdlZ8ox9jsJhFPASEdzvOxvvkbFFM1oGUNbPS6ezS3xCHefSp8aYfyYB8XxRLH68V1JP+nm4AOo97S0GKt5+oH1BMeJjRORgMxK9el1M7ppfxyntox/UVKzbCW+kU3cNC/CcXgUXnEGXzqah55BA8OicbB5b8cHXzwzCtruHFCrI3YAu11Qj7Fb6UL48+qkH7xO/YMIN2Y11O+FnYqNhjZPkQx0G3ph7Vj0iHHu52F3us1iYH0A1n6YQM6w+jlqkRCO7aLppqU3HdRBkT6SVepcK5R32x0kjFBudJvuwvhWMMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvV9lmAIy36rYy+R5rAmGbC1kZlFF6ooGsin9vXZqbU=; b=YrRdg+s3BZjpTMaKi6MAY1mW20GjvzaCvqSbjuOp/f3RxwH6Wimr08JCJa8aDJSEPeDrECma2lVzezNoV8tm3pOCA8C+xJIdyFPW8G+z9pixNnEpt4bRTPfFjdVsAyxk0wVJ6KYTeCcOVNAKJRg8JgGcrm7K47bkgxRMBNatFcr2fSso/JiaYro2OO7E3VuFO6t7/ZvFIYmXu4iiOMxRAmMBbzzFBVYrMe2nN4p0iqv2QBRCpFUeI5TmAMcZ/daP8JdQJhDByDGPMEvU3eXGQO323CRYNVQbqqufifb5W+8J8O8Cto/hpJZpG0j6Jhjv0Ok6bpC84/5CyT2LwdrwwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvV9lmAIy36rYy+R5rAmGbC1kZlFF6ooGsin9vXZqbU=; b=TwY4T1VF5inltCexJv0+bcZMUPWKB1CNsc4ycpmp5j6FPO/v95fJ00GySmhEosw4GEBo9sqViqXgluMrT84x9fZn4R06ZNx8uMgF9fsIQSrkRO++GXv5i5f6iZO1SP3lrfZfOoX9u4KaT+3GU5sdY+79+e3VRCpz9ug7fBv+sGo= Authentication-Results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=oracle.com; Received: from PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12) by PH0PR10MB5450.namprd10.prod.outlook.com (2603:10b6:510:ee::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19; Wed, 23 Jun 2021 01:17:08 +0000 Received: from PH0PR10MB4759.namprd10.prod.outlook.com ([fe80::4c61:9532:4af0:8796]) by PH0PR10MB4759.namprd10.prod.outlook.com ([fe80::4c61:9532:4af0:8796%7]) with mapi id 15.20.4242.024; Wed, 23 Jun 2021 01:17:08 +0000 To: Colin King Cc: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8 From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20210621151727.20667-1-colin.king@canonical.com> Date: Tue, 22 Jun 2021 21:17:06 -0400 In-Reply-To: <20210621151727.20667-1-colin.king@canonical.com> (Colin King's message of "Mon, 21 Jun 2021 16:17:27 +0100") Content-Type: text/plain X-Originating-IP: [138.3.200.58] X-ClientProxiedBy: SJ0PR05CA0010.namprd05.prod.outlook.com (2603:10b6:a03:33b::15) To PH0PR10MB4759.namprd10.prod.outlook.com (2603:10b6:510:3d::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SJ0PR05CA0010.namprd05.prod.outlook.com (2603:10b6:a03:33b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.7 via Frontend Transport; Wed, 23 Jun 2021 01:17:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f9e0dc0-7b33-41d0-542d-08d935e49eea X-MS-TrafficTypeDiagnostic: PH0PR10MB5450: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rBSzkAygFZpeU/Xb/RroWunWWRJpjAVNMMVt/AjfNk0fgqKku9nIXDkA2dOQbimx1Ifut9bcd5XOkLpLdR5WmltgV2WUeaxA8Yf75An7XB8jcbl05Z1kj2x5xptJF15723sEwwf+8I32mrw1PLIZE/wjy9H/L3hogeAQRHPQKeKXTy16x/zJ7whg64pE9ls3UJmyJjyUUo/zHGH2hP529blGGQd7+44Ns1Bmzh4+d695OTIIOLBnYjWMu/FX5/AxPrYWSlrp+t78SMLUl7Bykya8UQDOFC1hIPcbpYQ8PVDo8UEwouPIQlD36XY4XkJe9APrZ8TG/19CqWkxnUJltdL4zB6ZFG2C0n7Uj8ezvp5qomgnXnyvuvIMFTF4tunEOpO5LH9gtSrIajR4H7Fh5AfQebATXF/Hbit/ciG+BBN50ox+S6Kl7ysCMWrISSKCBVcmBx+FMjskfAdPr0II/C0ctIvf9fNmvX25pAdXYJiMW8VBpxVzyuPx7S1zINgB3WQKMpnaAA3Dw/jFC+dVssgYmZSVtvDgFqVEGwjvk6rJT6kq/pyzocyt2xZqA12otwuEHCpqg6cygcYCbIYcXA7Myuxi2Ua0pwfeLl2hOtAcjkya3TxBNC3xe3wQOK9Y0xgL6r/XPC/nHZmymfiZ5HHmzXsUCjv/mHS5WpV5y/o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(396003)(376002)(346002)(136003)(26005)(558084003)(66476007)(5660300002)(2906002)(6916009)(16526019)(8936002)(66946007)(8676002)(66556008)(186003)(55016002)(478600001)(38100700002)(38350700002)(52116002)(956004)(86362001)(7696005)(36916002)(54906003)(316002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vyFYV2Qm1gZ1yHpsOdndnz8i6MKlquEUFeME5TpTE0mUmR4eOvaZCXlbJHBZ?= =?us-ascii?Q?jF4+Sb3B9CO88coZPiWPaQimH4p1X2OAE0uQc8w0gM1qpTsJcvDGaHXYj5sM?= =?us-ascii?Q?nKH861r9rMKs7wxvJZctbF2xDbA/OvJxniEMMCWx+E8DiMQylT2RbIKb2cWf?= =?us-ascii?Q?4RcdoJsgEA6mFjEPxwALv7OKkdep7iZyT+Tk+rhU8ktltNCw9j3u7Km+Pcgn?= =?us-ascii?Q?VNP1p7wmvaJodme791smSR9Zv1Vw3PlKbPJDWwWckLuLg46zVmdd+Cm7gEUM?= =?us-ascii?Q?tkf1+rXBw/nbCIEtIt/MsN4s18efOUFHj4hozhoCKZY4BIJpTdfr/EvpODF4?= =?us-ascii?Q?4znSH+QghuGquSu6PpWzNY5Xg+L0oPf2XiSiC2S2nKmJtJRgbrRzHtRLAtlX?= =?us-ascii?Q?/MWhZqBcLtz/f+zI6tOUF6JMn7sPUEPJEJBDn2Yv2UfrouoiEltNOjBEhQjF?= =?us-ascii?Q?y1Ntoaw/FYJIsFRq89S4Iu5HfwchHU0rgFaCW1ZqVuoiu4QoZm0vwN0S3SjL?= =?us-ascii?Q?+8FDDpkbXPtRfFDq5/oAUl3qoztQ2uc1tgy1RdI9WQ0eyXnvPsvn0S6EkzjM?= =?us-ascii?Q?FlvGNibJ8yBsdTKIZHOV5Y3bg9enyj/f1+foyewziHGGa9ILkQue3EzaeMXs?= =?us-ascii?Q?+oLfxjE+Q50x5qBFJZxeM15yUrFCTdc5O834DNtomZPN5XWfpLvJPEUgR7OR?= =?us-ascii?Q?fihplUamTiHfsh3UUB5ckxf4IWsCusumegAHNkXOrSAWW0fEEVyBMcw8WhPo?= =?us-ascii?Q?nTauTnXXeSKG8Eu2yGQcV3CPei3rGT7ptTwdluwzqlZtelgGA6QmDGApLJYO?= =?us-ascii?Q?CgqFyetgUkBFq7XmED2dLquAFCBqYYOxYH7S73NxHxzQoS+R1lNSF5tEMEva?= =?us-ascii?Q?ZuqnzHq/sbWwWhyEL6cGTQ5BX6GwD5Weu/lqRdDLm2n84i3GW3PIt6LGnbfM?= =?us-ascii?Q?/eWa3eT74uJuYsd30OYWu4GLezStqQUKXJaJzi6rdSv2YMRaUDNYhu8ggG+7?= =?us-ascii?Q?EStQHQWSNnklCjmXboBvrsrsuY6T2dZ4Acg4CQlCVSAnbwNP36T5bs6lTcz8?= =?us-ascii?Q?8MJFceOyX4VfrHBqwLUottQzQUltGE/3XbeGLp4T9kweL6yVY8mjYhuOIfkV?= =?us-ascii?Q?Jd/5tiZsUCdiEhqyuDEoqbjPOqcc7tBfqVe5q02H4vTx8ZjCLjZi6Ahv/R7X?= =?us-ascii?Q?Hky/60rxvTETHjF5wRLIClQwP+qDyCglR9wgL386b+zOXvBqp/r9fovq0Yrv?= =?us-ascii?Q?gByuHLAfO62zjS5M8wUxsrHZStakXh28VpiKixAo0B3fnLPk4N6Ny+wQ3wnw?= =?us-ascii?Q?s/q/7PlQrL0RPNDKlv9AIA4W?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f9e0dc0-7b33-41d0-542d-08d935e49eea X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2021 01:17:08.5395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G4OAo+Q8pNi7x7NLEQIjS1x/yazgB588OaQG4vpoPu+Le5ib1GTaH810vfSmkC4/Bp4xwTu9p7xyxzHjop15Wv8w0f69Honl7hv+Roz/V94= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5450 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10023 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106230004 X-Proofpoint-ORIG-GUID: SmF2H3-Nz04OAX1pboUteVK_phkfHUQJ X-Proofpoint-GUID: SmF2H3-Nz04OAX1pboUteVK_phkfHUQJ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > The shifting of the u8 integer returned fom ahc_inb(ahc, port+3) by 24 > bits to the left will be promoted to a 32 bit signed int and then > sign-extended to a u64. Applied to 5.14/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering