Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     SeongJae Park <sj38.park@gmail.com>
Cc:     skashyap@marvell.com, jhasan@marvell.com,
        GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, himanshu.madhani@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH] scsi: bnx2fc: Remove meaningless
 'bnx2fc_abts_cleanup()' return value assignment
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135t9s5cy.fsf@ca-mkp.ca.oracle.com>
References: <20210618164514.6299-1-sj38.park@gmail.com>
Date:   Tue, 22 Jun 2021 22:05:25 -0400
In-Reply-To: <20210618164514.6299-1-sj38.park@gmail.com> (SeongJae Park's
        message of "Fri, 18 Jun 2021 16:45:14 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SA9PR13CA0100.namprd13.prod.outlook.com (2603:10b6:806:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.9 via Frontend Transport; Wed, 23 Jun 2021 02:05:28 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 47627a1f-9c7b-40b4-0bf9-08d935eb5fa0
X-MS-TrafficTypeDiagnostic: MWHPR10MB1997:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB19971E19DDC054087F710F6D8E089@MWHPR10MB1997.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:854;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5S94H3zLnYhLK7vcaE1TvDRoMQrvu0cdq7ywTKJ+0+nnBSnizPjiC1KprU5At1w+WdPOMnK8muShlQkSNLsBZEJMj70UhH7AvySpruQ+lsMDyBcQCQLQLpux0OCcchPs+CxVvvO5y0K91A0UcxERAAulLzKpfWl9bPz1Q2jzyaPYINwPnW49zLb+QLhObPudhpyCp+cKjDBJfE0q1yERQwPqlNLHcnPhAhzJRtrmaHWVwMixwQ7CHTs59xZdZm69s1nMg7Ts4gdiWGebvhNLItRYLCUJvIbb1q3H7TKSPSh9wTPKcitA12ne0//o7kEt6BrOvjjD1q8AegqU4HulW5UkiRj1YWX/2VxIYIyIcekiSnBsdy5g2zAcR8pucVC/TRU6jPpJ0N6eaFtAWvwOYqT6NktZ0M4ySWXnTWuroZnrzk9wjwXgcP0OcF48S6BZB1bDCcR0o+PeqI02vzD8YqtgMfxxF9o9TP2hCrwy/mToAnJVqQ5Usafuv0Zvy9z0qCUyTn1GqIWczuaxAksY18TBHgNtSfMQCi4rTtpJ1g3gO76ZHlSSajxoLNnsLpyJuz+3qvlk5DCxdZz+idvw2g5vKC/ELNRgRwpzAkcAgfM76j2OA7cIKZlgZ9Bq3RKXWxb430yQpofyknPdyDS0hw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4754.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(136003)(376002)(39860400002)(366004)(36916002)(83380400001)(26005)(52116002)(7696005)(16526019)(186003)(478600001)(6916009)(38100700002)(55016002)(38350700002)(4326008)(8676002)(316002)(2906002)(8936002)(66946007)(956004)(66476007)(66556008)(4744005)(6666004)(5660300002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EzX6Bw+BoZyQFlxO7faloCRsBVSKIx7AWq1r4Rxs3ypXinhNO+Pf9P57BvhB?=
 =?us-ascii?Q?qJV2AfDlzzp4juSXEmdNlH5WqN1RMIs64vbGYjBKM7WhRPUclfPz6ekWMFxh?=
 =?us-ascii?Q?d5rtE7AiBtaLFkWizkFaxWgVkVk+f5yySpC87uZwN0/3ynOV6z7azfKk5Vot?=
 =?us-ascii?Q?xRyOa1PaRZChTUV3shfwwKGtRqt1HBj8Paxl+UnOhGP8lvgl4giLvhg404ux?=
 =?us-ascii?Q?1YmbHHpm4iW7+Lctfm3jJqwQVuZWX3MQZ6Uj8wgdArF9Psy1TFzuVgv1/aJL?=
 =?us-ascii?Q?mUKmQ8y7zJ9JYGFn3hYI7VdfbBHcIPmPJIIxGC3M2nRsBl/BgqWb1BUG+EYP?=
 =?us-ascii?Q?/oKwmEdlwc7AzgQsFPIG3wQdGbjBFEIvgmhG2e5cyb8LBV+8O0bLd2loCdHM?=
 =?us-ascii?Q?+h4sWU7ox450s6KGMAH5sAJ1oTYUWHOt+21yN45K+GTOGjppjxPbBHSjDExj?=
 =?us-ascii?Q?PbniB96LVlh25aMXigr2Vk0015YVZ8/XaeO4YImcKYPwGrujEHdnIROSxtoc?=
 =?us-ascii?Q?fSayoyl1ISJcgXOUX2nDDtdgulrMj7wTjLZQuYaOMDFVoszRfzeLyK9RMv/4?=
 =?us-ascii?Q?ha0tYm8pmfpBuOIR+bslBxrHBIBUizQQ9Ltw3+OBdKJPGCRLQDipzMv8rhng?=
 =?us-ascii?Q?acC5+YKOFUmPPYvEv0KRStHAnKy4cBqyupUsJdQVJDKFHQQ/UKo7ILoUk0Yl?=
 =?us-ascii?Q?rQufVD9Wmtu3j75njNKWXf8dexuyRG7r/GHlTgJ5if3fSB1ziv2c4mdZKvJH?=
 =?us-ascii?Q?GcjkSDiHiEP9SWLQf+8X42pA1knAkcsHOJxC5B0l2+R8cIv+7j19YxTJDv16?=
 =?us-ascii?Q?gIj39c4FIyooC6qduWGiK8105XEWdoTlLCnGgrrcl++/tac7cpyXLZpQCUBe?=
 =?us-ascii?Q?pMLjSMOBjL46XfcKKm/uctvWm5hxWExW2gO8w6M4MRvxNgWc2PzuVKuRFmNw?=
 =?us-ascii?Q?A+SktCB8u2gOidN+G6WP4FujE/ixSeyLFFbMOXttaYfXWCqVeXp9sEgV1C+7?=
 =?us-ascii?Q?a9Cr1SWbH6+jFOa2D0nEgluZHPaPqTqW8Ha/aBd+vqdhI+XmM+TFQyxvQqtM?=
 =?us-ascii?Q?ZQITwzs+BPR9+IX5qles65wcU3KFmjfJ/B2Ye56BekFydzZTtPyFF9cBBtq3?=
 =?us-ascii?Q?EvR97OUgqsrAntQe0A2KmICVcvLOILLTS+kGixE2BnWnJhmshVYcnRLcXmc8?=
 =?us-ascii?Q?CAprmOEiSLj8SUyINKpK1RSgq58bvFeLGUPi1al+HgfzrlmGzTYKON/m6nHs?=
 =?us-ascii?Q?JRvDr4twKe1A9XTrxdlL9f/VF5E9SMGaHi9KPc6HAIEqz1nEmyLM1E2vdWDD?=
 =?us-ascii?Q?+mUD0mhpuckkwnsvByNWKRS+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47627a1f-9c7b-40b4-0bf9-08d935eb5fa0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2021 02:05:28.8652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y3/P9v3JKXKUYyqYoS1pwcF6SAMStxMWp1LZebHpJ0b18plE/FyQjX1J3/P9EcXEPsl8z6u6iGtmObb9qZWNEjzkt8woQE1NZXhQbwidSOE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1997
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10023 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106230008
X-Proofpoint-ORIG-GUID: Agb9ayMvGBniOtImLfn1FkkeoyqDbVkG
X-Proofpoint-GUID: Agb9ayMvGBniOtImLfn1FkkeoyqDbVkG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


SeongJae,

> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is
> already in ABTS processing") made 'bnx2fc_eh_abort()' to return
> 'FAILED' when 'io_req' is alrady in ABTS processing, regardless of the
> return value of 'bnx2fc_abts_cleanup()'.  But, it left the assignment
> of the return value of 'bnx2fc_abts_cleanup()' to 'rc', which is
> meaningless now.  This commit removes it.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering