Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5361613pxj; Tue, 22 Jun 2021 22:52:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+ux0Yg9pcoLndpvejzWkqgcfwRTYtPuKAMHg91vothan3dL0U1UNLjWAR5t84tmrw0DUD X-Received: by 2002:a92:280a:: with SMTP id l10mr1754101ilf.265.1624427525308; Tue, 22 Jun 2021 22:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624427525; cv=none; d=google.com; s=arc-20160816; b=BWsbkcEL2xcTelsJmWvDweAuBvcYsqp3auZ6H4M0wJDuxVhO2pmmfoYIpWkSxSCZhN 74WyquJidWJPnSuLYT+UYfV+cChPfVnOJ0ovcuZDIFeoBCuM5fzT5GHNz4VG29TwXYCI 3r3qarGj5f4PXKrczy+cHW8nAEOSLnRgV18ckHMl3WXV+UvKb2VPJITa6Wp8av7iJ4QI FZNpH79a7YgvJiK5Qydpoz75dd5HeRuax2uaUeIaKa1NjFzmVpgDb3m8Hy0BxM9HDDtC BVuk5ltzm3mNq4jujO5XrFz2abP5C0ZpLhzaZqTZFL/M/s5Hgm8a4CqBukH/sMi11d6L /cgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gvifQC5IeicUDnWoUsRHMENVSvoiy4CqG/g46bHGIBE=; b=pzlHxTFpagk4eLeJ5/7j797z1B43RvAsV2RLEDl7JkSHnU6xDOKAbQ7SOhzJogYqd3 1M5tirJnUQf0QU6cCg+H7gNqXPMhiXSUHtEJs44vlZoUlMHNT46W4JO6TeerWeHJjh0z 3ALXdRG6hFGRwnFzG99+kJB7NMEnib0knYt3LzQwjz7A/iN1lljxChJdPPJ/Gjjfqs66 ZjtNJLXEqBpRj4yT5on6iqDmVvHO7tsTcn8min+uJpqzNBGVo+W0VB1vTvVUYc7Izy6W kssZi6vb2F+z/o+qXgPaRrhjU3aKVGEM4ALKP9eRZIN5lj9HhTj7BxpW9zd4+3B0ZhJW dXmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Nfhhac/b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t17si1836133jaj.108.2021.06.22.22.51.53; Tue, 22 Jun 2021 22:52:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Nfhhac/b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbhFWFxj (ORCPT + 99 others); Wed, 23 Jun 2021 01:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbhFWFxh (ORCPT ); Wed, 23 Jun 2021 01:53:37 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB653C061574 for ; Tue, 22 Jun 2021 22:51:18 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id u190so831381pgd.8 for ; Tue, 22 Jun 2021 22:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gvifQC5IeicUDnWoUsRHMENVSvoiy4CqG/g46bHGIBE=; b=Nfhhac/bZAPq4PYEl8wGoNG3LtOlUf0ySTTBOT1i1L2PgBv0e5wt01FLhqlJmLQz8j bkVCQAyMVaPjFnbOvJEsa/+w7he3kCWPerUO8x1LcddUFd7zGgL/G7/iplT3Ssaxmc9C +7CXA1AJ638YsSQeYWXKnMaIevl4qskFAg0xQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gvifQC5IeicUDnWoUsRHMENVSvoiy4CqG/g46bHGIBE=; b=KFyzpM7A84UZSa/GQapvxcASs/PKLX6X/RKdDTVlEzfz+xJ1PyrnHJ7bmcUOVospgp 5pgwQG6r3vYk0g4qit4SZDToQxJwoTXwbpCQR6hdDY696WMqlTc4eM5ELEWGw7JJCbk6 errqDZFYOm1+7aZoch6a7DpE96hAQcFvBFozQwcpD3CaRly3WLbm8D0w/TXepI7P3qRz aIZhGnMRgLVZuafU7WgvLr/hYBIJEotioR1BR/womSj7FzPo2/LnAZXGgGyxSp9ufDhq FxSDsYnrhE8HyEGjuEDRUi82HmyuC1HQXHxPxbKk7u5ykJk3QlFs9jGjlbmueE2dLXdc 8QsQ== X-Gm-Message-State: AOAM533qzgS3eb5nrewbjXQeTw3Jclv2TuOOMkB1SD1FMAPFdo+cwxhD 0wchpru8Q3DIKBkzVxlKlxch8CdprISvVxZ5 X-Received: by 2002:a63:5553:: with SMTP id f19mr2218816pgm.419.1624427478576; Tue, 22 Jun 2021 22:51:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v129sm1108705pfc.71.2021.06.22.22.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 22:51:17 -0700 (PDT) Date: Tue, 22 Jun 2021 22:51:17 -0700 From: Kees Cook To: Nathan Chancellor Cc: "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Sami Tolvanen , clang-built-linux@googlegroups.com Subject: Re: [PATCH 2/2] ACPI: bgrt: Use sysfs_emit Message-ID: <202106222250.7BD80A12FF@keescook> References: <20210623013802.1904951-1-nathan@kernel.org> <20210623013802.1904951-2-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210623013802.1904951-2-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 06:38:02PM -0700, Nathan Chancellor wrote: > sysfs_emit is preferred to snprintf for emitting values after > commit 2efc459d06f1 ("sysfs: Add sysfs_emit and sysfs_emit_at to format > sysfs output"). > > Signed-off-by: Nathan Chancellor Perhaps just squash this into patch 1? Looks good otherwise! -- Kees Cook