Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of cadence.com designates
 158.140.1.148 as permitted sender) receiver=protection.outlook.com;
 client-ip=158.140.1.148; helo=sjmaillnx2.cadence.com;
X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com
Received: from maileu3.global.cadence.com (10.160.88.99) by
 maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id
 15.0.1497.2; Wed, 23 Jun 2021 09:03:36 +0200
Received: from gli-login.cadence.com (10.187.128.100) by
 maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id
 15.0.1497.2 via Frontend Transport; Wed, 23 Jun 2021 09:03:36 +0200
Received: from gli-login.cadence.com (localhost [127.0.0.1])
        by gli-login.cadence.com (8.14.4/8.14.4) with ESMTP id 15N73ZJb047602;
        Wed, 23 Jun 2021 09:03:35 +0200
Received: (from pawell@localhost)
        by gli-login.cadence.com (8.14.4/8.14.4/Submit) id 15N73YV1047601;
        Wed, 23 Jun 2021 09:03:34 +0200
From:   Pawel Laszczak <pawell@cadence.com>
To:     <peter.chen@kernel.org>
CC:     <rogerq@kernel.org>, <a-govindraju@ti.com>,
        <gregkh@linuxfoundation.org>, <felipe.balbi@linux.intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kishon@ti.com>, <kurahul@cadence.com>, <sparmar@cadence.com>,
        Pawel Laszczak <pawell@cadence.com>, <stable@vger.kernel.org>
Subject: [PATCH] usb: cdns3: Fixed incorrect gadget state
Date:   Wed, 23 Jun 2021 09:02:47 +0200
Message-ID: <20210623070247.46151-1-pawell@gli-login.cadence.com>
X-Mailer: git-send-email 2.18.0
MIME-Version: 1.0
Content-Type: text/plain
X-OrganizationHeadersPreserved: maileu3.global.cadence.com
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4746d020-1207-405a-fd46-08d936150740
X-MS-TrafficTypeDiagnostic: BYAPR07MB4421:
X-Microsoft-Antispam-PRVS: <BYAPR07MB44218F27F9A339757026F1E6DD089@BYAPR07MB4421.namprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WhHrFPhodmV9QIKZcd6P5hyPhNPy1eg69XGBLfXQVD2VLWx+EHmy6eg4sDUim5qNg21UtQCQoDMwc3XtHUhY1RncBpNGRTufBWctG5xtda7bZpbol+I3SHIeYVArV7jlOX5n9XLWCWZ7mUr6rgK7sldDkyt7ch/5RzKIsjzwdK5lhpOCcqDKU6JkO4PTcyBgvtteqevRxZi9fc4suza1GSO8yZpbxaJgjeq93eM2ERTCD/5W2F4qoU+OuspggaLbE89vLzV7yDJ75ZpACNcVjNJEn1mOaShqDsk3lZcz7wz6tHPpAq0DbQZpXfOZ98mrrJChTTOoqu+2Ohf+XZIMaskODgn4EwoBJN6LfqPrZXBKXu8DsikfylveZO+OPmvixXEiheQRZT29Ik01am0kIaN1c0u3N3dwPtdX+YK8L/SI6cGRs8Fw+GRbJRur+xpoKnyqPQnAoCWLlg9eWWgDYNJoxME8CD6d89XODxiTAd5DA03TPQh8uwg6M7BKbMXGiB7blL3GtB3nFc9DsByeVeYgsH24LcKj8O1lGxCI3cvYdTuFPJdhi3bjaKkBCgbQhP8CvsqTXajXLU3OUQE8mt2qAro8r9mVaOpHL3CLSmZWTq0TsPW8TJY28AVkPaKDKLzWRFt7ypvDRiqOzWn4sYC81WwDPIZ/xY8AbofE36IRTn/ARk7KVWgbvRS8ketK
X-Forefront-Antispam-Report: CIP:158.140.1.148;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:sjmaillnx2.cadence.com;PTR:unknown.Cadence.COM;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(36092001)(36840700001)(46966006)(47076005)(8676002)(8936002)(42186006)(316002)(36906005)(336012)(54906003)(36860700001)(83380400001)(478600001)(186003)(426003)(26005)(1076003)(82740400003)(6916009)(2906002)(70206006)(86362001)(4326008)(356005)(6666004)(5660300002)(7636003)(82310400003)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2021 07:03:39.2918
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4746d020-1207-405a-fd46-08d936150740
X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9;Ip=[158.140.1.148];Helo=[sjmaillnx2.cadence.com]
X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT005.eop-nam12.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4421
X-Proofpoint-GUID: U7LeBa_1k7nXSsNerInqTtS_lLgeFkpc
X-Proofpoint-ORIG-GUID: U7LeBa_1k7nXSsNerInqTtS_lLgeFkpc
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-23_02:2021-06-22,2021-06-23 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 adultscore=0
 suspectscore=0 mlxlogscore=710 priorityscore=1501 impostorscore=0
 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1011
 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106230041
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Pawel Laszczak <pawell@cadence.com>

For delayed status phase, the usb_gadget->state was set
to USB_STATE_ADDRESS and it has never been updated to
USB_STATE_CONFIGURED.
Patch updates the gadget state to correct USB_STATE_CONFIGURED.
As a result of this bug the controller was not able to enter to
Test Mode while using MSC function.

Cc: <stable@vger.kernel.org>
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
 drivers/usb/cdns3/cdns3-ep0.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0.c
index 9a17802275d5..ec5bfd8944c3 100644
--- a/drivers/usb/cdns3/cdns3-ep0.c
+++ b/drivers/usb/cdns3/cdns3-ep0.c
@@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep,
 		request->actual = 0;
 		priv_dev->status_completion_no_call = true;
 		priv_dev->pending_status_request = request;
+		usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED);
 		spin_unlock_irqrestore(&priv_dev->lock, flags);
 
 		/*
-- 
2.25.1