Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Jun 2021 08:11:53 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc:     Alexandre Ghiti <alex@ghiti.fr>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Jisheng Zhang <jszhang@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        Zong Li <zong.li@sifive.com>, Anup Patel <anup@brainfault.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] riscv: Introduce set_kernel_memory helper
Message-ID: <YNLeuR9j5DE1zcLY@infradead.org>
References: <20210622082134.2404162-1-alex@ghiti.fr>
 <20210622082134.2404162-2-alex@ghiti.fr>
 <20210622225304.53d94c0b@xhacker>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210622225304.53d94c0b@xhacker>
Precedence: bulk

On Tue, Jun 22, 2021 at 10:53:04PM +0800, Jisheng Zhang wrote:
> >  
> > +__always_inline int set_kernel_memory(char *startp, char *endp,
> 
> If __always_inline, can it be moved to set_memory.h?

Yes, __always_inline pretty much only makes sense as
"static __always_inline" anyway.