Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6oxvM4+FlbPgMDpuvcb2OCD5VHajd82hNKVb6bGI4IYNu/RzmD6p5+VDoNJEEzmWip4HSqkUrZ
 JZyNcfTKzL0g==
IronPort-SDR: vX5NoCCcFe6G/piKXxfb0VjKG7o/NQbinEUDQlvfZeGQoKOww73c4fmF10koY6zCwMZTFR3FRp
 5SRQ+rkqTNUg==
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     David Gibson <david@gibson.dropbear.id.au>
CC:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "Alex Williamson (alex.williamson@redhat.com)" 
        <alex.williamson@redhat.com>, "Raj, Ashok" <ashok.raj@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Robin Murphy <robin.murphy@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "David Woodhouse" <dwmw2@infradead.org>,
        Jason Wang <jasowang@redhat.com>
Subject: RE: [RFC] /dev/ioasid uAPI proposal
Thread-Topic: [RFC] /dev/ioasid uAPI proposal
Thread-Index: AddSzQ97BhCb3gd8AUyldaDZ6yOMNAEqZK+AADR4pXACuXPOAAE11w8g
Date:   Wed, 23 Jun 2021 08:00:49 +0000
Message-ID: <MWHPR11MB188672DF8E0AC2C0D56EF86D8C089@MWHPR11MB1886.namprd11.prod.outlook.com>
References: <MWHPR11MB1886422D4839B372C6AB245F8C239@MWHPR11MB1886.namprd11.prod.outlook.com>
 <YLch6zbbYqV4PyVf@yekko>
 <MWHPR11MB188668D220E1BF7360F2A6BE8C3C9@MWHPR11MB1886.namprd11.prod.outlook.com>
 <YMrKksUeNW/PEGPM@yekko>
In-Reply-To: <YMrKksUeNW/PEGPM@yekko>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8H2llP44LElefVBZX64duZXMHhiNZe07g6HBeooER+YgVScenuUwq2zSmNE6?=
 =?us-ascii?Q?jkj/lkicguce81Zx3H8gq/1mSFgtLXizH4NyyK30RxUUspF9d1NBrhGp4g2f?=
 =?us-ascii?Q?cNl0lSHfk0gDETUucKpQMc8kTVnTQi/WA2e4mnoDQHCJ5/hf8o9m5jfmpTCo?=
 =?us-ascii?Q?baV1Jz1iyaS51JWAJgPLzHhWLzdN0kMWgc/y28CsnY5ueXC/aFJTwbD8re2K?=
 =?us-ascii?Q?EeL0Nl37NxnhradUkORqlm5mO/iLjZdCZKwZS1hwuVqfG4DPcM5rL3nNbx/C?=
 =?us-ascii?Q?sWmeCCQPFdan6RjL/BKu4K38/fccKlBvgAeAzSnUukWiNMk/SoDdos2yTY/e?=
 =?us-ascii?Q?V5MwTJeUaWcLCnblo960QA20gP1Ecfjw5Qam1HNSmAlZjLNpoA0xuboRY+jK?=
 =?us-ascii?Q?vj0iN3eK1sco8LTIZGUlVdzR2ufzf68C1ZjgZxjO3dGfR48Bzj5kAqNg0Nzr?=
 =?us-ascii?Q?aMhigmxw8mlztmAN6bFNA2vgAdjqVTR3Pu7IOhT0ONY3s1eIO91FHjQfuTS4?=
 =?us-ascii?Q?HfC6rrpxWq1tquXaqiUunXgsMWgfXYKyFsCnlmBltJesxshyD/qTWMNH97tq?=
 =?us-ascii?Q?XVysbs0g4m8TuRerALeA0rgdMvK0fN+lBtqRyG47Hu6ruQwjb1pzXjMD9AVn?=
 =?us-ascii?Q?BCS7E2V5EJpKp6izDttkUlGzI6h5+GTOsYOg2jGHbygzuxRgmhEKUkSyprLB?=
 =?us-ascii?Q?O9Re1yUzsFmOnPjLg2LNFnUIRQ8I67mxmC5G8Eu7UBcQ8S7FH7wtV2pThAXs?=
 =?us-ascii?Q?YpMOUfphrkQPnJwPdh9Kyxn7iGhX/10o1YvMuRMOwGLVg87m37icT8fLWKBq?=
 =?us-ascii?Q?MHg2CJp9FLs3ydtp98WVia2rvgQrm6TfNVT6FALonNNeMutjM0Ofpr4CjQPx?=
 =?us-ascii?Q?ZkiH08B2XsFML2DTmp3PHX+GqBDfFiWtb886gCYJcXGJBS6m/VmzO3DPvrUV?=
 =?us-ascii?Q?GMUW2UlEGsJfa1Az1YkqgVPoCoLHlWpeQHLlc9PjR5vKzUNcBi4yUrbBpVV7?=
 =?us-ascii?Q?FxX4L4Z5vxNec2pYZZHkKdZfXI8Dpt/srlZkLBjGAYkUXQ0QpzmWIYtFB45D?=
 =?us-ascii?Q?x5e+F8lCkyVakdBDg55i/E2G83uXFaZVTdxwyW2wF8mszsbWpH38iwr5SH7l?=
 =?us-ascii?Q?2AQFBNPzOiFHoGPoEKggmzkjgxzFXevy4QWoLe66ezU1A8c/uZ5D7AWXOx7c?=
 =?us-ascii?Q?ySVORtEWSjgqvUappdAK5gk6BBaMlyfTAr0RIy56GzesUsVqtsmZW3tD7eJw?=
 =?us-ascii?Q?to6mh/NDqrW0itgTFYOyrvzGv7c6Z2QUoOmUeLkGfO+jAz9L/gopCo8uxYZ2?=
 =?us-ascii?Q?0RgUXHyXeZlkeZG1eVIBLKij?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78aa1a14-4516-4f41-fcb1-08d9361d0392
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 08:00:49.0352
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KkAXK3VlLxAVMp4JSNV1X39BurHGiJjJbRiCwTfW5vU+AD3lhb4Fs1k0MB1Qjter8herewH5G0pMesWpiWi+0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1933
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: David Gibson
> Sent: Thursday, June 17, 2021 12:08 PM
>=20
> On Thu, Jun 03, 2021 at 08:12:27AM +0000, Tian, Kevin wrote:
> > > From: David Gibson <david@gibson.dropbear.id.au>
> > > Sent: Wednesday, June 2, 2021 2:15 PM
> > >
> > [...]
> >
> > > >
> > > > /*
> > > >   * Get information about an I/O address space
> > > >   *
> > > >   * Supported capabilities:
> > > >   *	- VFIO type1 map/unmap;
> > > >   *	- pgtable/pasid_table binding
> > > >   *	- hardware nesting vs. software nesting;
> > > >   *	- ...
> > > >   *
> > > >   * Related attributes:
> > > >   * 	- supported page sizes, reserved IOVA ranges (DMA
> mapping);
> > >
> > > Can I request we represent this in terms of permitted IOVA ranges,
> > > rather than reserved IOVA ranges.  This works better with the "window=
"
> > > model I have in mind for unifying the restrictions of the POWER IOMMU
> > > with Type1 like mapping.
> >
> > Can you elaborate how permitted range work better here?
>=20
> Pretty much just that MAP operations would fail if they don't entirely
> lie within a permitted range.  So, for example if your IOMMU only
> implements say, 45 bits of IOVA, then you'd have 0..0x1fffffffffff as
> your only permitted range.  If, like the POWER paravirtual IOMMU (in
> defaut configuration) you have a small (1G) 32-bit range and a large
> (45-bit) 64-bit range at a high address, you'd have say:
> 	0x00000000..0x3fffffff (32-bit range)
> and
> 	0x800000000000000 .. 0x8001fffffffffff (64-bit range)
> as your permitted ranges.
>=20
> If your IOMMU supports truly full 64-bit addressing, but has a
> reserved range (for MSIs or whatever) at 0xaaaa000..0xbbbb0000 then
> you'd have permitted ranges of 0..0xaaa9ffff and
> 0xbbbb0000..0xffffffffffffffff.

I see. Has incorporated this comment in v2.

>=20
> [snip]
> > > For debugging and certain hypervisor edge cases it might be useful to
> > > have a call to allow userspace to lookup and specific IOVA in a guest
> > > managed pgtable.
> >
> > Since all the mapping metadata is from userspace, why would one
> > rely on the kernel to provide such service? Or are you simply asking
> > for some debugfs node to dump the I/O page table for a given
> > IOASID?
>=20
> I'm thinking of this as a debugging aid so you can make sure that how
> the kernel is interpreting that metadata in the same way that your
> userspace expects it to interpret that metadata.
>=20

I'll not include it in this RFC. There are already too many stuff. The
debugging aid can be added anyway when it's actually required.=20

Thanks,
Kevin