Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5469209pxj; Wed, 23 Jun 2021 01:47:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSVmogWldrX+7JXg9RIBH1GhjdTrUvZNv3irhH0H5zVbSnNQ9m9dvl9SSV+vMD+nXFrjhO X-Received: by 2002:a05:6602:140e:: with SMTP id t14mr6194196iov.42.1624438025209; Wed, 23 Jun 2021 01:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624438025; cv=none; d=google.com; s=arc-20160816; b=VwD7n9Ae9167SW3Ydd/Lx3NKXCLVidFUdlC6fl+bext1TeP9N79hKesyeURxzsUYHS 2Nok9b10RhOs+FMzvtzI+/QcFMKMkYWt/SMWADC0GATk/pJseqhM6A9CUaaUesQYyliW VILKFhx1BY8xbuqKhNEjmIlDNgoZB8T6U3MZiR0hVea8gsep0bO/rdgJAvNK4ipxlC1B 0n76irRTziZU7lznN3P7o0YGGZJXGWv46AhX6YC4qYu8W54Ytremd+GH3NBoXbCGl03v TvoM9z437vaiyYqfgMNLKc8++cLhJrALEzv1L5YUxO5UlHa4N3xUgN2hsgtCHUnR2lNB Symg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PooNJ0YQxjhmU0UARjY2rX5OQyn63tkThp7tJ5mQ7xY=; b=YUPwaZjv3Lz0Zs/DssZ3+EWUTZ3eeiQXbZ6WICl1SDVSVqt4CQYFEW2IxvnpeMiy5h WyO63StYBvmCBS9R+DqcaiubQqLEV7f5+A0FBlCZ7MU72pJ0eLe8DfYaF0HDVu3wTIWx BfFq4U7Z1Cb3Spn1V2RywMUjn2K6TumrqwA1B6Fqob7QzkL0arljOiBoV5KmgA8efPSL ihcfL1woDFIsWKeRFqPzZad7wXLtVfaNX3r4od8igk14EapMAc271gVD+sxeW6eSgm5t 4EHwFOGeqakUmH4R1nhUznhs9zISIFyZjqPGJCSHNgKF28UaFyeFK0LtM6sa7tgma3Hg v96w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIp6rWO1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si2204569jae.125.2021.06.23.01.46.53; Wed, 23 Jun 2021 01:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIp6rWO1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhFWIsf (ORCPT + 99 others); Wed, 23 Jun 2021 04:48:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:56354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWIse (ORCPT ); Wed, 23 Jun 2021 04:48:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BB30610C7; Wed, 23 Jun 2021 08:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624437977; bh=8jQkB37uqAWt6krV1hPvPNgUzkw9Mnx+hbQaVHHdTR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZIp6rWO1wD0wYjQQAfNePphA2Hhmt0s0a5P2dttG2ktVcZjjIe2OOtlmGjYU4+/6L E5lhYFQ7BRVnM9eUtw5uqse3OzkYU7+sjzr8TIdZ0Y4G6qlLB/jmE1V6KW1Yur1YR/ Kky1sXOexGQ6ZDi79CQ3jW+c62dj7MTEJzu3eFB4/SGBSm+mlACDREASL6pOCYrkmJ kc8P4P3EUwnhNNO8NtLeqpkoNhcU9j8fE6TiirgYrJ3XBe2O3JJnxQCR7AtrCuJurt RZV6kuOVwPoyDTFswUsGRxDaIM+Z/3D0P1H09eOPUEQ9TFr6MA1wrMoU1BT1Ibs+jn z9T/2j61obCYg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lvyWV-0001s0-Rn; Wed, 23 Jun 2021 10:46:15 +0200 From: Johan Hovold To: Mauro Carvalho Chehab , Hans Verkuil Cc: Antti Palosaari , Eero Lehtinen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/2] Revert "media: rtl28xxu: fix zero-length control request" Date: Wed, 23 Jun 2021 10:45:20 +0200 Message-Id: <20210623084521.7105-2-johan@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210623084521.7105-1-johan@kernel.org> References: <20210623084521.7105-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 25d5ce3a606a1eb23a9265d615a92a876ff9cb5f. The patch in question causes a regression and was superseded by a second version. Unfortunately, the first revision ended up being applied instead of the correct one. Link: https://lore.kernel.org/r/YL3MCGY5wTsW2kEF@hovoldconsulting.com Signed-off-by: Johan Hovold --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index 83705730e37e..0cbdb95f8d35 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -612,9 +612,8 @@ static int rtl28xxu_read_config(struct dvb_usb_device *d) static int rtl28xxu_identify_state(struct dvb_usb_device *d, const char **name) { struct rtl28xxu_dev *dev = d_to_priv(d); - u8 buf[1]; int ret; - struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 1, buf}; + struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 0, NULL}; dev_dbg(&d->intf->dev, "\n"); -- 2.31.1