Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5477164pxj; Wed, 23 Jun 2021 02:01:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxG5Ygr9Lk4X2kzuHRhkZmX8oEB91idJFJBlyYsPFPWthdRcHRyC9AiRXTyNMW0zHBd9Qs X-Received: by 2002:a05:6402:2913:: with SMTP id ee19mr10784580edb.361.1624438880572; Wed, 23 Jun 2021 02:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624438880; cv=none; d=google.com; s=arc-20160816; b=btMnid+eJX+4l976CEjNW2SvLDKW7yZ0F35Re9pTi+MZcrdEDJKnt9R5HllN42nAFr 6iNE1VVqKIQZVMzzVOt/m+lGE+uFYUKnYbi78elRo4D1K8YyO/exa1nb5R6noLdiAXuX cfAy2RrCGFtRO18YjNI1q/RO2KelCplmRLINFXGscSuIyH5JeaCyJS1nS4ZGsDCfs/YO Vg5bUdir8c9Rx7pARRYC+JqEYHFViqEh50+SV4tgylxrqTS2721DYFT8YfkH6tvEahn/ EfPNHvoom2eS9s6AmhraWz77NSdh8UDKn2VyinHBbeRqeASECiam1D5ErOSJ9jZ+qAn6 VZDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=gfRtNgZ0h/SG0b61uvXv4mW/Zebi12Rwgh6ziBOpgulgLWfrpxLUGcEe1ane1OtH61 P0AJCy9llk2lY3L5Takqr8TuLSnZO9O0OF7Z5xb0dU7kK0QRx7dTECMG7LiYd4cEjQB/ CQy4J0X0QoiR3AS1z93fI2xDG0Sk2M3npLqY373ReCouZCLlM7GNvJbyoNbE/K7pIIz+ z6Q7oJUXF2C/4/6Yp1ATulOoZfxk2Q31t93xMlsCg4qu3kFUcdrCIfiQ08Ib3eFsBVCi l6pqi1wpyKsFaVFwiLlOjFSWMV2pJEB+KRaMHZIrGaDiZLEAKBPM3UhISOpfWKj0Tgq0 qi4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@monstr-eu.20150623.gappssmtp.com header.s=20150623 header.b=tdK9uAJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si5758381edc.537.2021.06.23.02.00.56; Wed, 23 Jun 2021 02:01:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@monstr-eu.20150623.gappssmtp.com header.s=20150623 header.b=tdK9uAJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbhFWJAH (ORCPT + 99 others); Wed, 23 Jun 2021 05:00:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbhFWJAG (ORCPT ); Wed, 23 Jun 2021 05:00:06 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC21C06175F for ; Wed, 23 Jun 2021 01:57:48 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id my49so2825856ejc.7 for ; Wed, 23 Jun 2021 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=tdK9uAJWdmT+cTqTX4ozHwlgRi7wW7OUcIGpx+5Br2fodFNa+MnfUQZVAzgz1DMfXp n/6yy9sAzllko9mIwsv87gD1kCOH5+UvzuTO8Ov4YmQvbrKg9vhNxEnX9Bb3xpiNP2fH k9Oyze3A8ShMVN/bVHL82sBkwKgirt++Dw9dhx7H9AShjZynKsDqAx3QjkNyy+S3seYa O7aOzg7Mj0Cm2KxHYiHvi5dJSHR99JkBwPvAeetXr4PIjVliCzIaKYRVlGsyYaoAOytV AXOwIKzGUy2+Qw0GsQqKp2vE+Hbxv9yib/h1U+C6vqKY5DAWNhTnHvHGn5ed0S9mxQ6J iM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z6Z3rnoFwy3s+OnHi/sH1rvXTGduUYkOOkAbeaIPw4Q=; b=AHs5tXp39nKifgzidfKTYRlRBr4/SzolQpYVBg1OCLTG/Q0cuXEIU9I9hocX+aVHrz YGRGEkaOcktEOCYXcDU9VZKmeyErpxgLK9q/zPmXslfSH1aRsvJosBbQMNLkSD9Rsaki E47BM/c7m8sP5kavG/Wq7ss8XytPZnCL3bKRqMUdSjG5gcYIWftb8QkcIg8pESsOKwkp YSe0mrQDS4lDqP/DrrWMT+PL/OEuRuKgLsS3UIgVeiXVWjZdLmmF0H4OtFGuFsbkWJ6t smEr3jKk37IVSJvrkKijDjdAXbgbsnEmQPDzO31CU6cWcXZ1x/R4A8dIGjonnbSUKgKe xdjg== X-Gm-Message-State: AOAM533HXclQ8eu0L/STe04om+ZPWRclsgPSLhLQXONLCVOhq2hJ92oX x8V75Omjq5P0cZkBmD/8lzFmgIt1IMHj4YdIXYDP0A== X-Received: by 2002:a17:906:ca4a:: with SMTP id jx10mr8892678ejb.200.1624438666647; Wed, 23 Jun 2021 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20200902150643.14839-1-krzk@kernel.org> <20200902150643.14839-2-krzk@kernel.org> In-Reply-To: <20200902150643.14839-2-krzk@kernel.org> From: Michal Simek Date: Wed, 23 Jun 2021 10:57:35 +0200 Message-ID: Subject: Re: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe() To: Krzysztof Kozlowski , Wolfram Sang Cc: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sekhar Nori , Bartosz Golaszewski , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm , LKML , linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org st 2. 9. 2020 v 17:10 odes=C3=ADlatel Krzysztof Kozlowski = napsal: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/i2c/busses/i2c-xiic.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.= c > index 90c1c362394d..a97438f35c5d 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *p= dev) > init_waitqueue_head(&i2c->wait); > > i2c->clk =3D devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(i2c->clk)) { > - if (PTR_ERR(i2c->clk) !=3D -EPROBE_DEFER) > - dev_err(&pdev->dev, "input clock not found.\n"); > - return PTR_ERR(i2c->clk); > - } > + if (IS_ERR(i2c->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), > + "input clock not found.\n"); > + > ret =3D clk_prepare_enable(i2c->clk); > if (ret) { > dev_err(&pdev->dev, "Unable to enable clock.\n"); > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel I see that this didn't go through. Acked-by: Michal Simek Wolfram: Can you please apply? Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs