Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5487331pxj; Wed, 23 Jun 2021 02:15:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPvuDNwjj8+HdtCgYcL3t7cLzS46LegJQIKBAsFwPPgWinNkwynvQxDCy80xGTu9XhjuC5 X-Received: by 2002:a02:c6a6:: with SMTP id o6mr8048939jan.20.1624439749897; Wed, 23 Jun 2021 02:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624439749; cv=none; d=google.com; s=arc-20160816; b=leMkM9HW0Gy+ZTynmhJcSL7MF0J5jiSFFYCSTDbSagyMZDbfJGXMq7ycJptj+um753 gIMp9gSoskxwRuzEJeVukTe3q4grYagLyZMORt+OXwtcRWDPv+czUWsIebuwGG/J31yo hwr+LAPVlyoou/qj3w7sK7RgUGIdnC8gCr8fqUH+xg5tsxEAu7qgjR71jdkVFQFNBAQM ZI22gBkD/gk2kM2HW7FWFDabMrO9qNb9W4s0nu1tszf19KIWJfoYMpQTjVhSiuzsyAqT 7NsQUPwwA3JkwyoiEpd0wMzuW3NWLdhlg1xpffwvSvJQyFiiXSajKZEbWctXoskyEupu S7gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=suVqWljhaoclPO1eTv+M2ePvKbwY6hxOeLqa1AkB3Cc=; b=dsf/iVvj3BixMcaK2nLKG1VBcfqPPRfexzDu+f0GjYN8dLTXNrOQ35oImeUij4HeHn Ruf1xJtEZ8FFXrR4eUFkovaC7xJ0QxfkXKuYJ0R+SgNtfFtO9kYw1tOQYValb/kcVmC6 6WUTeSWYGjQqKaJV0+idKOb28VjZfi4+ZJHpiHDuWOSAC8kWc/1KVzpg/4riyQ1mpVVy ib4zpYxGAdd1p+mpmCNrAS/0i8SlMaak42rQhUg+AVoV6rCu7YnVdnd4PgqOkSj0aiFy heiZIIUgaNmMYEOBjUm8AHtzz8znn6V8amcVDxOP97rEdbewkzY8v1E8ayyIHs9HSBdw vIoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si5560413iln.135.2021.06.23.02.15.37; Wed, 23 Jun 2021 02:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbhFWJRE (ORCPT + 99 others); Wed, 23 Jun 2021 05:17:04 -0400 Received: from foss.arm.com ([217.140.110.172]:60362 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJRD (ORCPT ); Wed, 23 Jun 2021 05:17:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7696C31B; Wed, 23 Jun 2021 02:14:46 -0700 (PDT) Received: from [10.57.10.184] (unknown [10.57.10.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90D5A3F719; Wed, 23 Jun 2021 02:14:44 -0700 (PDT) Subject: Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com, dietmar.eggemann@arm.com, Chris.Redpath@arm.com, Beata.Michalska@arm.com, rjw@rjwysocki.net, amit.kachhap@gmail.com References: <20210622075925.16189-1-lukasz.luba@arm.com> <20210622075925.16189-4-lukasz.luba@arm.com> <20210622093258.lddlznwsndpw5mju@vireshk-i7> <20210623031517.tldkue7dcx4bt7gn@vireshk-i7> From: Lukasz Luba Message-ID: Date: Wed, 23 Jun 2021 10:14:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210623031517.tldkue7dcx4bt7gn@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 4:15 AM, Viresh Kumar wrote: > On 22-06-21, 12:07, Lukasz Luba wrote: >> That cpufreq_stats_record_transition() is present only if >> CONFIG_CPU_FREQ_STAT is set. I didn't wanted to be dependent on >> this config. > > Right, but you can also update the dummy > cpufreq_stats_record_transition() function as well and you won't > depend on the CONFIG then. It would look a bit 'hidden', but I can do that. It will require the header active_stats.h in that cpufreq.h to add the line in the empty cpufreq_stats_record_transition(). If Rafael would also agree, then I can put it there.