Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5516302pxj; Wed, 23 Jun 2021 03:03:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7jLqffNUPjKr+l2xFCkONTTwIGhnZl74imyFVp4KIUa87bDWwvKsQ2YTjH58bMZrTTo6g X-Received: by 2002:a17:907:2135:: with SMTP id qo21mr9140979ejb.385.1624442599303; Wed, 23 Jun 2021 03:03:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624442599; cv=none; d=google.com; s=arc-20160816; b=ibSZeL9rDGvmEVNeD4dasGCyVdpbhMQTTMOPtxzGYmHeF0KlvwFNsvaESgO4yG7FkL mXbLzriqt1mAngiPLYnnmrOpBAwvo6m/cNxpaHmSZv/FEG2L8l71Ckqj9BVGr/WGa0AU wNJ4p3F0lPoMVtgAvk5DYGW01Yy9+fWGFrH2aQ+GZCH4gnUewOMAg9M1I0dvlyxTOOdc XQaC/fhYM4UfxyT8lX/o85vhvBZ5ApXgZfEFkS6G5r2S9wMCnp7Evf8b9Z2ASTGIcDYk hLVzm6nPN5Wplh0C0E5134rk2YsBp0aKgRIAYzGetOjR9nS2nYg9BtzVgZlcJo+CsEaJ LepQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CSGLBSGhzPvCMVWNjOO3JeyQGg34Rd1O2fxAzMoSBS4=; b=oq7Ofxdh8idSsWi8rHxNRDnt+s0Qj1s65PNJKOkdWOYwBwQSO5FoLmbR+gqSduxSFg aIC4Xf04kftBgJwGf8n/SxC55ZIJGkYll7aXumQvUQU1wuDGg495IIzuCuAGErOrWLwR xMcGcDlCEFIg4zWUIZLhJJPn8mv66Q19OvSWa3mind1VGLlin539nNvkTSKdudrjSyGQ Ivm1UlolAR73sqEHM2PUjk2TPiVTtoV9mPv1yEo78KcXxmRM9g279swd5zd1BPvLfj7K BzY+thxkANVnhUNghcyIUOiMRYd2wIzOOqkgYPpLipva0pVV7+NKHmQZJIvc4GI/DGw+ dVhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=b8Jfm2zg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hy27si5260689ejc.213.2021.06.23.03.02.56; Wed, 23 Jun 2021 03:03:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=b8Jfm2zg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbhFWKCJ (ORCPT + 99 others); Wed, 23 Jun 2021 06:02:09 -0400 Received: from www.zeus03.de ([194.117.254.33]:50908 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbhFWKCE (ORCPT ); Wed, 23 Jun 2021 06:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=qu5snV65MT2dXm jt06pGR2OjRw6FIkGJrYDKJpHo0Xs=; b=b8Jfm2zgz3ETciAlTu3uo7WXsE1B7P UlIKEIxwOlbFfu73PmFwdUFjVIkvdwd0YOY18Zxgixf91mMUmeG/l7MBPl0EqwYp f94eOnCW4VRPQoY/8dAIAb64Ue0Q6U7omvV4Q1QrPsMhAWo3llMIBswZaNDBpt4e x2V1Drzge/+Fo= Received: (qmail 2551991 invoked from network); 23 Jun 2021 11:59:44 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Jun 2021 11:59:44 +0200 X-UD-Smtp-Session: l3s3148p1@1LFC92vFFKogARa4RfhaAavnjlTTqzSz From: Wolfram Sang To: linux-mmc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] i2c: imx: : use proper DMAENGINE API for termination Date: Wed, 23 Jun 2021 11:59:36 +0200 Message-Id: <20210623095942.3325-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210623095942.3325-1-wsa+renesas@sang-engineering.com> References: <20210623095942.3325-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dmaengine_terminate_all() is deprecated in favor of explicitly saying if it should be sync or async. Here, we want dmaengine_terminate_sync() because there is no other synchronization code in the driver to handle an async case. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-imx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index dc5ca71906db..b224e82924d2 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -423,7 +423,7 @@ static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx, return 0; err_submit: - dmaengine_terminate_all(dma->chan_using); + dmaengine_terminate_sync(dma->chan_using); err_desc: dma_unmap_single(chan_dev, dma->dma_buf, dma->dma_len, dma->dma_data_dir); @@ -899,7 +899,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, &i2c_imx->dma->cmd_complete, msecs_to_jiffies(DMA_TIMEOUT)); if (time_left == 0) { - dmaengine_terminate_all(dma->chan_using); + dmaengine_terminate_sync(dma->chan_using); return -ETIMEDOUT; } @@ -954,7 +954,7 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx, &i2c_imx->dma->cmd_complete, msecs_to_jiffies(DMA_TIMEOUT)); if (time_left == 0) { - dmaengine_terminate_all(dma->chan_using); + dmaengine_terminate_sync(dma->chan_using); return -ETIMEDOUT; } -- 2.30.2