Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] decnet: af_decnet: pmc should not be referenced when it's
 NULL
To:     13145886936@163.com, davem@davemloft.net, kuba@kernel.org
Cc:     linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, gushengxian <gushengxian@yulong.com>
References: <20210623033540.27552-1-13145886936@163.com>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <f9cfcede-2684-8723-4979-c0534d711483@gmail.com>
Date:   Wed, 23 Jun 2021 12:47:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210623033540.27552-1-13145886936@163.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/23/21 5:35 AM, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
> 
> pmc should not be referenced when it's NULL.
> 
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
>  net/decnet/af_decnet.c | 67 ++++++++++++++++--------------------------
>  1 file changed, 25 insertions(+), 42 deletions(-)
> 
> diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
> index 5dbd45dc35ad..be2758ac40cb 100644
> --- a/net/decnet/af_decnet.c
> +++ b/net/decnet/af_decnet.c
> @@ -152,7 +152,8 @@ static atomic_long_t decnet_memory_allocated;
>  
>  static int __dn_setsockopt(struct socket *sock, int level, int optname,
>  		sockptr_t optval, unsigned int optlen, int flags);
> -static int __dn_getsockopt(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen, int flags);
> +static int __dn_getsockopt(struct socket *sock, int level, int optname,
> +		char __user *optval, int __user *optlen, int flags);
>  
>  static struct hlist_head *dn_find_list(struct sock *sk)
>  {
> @@ -176,6 +177,7 @@ static int check_port(__le16 port)
>  
>  	sk_for_each(sk, &dn_sk_hash[le16_to_cpu(port) & DN_SK_HASH_MASK]) {
>  		struct dn_scp *scp = DN_SK(sk);
> +
>  		if (scp->addrloc == port)
>  			return -1;
>

Please do not add noise to your patch.

Never mix cleanups and a fix.

Also, decnet is no longer used, please do not send space cleanups.